In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000779 [In-Portal CMS] Install / Upgrages bug report always 2010-06-15 12:02 2010-07-22 15:07
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.0-RC1
Status closed Product Version 5.1.0-B2 Target Version 5.1.0
Time EstimateNo estimate
Summary 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
Description I have all modules (even paid) installed and I was trying to upgrade from 4.3.9 to 5.1.0-RC1. This all failed with large SQL error, that LanguageId column was missing in Phrase table, when upgrade script was trying to set index on it.

That's how we are performing upgrade through 2 or more versions now (e.g. from 5.0.0 to 5.0.2):

   1. run "before" php upgrade script for 5.0.1 version
   2. run "before" php upgrade script for 5.0.2 version
   3. run sqls from 5.0.1 to 5.0.2 version
   4. run "after" php upgrade script for 5.0.1 version
   5. run "after" php upgrade script for 5.0.2 version


This process is repeated for each upgradeable module.

I thought at first, that wrapping version upgrade scripts (php + sql) together will solve the problem:

   1. run "before" php upgrade script for 5.0.1 version
   2. run 5.0.1 version sqls
   3. run "after" php upgrade script for 5.0.1 version
   4. run "before" php upgrade script for 5.0.2 version
   5. run 5.0.2 version sqls
   6. run "after" php upgrade script for 5.0.2 version

But this wasn't helping. Because when 1st module upgrade scripts will delete column, that is used by 2nd module upgrade script, then we also got sql error.


And so another idea approached my mind: you all know, that don't have problems, when we upgrade for 1 version only (e.g. from 5.0.0 to 5.0.1 or from 5.0.1 to 5.0.2). I've created dependency list for each module, where I've listed what "Core" module version is required to perform successful upgrade to each of given module versions.
Additional Information What's in the patch:

1. upgrade system failure, when large version range is used for upgrade
2. sql error on 5.0.3-B1 upgrade of In-Portal
3. empty "Cache Handler" configuration variable dropdown after upgrade to 5.1.0-RC1
4. skin upgrade system
5. incomplete orders were not deleted, when In-Commerce 5.0.1 upgrade was made
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e2637a0da4f53bdb
Change Log Message
Estimate Points 0
Attached Files patch file icon upgrade_system_fix_core.patch [^] (47,269 bytes) 2010-06-15 12:02 [Show Content]
patch file icon upgrade_system_fix_modules.patch [^] (11,645 bytes) 2010-06-15 12:02 [Show Content]
patch file icon normalizing_510_upgrade_sql.patch [^] (1,234 bytes) 2010-06-15 12:18 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0002458)
alex (manager)
2010-06-15 12:20

I've compared database structure of In-Portal (+ all modules) upgraded from 4.3.9, that was upgraded to 5.1.0-RC1 and In-Portal (+ all modules) thats was cleanly installed from 5.1.0-RC1.

Patch "normalizing_510_upgrade_sql.patch" contains minor fixes to make both database structure look same.
User avatar (0002459)
alex (manager)
2010-06-15 12:23

Also line:
ALTER TABLE Events
    ADD AllowChangingSender TINYINT NOT NULL DEFAULT '0' AFTER ReplacementTags ,

should be changed to
ALTER TABLE Events
    ADD AllowChangingSender TINYINT NOT NULL DEFAULT '0' AFTER MessageType ,

In upgrade_system_fix_core.patch patch.
User avatar (0002464)
Dmitry (manager)
2010-06-15 15:06
edited on: 2010-06-15 15:06

Tested UPGRADE from 4.3.9 to 5.1.0-RC1 good, but had to adjust install/upgrades.php

Moved this part:
=============
// migrate email events
                $table_structure = $this->Conn->Query('DESCRIBE ' . TABLE_PREFIX . 'Events', 'Field');

                if (!array_key_exists('Headers', $table_structure)) {
                    $sql = 'ALTER TABLE ' . TABLE_PREFIX . 'Events
                            ADD `Headers` TEXT NULL AFTER `ReplacementTags`,
                            ADD `MessageType` VARCHAR(4) NOT NULL default "text" AFTER `Headers`';
                    $this->Conn->Query($sql);
                }
=============

Before this part:

=============
// alter here, because kMultiLanguageHelper::createFields
// method, called after will expect that to be in database
                $sql = 'ALTER TABLE ' . TABLE_PREFIX . 'Events
                            ADD AllowChangingSender TINYINT NOT NULL DEFAULT "0" AFTER MessageType ,
                            ADD CustomSender TINYINT NOT NULL DEFAULT "0" AFTER AllowChangingSender ,
                            ADD SenderName VARCHAR(255) NOT NULL DEFAULT "" AFTER CustomSender ,
                            ADD SenderAddressType TINYINT NOT NULL DEFAULT "0" AFTER SenderName ,
                            ADD SenderAddress VARCHAR(255) NOT NULL DEFAULT "" AFTER SenderAddressType ,
                            ADD AllowChangingRecipient TINYINT NOT NULL DEFAULT "0" AFTER SenderAddress ,
                            ADD CustomRecipient TINYINT NOT NULL DEFAULT "0" AFTER AllowChangingRecipient ,
                            ADD Recipients TEXT AFTER CustomRecipient,
                            ADD INDEX (AllowChangingSender),
                            ADD INDEX (CustomSender),
                            ADD INDEX (SenderAddressType),
                            ADD INDEX (AllowChangingRecipient),
                            ADD INDEX (CustomRecipient)';
                $this->Conn->Query($sql);

User avatar (0002467)
alex (manager)
2010-06-15 15:36

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
User avatar (0002585)
alex (manager)
2010-07-22 15:07

Closing, since 5.1.0 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r13780
Timestamp: 2010-06-15 15:36:27
Author: alex
Details ] Diff ]
Fixes 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
mod - /in-portal/branches/5.1.x/core/install/install_schema.sql Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/install_toolkit.php Diff ] File ]
add - /in-portal/branches/5.1.x/core/install/step_templates/skin_upgrade.tpl File ]
mod - /in-portal/branches/5.1.x/core/install/steps_db.xml Diff ] File ]
add - /in-portal/branches/5.1.x/core/install/upgrade_helper.php File ]
add - /in-portal/branches/5.1.x/core/install/upgrades.css File ]
mod - /in-portal/branches/5.1.x/core/install/upgrades.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/application.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/skins/skin_eh.php Diff ] File ]
Modules :: In-News: 5.1.x r13779
Timestamp: 2010-06-15 15:29:16
Author: alex
Details ] Diff ]
Bug 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
mod - /modules/in-news/branches/5.1.x/install/upgrades.php Diff ] File ]
Modules :: In-Link: 5.1.x r13778
Timestamp: 2010-06-15 15:29:02
Author: alex
Details ] Diff ]
Bug 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
mod - /modules/in-link/branches/5.1.x/install/upgrades.php Diff ] File ]
Modules :: In-Commerce: 5.1.x r13777
Timestamp: 2010-06-15 15:28:52
Author: alex
Details ] Diff ]
Bug 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
mod - /w/in-commerce/branches/5.1.x/install/upgrades.php Diff ] File ]
Modules :: In-Bulletin: 5.1.x r13776
Timestamp: 2010-06-15 15:28:34
Author: alex
Details ] Diff ]
Bug 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
mod - /modules/in-bulletin/branches/5.1.x/install/upgrades.php Diff ] File ]
Modules :: Custom: 1.1.x r13774
Timestamp: 2010-06-15 15:26:56
Author: alex
Details ] Diff ]
Bug 0000779: Upgrade from 4.3.9 to 5.1.0-RC1 of In-Portal fails
add - /modules/custom/branches/1.1.x/install/upgrades.php File ]

- Issue History
Date Modified Username Field Change
2010-07-22 15:07 alex Note Added: 0002585
2010-07-22 15:07 alex Status resolved => closed
2010-06-15 15:36 alex Note Added: 0002467
2010-06-15 15:36 alex Status reviewed and tested => resolved
2010-06-15 15:36 alex Fixed in Version => 5.1.0-RC1
2010-06-15 15:36 alex Resolution open => fixed
2010-06-15 15:36 alex Assigned To !COMMUNITY => alex
2010-06-15 15:36 alex Changeset attached 5.1.x r13780
2010-06-15 15:29 alex Changeset attached 5.1.x r13779
2010-06-15 15:29 alex Changeset attached 5.1.x r13778
2010-06-15 15:28 alex Changeset attached 5.1.x r13777
2010-06-15 15:28 alex Changeset attached 5.1.x r13776
2010-06-15 15:27 alex Changeset attached 5.1.x r13775
2010-06-15 15:26 alex Changeset attached 1.1.x r13774
2010-06-15 15:06 Dmitry Note Edited: 0002464 View Revisions
2010-06-15 15:06 Dmitry Note Added: 0002464
2010-06-15 15:06 Dmitry Status needs testing => reviewed and tested
2010-06-15 12:23 alex Note Added: 0002459
2010-06-15 12:20 alex Note Added: 0002458
2010-06-15 12:18 alex File Added: normalizing_510_upgrade_sql.patch
2010-06-15 12:02 alex Assigned To => !COMMUNITY
2010-06-15 12:02 alex Developer => alex
2010-06-15 12:02 alex Status active => needs testing
2010-06-15 12:02 alex File Added: upgrade_system_fix_modules.patch
2010-06-15 12:02 alex New Issue
2010-06-15 12:02 alex File Added: upgrade_system_fix_core.patch
2010-06-15 12:02 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e2637a0da4f53bdb



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker