In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
990 [In-Portal CMS] Data Management task always 2011-02-05 08:02 2012-07-25 05:32
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.2-B1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: https://groups.google.com/d/topic/in-portal-bugs/Al4Ifpdg0sQ/discussion
Change Log Message: Checked all configuration variables are actually used
Estimate Points: 1
Summary: 0000990: Check that all configuration variables being used
Description: In-Portal as 326 configuration settings, that can be changed in various configuration sections in all system parts.

It's time to check if all of these variable change does have impact on the system or not.
Steps To Reproduce:
Additional Information: Plan:
1. create a unix script to perform automatic check
2. export all configuration variable names into one file in one variable per line format
3. use that file as input for a unix command "find" command
4. this way "find" command will be called on all project files for each config variable separately and will output what's been found
5. there is surely a way to report only variables, that were not found at all

Idea is to automate process maximally.

Please inspect all modules.



Following configuration variables need to be implemented:
=========================================================
Category_ShowPick - show editor's pick categories above other categories when enabled
SocketBlockingMode - set socket blocking mode for all curl requests
Comm_City, Comm_Contacts_Additional, Comm_ZIP - show on all templates, where Comm_AddressLine1 configuration variable is used (e.g. orders_blocks.tpl in In-Commerce)


What is need to be done too:
============================
1. remember in order record (before user sends request to payment gateway; usually in ord:OnCompleteOrder event):
- currency (that was selected on front-end)
- totalamount of order in selected currency
Relationships
Attached Files: patch remove_unused_settings_core.patch (5,492) 2011-12-30 08:54
http://tracker.in-portal.org/file_download.php?file_id=1448&type=bug
patch remove_unused_settings_modules.patch (33,146) 2011-12-30 08:54
http://tracker.in-portal.org/file_download.php?file_id=1449&type=bug
rar search_toolkit.rar (9,368) 2011-12-30 08:55
http://tracker.in-portal.org/file_download.php?file_id=1450&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005009
2012-07-25 05:32 alex Status resolved => closed
2012-01-03 04:43 alex Changeset attached 5.2.x r14969
2011-12-30 08:58 alex Note Added: 0004367
2011-12-30 08:58 alex Status reviewed and tested => resolved
2011-12-30 08:58 alex Fixed in Version => 5.2.0-B1
2011-12-30 08:58 alex Resolution open => fixed
2011-12-30 08:58 alex Assigned To !COMMUNITY => alex
2011-12-30 08:58 alex Changeset attached 5.2.x r14964
2011-12-30 08:58 alex Note Added: 0004366
2011-12-30 08:58 alex Status needs testing => reviewed and tested
2011-12-30 08:57 alex Changeset attached 5.2.x r14963
2011-12-30 08:57 alex Changeset attached 5.2.x r14962
2011-12-30 08:57 alex Changeset attached 5.2.x r14961
2011-12-30 08:57 alex Changeset attached 5.2.x r14960
2011-12-30 08:56 alex Time Estimate Removed 2 =>
2011-12-30 08:56 alex Assigned To alex => !COMMUNITY
2011-12-30 08:56 alex Developer => alex
2011-12-30 08:56 alex Status needs work => needs testing
2011-12-30 08:56 alex Note Added: 0004365
2011-12-30 08:55 alex File Added: search_toolkit.rar
2011-12-30 08:54 alex File Added: remove_unused_settings_modules.patch
2011-12-30 08:54 alex File Added: remove_unused_settings_core.patch
2011-12-30 07:24 alex Note Added: 0004364
2011-12-30 07:23 alex Additional Information Updated bug_revision_view_page.php?rev_id=953#r953
2011-12-07 22:25 Dmitry Assigned To erik => alex
2011-10-22 05:38 alex Estimate Points => 1
2011-09-27 04:14 alex Time Estimate Added 2
2011-09-27 04:14 alex Additional Information Updated bug_revision_view_page.php?rev_id=850#r850
2011-09-26 04:21 alex Additional Information Updated bug_revision_view_page.php?rev_id=841#r841
2011-09-24 11:43 Dmitry Assigned To => erik
2011-09-24 11:43 Dmitry Status active => needs work
2011-09-24 11:43 Dmitry Target Version Icebox => 5.2.0
2011-02-05 08:02 alex Target Version 5.2.0 => Icebox
2011-02-05 08:02 alex New Issue
2011-02-05 08:02 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/Al4Ifpdg0sQ/discussion
2011-02-05 08:02 alex Change Log Message => Checked all configuration variables are actually used

Notes
(0004364)
alex   
2011-12-30 07:24   
Following configuration variables were deleted:
===============================================
User_Review_Deny
User_Votes_Deny
Comm_AllowOrderingInNonPrimaryCurrency
Comm_Allow_Order_Different_Types
Link_Highlight_OpenTag
Link_Highlight_CloseTag
Link_RatingToPop
Link_UrlStatus
News_Highlight_CloseTag
News_Highlight_OpenTag
Posts_NewDays
Topic_Highlight_CloseTag
Topic_Highlight_OpenTag
Search_Link_CatchedRating
Search_Link_CatchedReviewsQty
Search_Link_CatchedVotesQty
Search_Link_CreatedOn
Search_Link_Description
Search_Link_EditorsPick
Search_Link_Hits
Search_Link_HotItem
Search_Link_LinkId
Search_Link_Name
Search_Link_NewItem
Search_Link_PopItem
Search_Link_Priority
Search_Link_ResourceId
Search_Link_ReviewById
Search_Link_Status
Search_Link_Url

I haven't found usage of these variables, but maybe they are used in non-obvous way:
====================================================================================
eBay_RefundTypeAttributeId
eBay_ReturnPolicyAttributeId
eBay_ReturnPolicyAttributeValue
eBay_ReturnPolicyCharacteristicsSetId
eBay_ReturnPolicyDetailsAttributeId
eBay_ReturnRequestDaysAttributeId
(0004365)
alex   
2011-12-30 08:56   
I've used "search_toolkit.rar" to search for config variable usages.
(0004366)
alex   
2011-12-30 08:58   
Will test all together later.
(0004367)
alex   
2011-12-30 08:58   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000990: Check that all configuration variables being used
(0005009)
alex   
2012-07-25 05:32   
Since 5.2.0 version was released.