In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
964 [In-Portal CMS] Data Management feature request always 2011-01-11 10:27 2012-07-25 05:33
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: https://groups.google.com/d/topic/in-portal-dev/_zXDBTcrRiw/discussion
Change Log Message: Improved validation of user Login field
Estimate Points: 2
Summary: 0000964: Improvements to user Login field
Description: 1. Add Validation of user Login field by Regular Expression

a. Validate Login field by Regular Expiration hard-coded in users_config.php (allow alpha-numeric symbols and "_", "-", "." symbols ONLY - that all symbols won't break url, when used in mod-rewrite).

b. To prevent issues with Login for all existing users - add OldStyleLogin field to PortalUser table and set it to 1 for users, whose Login field doesn't match new style logins.

For users, who have OldStyleLogin field set don't perform Login field validation. Perform Login field validation for new user registrations.

Based on OldStyleLogin field make Login field editable on my profile page.

All mentioned above should happen, when "email as login" option is enabled.


2. Remove copying of Email into Login field when EmailAsLogin is selected

We have 2 login modes:
- by email
- by login

In case, when "EmailAsLogin" configuration is enabled, then email is copied into login field.

Since we add validation to login field (described above), then we shouldn't validate it when email is copied there. Also email coping seems a bit odd, so we should NOT copy email into Login field at all.

Make sure to check all themes and corresponding places in the code
Steps To Reproduce:
Additional Information: Without patch from 0001104 task Login field will always appear as required (even in "Email As Login" mode), when "simple" interface preset is used.
Relationships
parent of 0001363resolved  (5.2.1)alex User selector not working 
related to 0001014closed  (5.1.3)alex Unable to select user, that has ' in it's username 
related to 0001107closed  (5.2.0)alex Logical changes on user registration/my profile/forgot password forms 
related to 0001104closed  (5.1.3)alex Impossible to use OnAfterConfigRead event, when there is a system preset for a given unit config 
related to 0001201closed  (5.2.0)alex Fatal error during Installation on States import with MySQL in Strict Mode 
child of 0000778closed  (5.2.0)alex Improvements to Create User & Admin form in Admin 
Attached Files: patch improvements_to_email_as_login.patch (12,077) 2011-07-08 10:34
http://tracker.in-portal.org/file_download.php?file_id=1067&type=bug
patch improvements_to_email_as_login_themes.patch (2,183) 2011-07-13 06:28
http://tracker.in-portal.org/file_download.php?file_id=1071&type=bug
patch improvements_to_email_as_login_modules.patch (573) 2011-07-27 10:13
http://tracker.in-portal.org/file_download.php?file_id=1085&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005078
2012-07-25 05:33 alex Status resolved => closed
2012-07-22 07:27 alex Relationship added parent of 0001363
2012-02-06 04:04 alex Relationship added related to 0001201
2011-10-22 05:40 alex Estimate Points => 2
2011-09-02 07:31 alex Additional Information Updated bug_revision_view_page.php?rev_id=804#r804
2011-09-02 07:30 alex Relationship added related to 0001104
2011-08-24 03:28 alex Relationship added related to 0001107
2011-07-27 10:14 alex Changeset attached 5.2.x r14475
2011-07-27 10:13 alex File Added: improvements_to_email_as_login_modules.patch
2011-07-13 06:30 alex Changeset attached 1.2.x r14470
2011-07-13 06:29 alex Note Added: 0003628
2011-07-13 06:28 alex File Added: improvements_to_email_as_login_themes.patch
2011-07-11 07:21 alex Relationship added child of 0000778
2011-07-08 10:43 alex Target Version Icebox => 5.2.0
2011-07-08 10:43 alex Note Added: 0003614
2011-07-08 10:43 alex Status reviewed and tested => resolved
2011-07-08 10:43 alex Fixed in Version => 5.2.0-B1
2011-07-08 10:43 alex Resolution open => fixed
2011-07-08 10:43 alex Assigned To !COMMUNITY => alex
2011-07-08 10:43 alex Changeset attached 5.2.x r14447
2011-07-08 10:37 alex Note Added: 0003613
2011-07-08 10:37 alex Status needs testing => reviewed and tested
2011-07-08 10:35 alex Note Added: 0003612
2011-07-08 10:35 alex Assigned To => !COMMUNITY
2011-07-08 10:35 alex Developer => alex
2011-07-08 10:35 alex Status active => needs testing
2011-07-08 10:34 alex File Added: improvements_to_email_as_login.patch
2011-07-08 08:43 alex Description Updated bug_revision_view_page.php?rev_id=751#r751
2011-03-13 06:47 alex Relationship added related to 0001014
2011-01-11 10:41 Dmitry Description Updated bug_revision_view_page.php?rev_id=657#r657
2011-01-11 10:28 Dmitry Description Updated bug_revision_view_page.php?rev_id=656#r656
2011-01-11 10:27 Dmitry New Issue
2011-01-11 10:27 Dmitry Reference => https://groups.google.com/d/topic/in-portal-dev/_zXDBTcrRiw/discussion
2011-01-11 10:27 Dmitry Change Log Message => Improved validation of user Login field

Notes
(0003612)
alex   
2011-07-08 10:35   
Also method UsersItem::generatePassword added.
(0003613)
alex   
2011-07-08 10:37   
Will test later, but commit right now to ease merge process from 5.1.x branch.
(0003614)
alex   
2011-07-08 10:43   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000964: Improvements to user Login field
(0003628)
alex   
2011-07-13 06:29   
Theme patch additionally replaces <inp2:m_if check="conf_ConfigValue" name="Email_As_Login"> tag with <inp2:m_if check="u_UseUsernames"> tag to enhance developer understanding of template contents.
(0005078)
alex   
2012-07-25 05:33   
Since 5.2.0 version was released.