In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
955 [In-Portal CMS] Data Management bug report always 2010-12-29 11:20 2011-03-30 09:53
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.2-RC1  
Reference: https://groups.google.com/forum/?pli=1#!topic/in-portal-bugs/wny4O5DjwFA
Change Log Message: Fixed session expiration on file upload
Estimate Points: 0
Summary: 0000955: Strange error, while using flash uploader
Description: When you are trying to upload a file in Internet Explorer, then you'll get alert message with such text:

Error [-200]: 302
Occurred on file file_test.jpg

Everything works, when you try to repeat upload attempt.
Steps To Reproduce:
Additional Information: It was happening only, when "Session Security Check based on Browser Signature" was enabled. Since flash reported different user agent to PHP, so session expiration happened.
Relationships
related to 0000870closed  (5.1.2)alex Queuing events to uploader fails, when flash object isn't yet loaded 
related to 0000043closed  (5.2.0)alex SWFUploader and "Save" button. 
Attached Files: patch check_browser_signature_and_flash_uploader_fix.patch (618) 2010-12-29 11:20
http://tracker.in-portal.org/file_download.php?file_id=886&type=bug
patch use_session_from_post_when_flash_upload_happens.patch (1,787) 2011-03-08 07:31
http://tracker.in-portal.org/file_download.php?file_id=958&type=bug
patch first_upload_attempt_randomly_fails_fix.patch (1,621) 2011-03-08 07:38
http://tracker.in-portal.org/file_download.php?file_id=959&type=bug
Issue History
Date Modified Username Field Change
2012-01-11 08:10 alex Relationship added related to 0000043
2011-04-17 06:31 alex Relationship added related to 0000870
2011-03-30 09:53 Dmitry Note Added: 0003317
2011-03-30 09:53 Dmitry Status resolved => closed
2011-03-22 04:24 alex Note Added: 0003303
2011-03-22 04:24 alex Status reviewed and tested => resolved
2011-03-22 04:24 alex Fixed in Version => 5.1.2-RC1
2011-03-22 04:24 alex Resolution open => fixed
2011-03-22 04:24 alex Assigned To !COMMUNITY => alex
2011-03-22 04:24 alex Changeset attached 5.1.x r14263
2011-03-10 12:31 Dmitry Note Added: 0003292
2011-03-10 12:31 Dmitry Status needs testing => reviewed and tested
2011-03-08 07:39 alex Issue Monitored: Dmitry
2011-03-08 07:39 alex Note Added: 0003290
2011-03-08 07:39 alex Note Added: 0003289
2011-03-08 07:38 alex File Added: first_upload_attempt_randomly_fails_fix.patch
2011-03-08 07:37 alex Note Added: 0003288
2011-03-08 07:37 alex Status reviewed and tested => needs testing
2011-03-08 07:31 alex File Added: use_session_from_post_when_flash_upload_happens.patch
2011-03-08 06:41 alex Note Added: 0003287
2011-03-08 06:41 alex Target Version Icebox => 5.1.2
2011-01-10 12:32 Dmitry Note Added: 0003195
2011-01-10 12:32 Dmitry Status needs testing => reviewed and tested
2010-12-29 11:21 alex Assigned To => !COMMUNITY
2010-12-29 11:21 alex Developer => alex
2010-12-29 11:21 alex Status active => needs testing
2010-12-29 11:21 alex Reference => https://groups.google.com/forum/?pli=1#!topic/in-portal-bugs/wny4O5DjwFA
2010-12-29 11:20 alex New Issue
2010-12-29 11:20 alex File Added: check_browser_signature_and_flash_uploader_fix.patch
2010-12-29 11:20 alex Change Log Message => Fixed session expiration on file upload

Notes
(0003195)
Dmitry   
2011-01-10 12:32   
Patch tested good.
(0003287)
alex   
2011-03-08 06:41   
Moving to 5.1.2, since any major uploader problem is a high priority.
(0003288)
alex   
2011-03-08 07:37   
I've attached a patch "use_session_from_post_when_flash_upload_happens.patch" that raised the same error, but the source of the problem was in other place.

As you know during flash upload in Firefox cookies from Internet Explorer are provided to Flash (Flash bug) and I haven't visited a site in Internet Explorer, so no cookies there for this domain.

Now correct SID is provided in $_POST in flashsid variable, but no other sid is provided in GET/POST/COOKIE so during session initialization it assumes, that:
cookies are on + no sid in cookie -> do session expire redirect


I've fixed this by directly allowing session to be initialized with SID provided during flash upload no matter what cookies are provided.



Please check that session expiration do happen some time after this patch is applied.
(0003289)
alex   
2011-03-08 07:39   
I've also attached a patch "first_upload_attempt_randomly_fails_fix.patch" here, since it also fixes another problem with uploader, when you'll be getting "No Permission" error in "alert" window on first file upload attempt.
(0003290)
alex   
2011-03-08 07:39   
Reminder sent to: Dmitry

I hope that these 3 patches will deal with flash uploader bugs once and for all.
(0003292)
Dmitry   
2011-03-10 12:31   
All tested good on IE7&8, Firefox, Chrome and Safari!
(0003303)
alex   
2011-03-22 04:24   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000955: Strange error, while using flash uploader
(0003317)
Dmitry   
2011-03-30 09:53   
Closing, since 5.1.2 release has been released.