In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
943 [In-Portal CMS] Other bug report always 2010-12-01 15:37 2011-03-30 09:53
Dmitry  
alex  
normal  
closed 5.1.1  
fixed  
 
none 5.1.2-B1  
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/9670fee961612ddd#
Fixes minor issue with JS/CSS compression
0
0000943: Minor Issue with generating JS/CSS compressed files
There is an issue on some hosting server with generating JS/CSS compressed files. This issue is related to recent improvement which adds ability to use JAVA Class to do a better compression.

The following code haven't full worked as expected on examined hosting server:

[code]
$command = 'java -jar ' . dirname(__FILE__) . DIRECTORY_SEPARATOR . 'yuicompressor-2.4.2.jar --type ' . $extension . ' --charset utf-8 ' . $tmp_file;

$compressed_string = shell_exec($command);

unlink($tmp_file);

if (!is_null($compressed_string)) {
 $string = $compressed_string;
 return ;
}
[/code]

The solution is to add check if $compressed_string has any length.
patch Issue-with-generating-JS-CSS-compressed-files.patch (450) 2010-12-01 15:37
http://tracker.in-portal.org/file_download.php?file_id=865&type=bug
Issue History
2011-03-30 09:53 Dmitry Note Added: 0003360
2011-03-30 09:53 Dmitry Status resolved => closed
2011-01-05 05:43 alex Note Added: 0003156
2011-01-05 05:43 alex Status reviewed and tested => resolved
2011-01-05 05:43 alex Fixed in Version => 5.1.2-B1
2011-01-05 05:43 alex Resolution open => fixed
2011-01-05 05:43 alex Assigned To !COMMUNITY => alex
2011-01-05 05:43 alex Changeset attached 5.1.x r14117
2011-01-05 05:42 alex Note Added: 0003155
2011-01-05 05:42 alex Status needs testing => reviewed and tested
2010-12-01 15:37 Dmitry Note Added: 0003099
2010-12-01 15:37 Dmitry Assigned To => !COMMUNITY
2010-12-01 15:37 Dmitry Developer => Dmitry
2010-12-01 15:37 Dmitry Status active => needs testing
2010-12-01 15:37 Dmitry New Issue
2010-12-01 15:37 Dmitry File Added: Issue-with-generating-JS-CSS-compressed-files.patch
2010-12-01 15:37 Dmitry Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/9670fee961612ddd#
2010-12-01 15:37 Dmitry Change Log Message => Fixes minor issue with JS/CSS compression

Notes
(0003099)
Dmitry   
2010-12-01 15:37   
Please test the patch
(0003155)
alex   
2011-01-05 05:42   
ok
(0003156)
alex   
2011-01-05 05:43   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000943: Minor Issue with generating JS/CSS compressed files
Commit on behalf of Dmitry
(0003360)
Dmitry   
2011-03-30 09:53   
Closing, since 5.1.2 release has been released.