In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
933 [In-Portal CMS] Other bug report always 2010-11-23 19:22 2011-03-30 09:53
Dmitry  
alex  
normal  
closed 5.1.1-RC1  
fixed  
 
none 5.1.2-B1  
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/d4c6144e0adbc47f
Cleaned-up Phrases & Deprecated Code
0
0000933: Phrases & Code Clean-up in 5.1.2
Things covered in this task:

1. Checking and adding missing Phrases

2. Removing up old/unused Phrases

3. Removing up old/deprecated Code related to unused Phrases

4. DROP ErrorMessage field from PermissionConfig table not used anywhere
parent of 0000934closed  (1.1.2)alex Advanced Missing Phrase for In-Commerce Multicards Gateway 
patch Phrases-Code-Clean-up-CORE.patch (32,993) 2010-11-23 19:22
http://tracker.in-portal.org/file_download.php?file_id=857&type=bug
patch Phrases-Code-Clean-up-MODULES.patch (56,542) 2010-11-23 19:25
http://tracker.in-portal.org/file_download.php?file_id=858&type=bug
Issue History
2011-03-30 09:53 Dmitry Note Added: 0003338
2011-03-30 09:53 Dmitry Status resolved => closed
2011-01-11 04:37 alex Changeset attached 5.1.x r14161
2011-01-11 04:37 alex Note Added: 0003203
2011-01-11 04:37 alex Status reviewed and tested => resolved
2011-01-11 04:37 alex Fixed in Version => 5.1.2-B1
2011-01-11 04:37 alex Resolution open => fixed
2011-01-11 04:37 alex Assigned To !COMMUNITY => alex
2011-01-11 04:37 alex Changeset attached 5.1.x r14160
2011-01-11 04:37 alex Changeset attached 5.1.x r14159
2011-01-11 04:37 alex Changeset attached 5.1.x r14158
2011-01-11 04:36 alex Changeset attached 5.1.x r14157
2011-01-11 04:36 alex Changeset attached 1.1.x r14156
2011-01-11 04:36 alex Note Added: 0003202
2011-01-11 04:36 alex Status needs testing => reviewed and tested
2010-11-23 19:39 Dmitry Relationship added parent of 0000934
2010-11-23 19:39 Dmitry Note Added: 0002994
2010-11-23 19:39 Dmitry Assigned To => !COMMUNITY
2010-11-23 19:39 Dmitry Developer => Dmitry
2010-11-23 19:39 Dmitry Status active => needs testing
2010-11-23 19:25 Dmitry File Added: Phrases-Code-Clean-up-MODULES.patch
2010-11-23 19:22 Dmitry New Issue
2010-11-23 19:22 Dmitry File Added: Phrases-Code-Clean-up-CORE.patch
2010-11-23 19:22 Dmitry Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/d4c6144e0adbc47f
2010-11-23 19:22 Dmitry Change Log Message => Cleaned-up Phrases & Deprecated Code

Notes
(0002994)
Dmitry   
2010-11-23 19:39   
Please review and test.
(0003202)
alex   
2011-01-11 04:36   
Awesome work. Some minor phrases maybe missing, but they are not shown anywhere, so this could either "phrase_locator.php" script detection problem or we should simply check database for unused data.

This all could be addressed, when need, when this really becomes a problem.
(0003203)
alex   
2011-01-11 04:37   
Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000933: Phrases & Code Clean-up in 5.1.2
2. Commit on behalf of Dmitry
(0003338)
Dmitry   
2011-03-30 09:53   
Closing, since 5.1.2 release has been released.