In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
928 [In-Portal CMS] Admin Interfaces bug report always 2010-11-18 13:44 2011-03-30 09:53
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.1-RC1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.2-B1  
Reference: http://groups.google.com/group/in-portal-bugs/browse_thread/thread/c031349b294d44c0
Change Log Message: Removed forced sorting for Catalog Items in Admin
Estimate Points: 0
Summary: 0000928: Remove forced sorting for Catalog Items in Admin
Description: We need to remove ANY forced sorting (to the top) in Admin for Catalog Items.

Currently it's impossible to sort by Ids or other fields when Editors' Pick column forced to the top plus the Priority field.
Steps To Reproduce:
Additional Information:
Relationships
related to 0000931closed  (5.1.1)alex Category item sorting not displayed in Admin Console 
Attached Files: patch Remove-forcing-EditorsPick-sorting-Admin.patch (1,186) 2010-11-18 13:44
http://tracker.in-portal.org/file_download.php?file_id=845&type=bug
patch Remove-forcing-sorting-Admin-CORE.patch (2,966) 2010-11-18 14:51
http://tracker.in-portal.org/file_download.php?file_id=846&type=bug
patch Remove-forcing-sorting-Admin-MODULES.patch (5,020) 2010-11-18 14:51
http://tracker.in-portal.org/file_download.php?file_id=847&type=bug
patch Remove-forcing-sorting-Admin-CORE-v2.patch (2,443) 2010-11-20 15:18
http://tracker.in-portal.org/file_download.php?file_id=851&type=bug
patch Remove-forcing-sorting-Admin-MODULES-v2.patch (6,422) 2010-11-20 15:18
http://tracker.in-portal.org/file_download.php?file_id=852&type=bug
patch Remove-forcing-sorting-Admin-CORE-v3.patch (2,634) 2010-11-21 04:31
http://tracker.in-portal.org/file_download.php?file_id=853&type=bug
patch Remove-forcing-sorting-Admin-MODULES-v3.patch (10,001) 2010-11-21 04:31
http://tracker.in-portal.org/file_download.php?file_id=854&type=bug
Issue History
Date Modified Username Field Change
2011-03-30 09:53 Dmitry Note Added: 0003345
2011-03-30 09:53 Dmitry Status resolved => closed
2011-01-09 08:56 alex Note Added: 0003186
2011-01-09 08:56 alex Status reviewed and tested => resolved
2011-01-09 08:56 alex Fixed in Version => 5.1.2-B1
2011-01-09 08:56 alex Resolution open => fixed
2011-01-09 08:56 alex Assigned To !COMMUNITY => alex
2011-01-09 08:56 alex Changeset attached 5.1.x r14140
2011-01-09 08:55 alex Changeset attached 5.1.x r14139
2011-01-09 08:55 alex Changeset attached 5.1.x r14138
2011-01-09 08:55 alex Changeset attached 5.1.x r14137
2011-01-09 08:54 alex Changeset attached 5.1.x r14136
2010-11-21 04:43 alex Relationship added related to 0000931
2010-11-21 04:33 alex Note Added: 0002986
2010-11-21 04:33 alex Assigned To alex => !COMMUNITY
2010-11-21 04:33 alex Status needs testing => reviewed and tested
2010-11-21 04:33 alex Note Added: 0002985
2010-11-21 04:31 alex File Added: Remove-forcing-sorting-Admin-MODULES-v3.patch
2010-11-21 04:31 alex File Added: Remove-forcing-sorting-Admin-CORE-v3.patch
2010-11-20 15:19 Dmitry Note Added: 0002984
2010-11-20 15:19 Dmitry Assigned To !COMMUNITY => alex
2010-11-20 15:19 Dmitry Status needs work => needs testing
2010-11-20 15:18 Dmitry File Added: Remove-forcing-sorting-Admin-MODULES-v2.patch
2010-11-20 15:18 Dmitry File Added: Remove-forcing-sorting-Admin-CORE-v2.patch
2010-11-20 04:47 alex Note Added: 0002983
2010-11-20 04:47 alex Status needs testing => needs work
2010-11-18 14:51 Dmitry Note Added: 0002978
2010-11-18 14:51 Dmitry Status needs work => needs testing
2010-11-18 14:51 Dmitry File Added: Remove-forcing-sorting-Admin-MODULES.patch
2010-11-18 14:51 Dmitry File Added: Remove-forcing-sorting-Admin-CORE.patch
2010-11-18 14:50 Dmitry Change Log Message Removed forced sorting in Admin for Catalog items => Removed forced sorting for Catalog Items in Admin
2010-11-18 14:50 Dmitry Summary Remove forcing Editors Pick sorting in Admin for Catalog Items => Remove forced sorting for Catalog Items in Admin
2010-11-18 14:50 Dmitry Description Updated bug_revision_view_page.php?rev_id=618#r618
2010-11-18 14:04 alex Note Added: 0002977
2010-11-18 14:04 alex Status needs testing => needs work
2010-11-18 13:44 Dmitry Assigned To => !COMMUNITY
2010-11-18 13:44 Dmitry Developer => Dmitry
2010-11-18 13:44 Dmitry Status active => needs testing
2010-11-18 13:44 Dmitry New Issue
2010-11-18 13:44 Dmitry File Added: Remove-forcing-EditorsPick-sorting-Admin.patch
2010-11-18 13:44 Dmitry Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/c031349b294d44c0
2010-11-18 13:44 Dmitry Change Log Message => Removed forced sorting in Admin for Catalog items

Notes
(0002977)
alex   
2010-11-18 14:04   
Task is not about just removing Editor's Pick sorting. It's about admin user inability to fully control sorting in admin grids.

Also "Priority" column sorting bothers, since admin can't override it's effects.
(0002978)
Dmitry   
2010-11-18 14:51   
Please test again.
(0002983)
alex   
2010-11-20 04:47   
You've changed a bit too much. Now you even removed default front-end sorting, that admin user can control.

You should:
* initially keep Priority and EditorsPick sorting in unit config
* in OnAfterConfigRead:
** remove EditorsPick sorting (via "unset"), when config option disabled (both admin and front-end)
** remove Priority storting, when in admin

Don't code random code. You should always have "why?" question answer for every code line you created.
(0002984)
Dmitry   
2010-11-20 15:19   
Thanks for your comments. Please review this one!

Note that I am removing both Priority and Editors pick for Admin.
(0002985)
alex   
2010-11-21 04:33   
Patch "Remove-forcing-sorting-Admin-CORE-v3.patch" moves sorting code to new method.

Patch "Remove-forcing-sorting-Admin-MODULES-v3.patch" adds Priority column also to "Radio" grids and adds "CreatedOn" column to article list, since without it sorting mark wasn't displayed at all.
(0002986)
alex   
2010-11-21 04:33   
Tested with few minor adjustments. New patches uploaded.
(0003186)
alex   
2011-01-09 08:56   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000928: Remove forced sorting for Catalog Items in Admin
(0003345)
Dmitry   
2011-03-30 09:53   
Closing, since 5.1.2 release has been released.