In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
899 [In-Portal CMS] Template System feature request always 2010-10-22 18:13 2012-07-25 05:33
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.1-B2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: http://groups.google.com/group/in-portal-dev/browse_thread/thread/1cad125f5aeada6f
Change Log Message: Created new "CurrentPageLink" tag returning current Page URL
Estimate Points: 1
Summary: 0000899: Create new "m_CurrentPageLink" tag to return current Page URL
Description: Create new <inp2:m_CurrentPageLink skip_query="1"/> tag to return current Page URL (without re-assembling it). That "skip_query" param is optional and will skip the ?QUERY part.

For speed purposes use:

1. with query: $_SERVER['REQUEST_URI']
2. without query: preg_replace('/\?' . preg_quote($_SERVER['QUERY_STRING'], '/') . '$/', '', $_SERVER['REQUEST_URI'])

Note: as you can see no domain is added for faster performance
Steps To Reproduce:
Additional Information: Can't set 0.5 as a quote (mantis problem), so I set 1 hour, but I mean 0.5 hours.
Relationships
Attached Files: patch create_currentpagelink_tag_899.patch (537) 2011-09-30 08:47
http://tracker.in-portal.org/file_download.php?file_id=1172&type=bug
patch create_currentpagelink_tag_899.2.patch (684) 2011-10-04 10:20
http://tracker.in-portal.org/file_download.php?file_id=1207&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005101
2012-07-25 05:33 alex Status resolved => closed
2011-10-22 05:31 alex Estimate Points => 1
2011-10-05 07:20 alex Note Added: 0004014
2011-10-05 07:20 alex Status reviewed and tested => resolved
2011-10-05 07:20 alex Fixed in Version => 5.2.0-B1
2011-10-05 07:20 alex Resolution open => fixed
2011-10-05 07:20 alex Assigned To !COMMUNITY => alex
2011-10-05 07:20 alex Changeset attached 5.2.x r14634
2011-10-05 07:19 alex Assigned To alex => !COMMUNITY
2011-10-05 07:19 alex Status needs testing => reviewed and tested
2011-10-04 10:20 erik Note Added: 0004005
2011-10-04 10:20 erik Assigned To erik => alex
2011-10-04 10:20 erik Status needs work => needs testing
2011-10-04 10:20 erik File Added: create_currentpagelink_tag_899.2.patch
2011-10-04 10:02 erik File Deleted: create_currentpagelink_tag_899.2.patch
2011-10-04 09:59 erik File Added: create_currentpagelink_tag_899.2.patch
2011-10-03 12:14 alex Note Added: 0003978
2011-10-03 12:14 alex Assigned To alex => erik
2011-10-03 12:14 alex Status needs testing => needs work
2011-09-30 08:47 erik Time Estimate Removed 1 =>
2011-09-30 08:47 erik Note Added: 0003945
2011-09-30 08:47 erik Assigned To erik => alex
2011-09-30 08:47 erik Developer => erik
2011-09-30 08:47 erik Status needs work => needs testing
2011-09-30 08:47 erik File Added: create_currentpagelink_tag_899.patch
2011-09-26 04:02 alex Time Estimate Added 1
2011-09-26 04:02 alex Description Updated bug_revision_view_page.php?rev_id=831#r831
2011-09-26 04:02 alex Additional Information Updated bug_revision_view_page.php?rev_id=833#r833
2011-09-24 22:42 Dmitry Assigned To => erik
2011-09-24 22:42 Dmitry Status active => needs work
2011-09-24 22:42 Dmitry Target Version Icebox => 5.2.0
2010-10-22 18:13 Dmitry New Issue
2010-10-22 18:13 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/1cad125f5aeada6f
2010-10-22 18:13 Dmitry Change Log Message => Created new "CurrentPageLink" tag returning current Page URL

Notes
(0003945)
erik   
2011-09-30 08:47   
Patch uploaded - needs testing
(0003978)
alex   
2011-10-03 12:14   
1. Simple boolean type parameter value checks should be performed more generally, e.g.
array_key_exists('skip_query', $params) && $params['skip_query'] == 1
is transformed to:
isset($params['skip_query']) && $params['skip_query']

Also "isset" function works faster then "array_key_exists", so it's more preferable, when NULL isn't possible as array key value.

2. There should be always an empty line before function/method return statement

3. Add scope statement in tag method declaration and appropriate PhpDoc comment (as for all methods, created in 5.2.0 release). This can be done typing "/**" and then ENTER above function definition.
(0004005)
erik   
2011-10-04 10:20   
create_currentpagelink_tag_899.2.patch attached - needs testing
(0004014)
alex   
2011-10-05 07:20   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000899: Create new "m_CurrentPageLink" tag to return current Page URL
Commit on behalf of Erik
(0005101)
alex   
2012-07-25 05:33   
Since 5.2.0 version was released.