In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
880 [In-Portal CMS] Front End bug report always 2010-10-05 15:24 2010-11-30 12:48
phil  
alex  
normal  
closed 5.1.1-B1  
fixed  
 
none 5.1.1-B2  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/9fb2c6158ab20520
0
0000880: Category-based permission check not working on Home Page
Tags "m_CheckPermission" and "c_HasPermission" doesn't work, when used on home page (index.tpl template).

This happens, because current category is detected as "0" on that template, however it's 1 (ID of "Content"/"Home" category). In 4.x versions of In-Portal it indeed was 0. I supposed not all places were properly adapted to such ID change.

I propose, to set current category id ("m_cat_id" variable) to actual ID of "Content"/"Home" category, when it's equals to "0".
All places, that compare "m_cat_id" to "0" should be also checked and properly adapted.
patch home_page_permission_checking_fails.patch (12,063) 2010-10-05 16:18
http://tracker.in-portal.org/file_download.php?file_id=796&type=bug
Issue History
2010-11-30 12:48 Dmitry Note Added: 0003022
2010-11-30 12:48 Dmitry Status resolved => closed
2010-10-19 03:57 alex Note Added: 0002892
2010-10-19 03:57 alex Status reviewed and tested => resolved
2010-10-19 03:57 alex Fixed in Version => 5.1.1-B2
2010-10-19 03:57 alex Resolution open => fixed
2010-10-19 03:57 alex Assigned To !COMMUNITY => alex
2010-10-19 03:57 alex Changeset attached 5.1.x r13987
2010-10-13 23:46 Dmitry Note Added: 0002884
2010-10-13 23:46 Dmitry Status needs testing => reviewed and tested
2010-10-05 16:21 alex Target Version Icebox => 5.1.1
2010-10-05 16:20 alex Reporter alex => phil
2010-10-05 16:19 alex Note Added: 0002876
2010-10-05 16:18 alex Assigned To => !COMMUNITY
2010-10-05 16:18 alex Developer => alex
2010-10-05 16:18 alex Status active => needs testing
2010-10-05 16:18 alex File Added: home_page_permission_checking_fails.patch
2010-10-05 15:24 alex New Issue
2010-10-05 15:24 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/9fb2c6158ab20520

Notes
(0002876)
alex   
2010-10-05 16:19   
To test you can place this code:

C_VIEW: [<inp2:m_CheckPermission permissions="CATEGORY.VIEW"/>]

M_CAT_ID: <inp2:m_Get name="m_cat_id"/>

C_ID: <inp2:c_Field name="CategoryId"/>

ST_ID: <inp2:st_Field name="CategoryId"/>


in front of <inp2:m_RenderElement name="content" default_element="cms_content"/> tag in "default_design.des.tpl" file, as Phil did to see if 1st line of output changes after applying patch and other lines won't change.

Also test this on some other pages (virtual, template) to see if nothing global was broken.
(0002884)
Dmitry   
2010-10-13 23:46   
Good one - tested good, please commit
(0002892)
alex   
2010-10-19 03:57   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000880: Category-based permission check not working on Home Page
(0003022)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.