In-Portal Issue Tracker - In-Commerce
Viewing Issue Advanced Details
871 [In-Commerce] Shipping Engine task N/A 2010-09-22 13:53 2011-03-30 09:58
alex  
alex  
normal  
closed 5.1.0  
fixed  
 
none 5.1.1-B2  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/74b6305480f985db
0
0000871: 3rd refactoring of Shipping Quote Engines related to USPS
We have method, named "MakeUSPSOrder" in OrderEventHandler class. This not good, since we have separate class for USPS interaction code.

I propose to create universal method MakeOrder in each SQE (ShippingQuoteEngine) and move MakeUSPSOrder to one of them. This way we will determine SQE by shipping type used in order and delegate all specific processing to it.
patch usps_to_sqe_incommerce.patch (21,728) 2010-09-22 13:53
http://tracker.in-portal.org/file_download.php?file_id=784&type=bug
txt usps-sql-debug.txt (4,158) 2010-09-23 13:18
http://tracker.in-portal.org/file_download.php?file_id=787&type=bug
patch usps_to_sqe_incommerce_v2.patch (22,567) 2010-09-26 05:55
http://tracker.in-portal.org/file_download.php?file_id=788&type=bug
Issue History
2011-03-30 09:58 Dmitry Note Added: 0003389
2011-03-30 09:58 Dmitry Status resolved => closed
2010-09-27 12:43 alex Note Added: 0002870
2010-09-27 12:43 alex Status reviewed and tested => resolved
2010-09-27 12:43 alex Fixed in Version => 5.1.1-B2
2010-09-27 12:43 alex Resolution open => fixed
2010-09-27 12:43 alex Changeset attached 5.1.x r13985
2010-09-27 03:22 alex Target Version Icebox => 5.1.1
2010-09-26 20:12 Dmitry Note Added: 0002868
2010-09-26 20:10 Dmitry Note Added: 0002867
2010-09-26 20:10 Dmitry Assigned To Dmitry => alex
2010-09-26 20:10 Dmitry Status needs testing => reviewed and tested
2010-09-26 05:58 alex Assigned To alex => Dmitry
2010-09-26 05:58 alex Status needs work => needs testing
2010-09-26 05:55 alex File Added: usps_to_sqe_incommerce_v2.patch
2010-09-23 13:18 Dmitry File Added: usps-sql-debug.txt
2010-09-23 13:17 Dmitry Note Added: 0002863
2010-09-23 13:17 Dmitry Assigned To Dmitry => alex
2010-09-23 13:17 Dmitry Status needs testing => needs work
2010-09-22 13:55 alex Note Added: 0002860
2010-09-22 13:55 alex Assigned To gleb => Dmitry
2010-09-22 13:55 alex Developer => alex
2010-09-22 13:55 alex Status needs work => needs testing
2010-09-22 13:55 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/74b6305480f985db
2010-09-22 13:53 alex New Issue
2010-09-22 13:53 alex Status active => needs work
2010-09-22 13:53 alex Assigned To => gleb
2010-09-22 13:53 alex File Added: usps_to_sqe_incommerce.patch

Notes
(0002860)
alex   
2010-09-22 13:55   
1. usps_error(-s) variables renamed to sqe_error(-s)
2. invalid rates received from sqe are not saved to db
3. ord:MakeUSPSOrder was transformed to MakeOrder and moved to SQE class
(0002863)
Dmitry   
2010-09-23 13:17   
Tested and looks like we need some work.

For some reason we never got to "MakeOrder" with USPS. See part of DEBUG on occurred during Ship Order action.
(0002867)
Dmitry   
2010-09-26 20:10   
Reviewed and tested GOOD on 5.1.1-Beta1.

What the Intershipper part - it still should be working fine?
(0002868)
Dmitry   
2010-09-26 20:12   
Reminder sent to: alex

Also, I believe we should get this into 5.1.1 release to make our lives easier due to nature of the changes.
(0002870)
alex   
2010-09-27 12:43   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000871: 3rd refactoring of Shipping Quote Engines related to USPS
(0003389)
Dmitry   
2011-03-30 09:58   
Closing, since 5.1.1 release has been released.