In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
856 [In-Portal CMS] Data Management feature request N/A 2010-09-07 12:31 2012-07-25 05:33
Reporter: BaSSiST Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: http://groups.google.com/group/in-portal-dev/browse_thread/thread/bf986a48dc1eade5
Change Log Message: Add Priority handler to Core
Estimate Points: 2
Summary: 0000856: Add PriorityEventHandler to Core
Description: We have PriorityHelper in Core, but to have full priority functionality, developer also needs PriorityEventHandler, which currently is copied between projects.
Steps To Reproduce:
Additional Information: PriorityEventHandler allows to use more intuitive "Move Up"/"Move Down" functionality, which effectively cancels any other sorting, used in grid before.
Relationships
parent of 0001241closed  (5.2.0)alex Automatic redirect from ?env= urls to their mod-rewrite equivalents results in fatal error 
parent of 0001247closed  (5.2.0)alex Sql error on priorities recalculation for list without parent constrain 
Attached Files: patch priority_eh.patch (10,721) 2010-09-07 12:31
http://tracker.in-portal.org/file_download.php?file_id=747&type=bug
patch priority_eh_v2.patch (30,816) 2011-05-18 05:43
http://tracker.in-portal.org/file_download.php?file_id=1002&type=bug
patch priority_eh_v3.patch (30,659) 2011-05-26 03:15
http://tracker.in-portal.org/file_download.php?file_id=1020&type=bug
patch priority_eh_v4.patch (31,501) 2011-08-30 09:45
http://tracker.in-portal.org/file_download.php?file_id=1118&type=bug
patch priority_eh_v4_520.patch (34,737) 2011-10-03 09:47
http://tracker.in-portal.org/file_download.php?file_id=1182&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005093
2012-07-25 05:33 alex Status resolved => closed
2012-04-03 06:10 alex Relationship added parent of 0001247
2012-03-30 12:33 alex Relationship added parent of 0001241
2011-10-22 05:33 alex Estimate Points => 2
2011-10-03 11:14 alex Changeset attached 5.2.x r14615
2011-10-03 09:48 alex Note Added: 0003969
2011-10-03 09:48 alex Status reviewed and tested => resolved
2011-10-03 09:48 alex Fixed in Version => 5.2.0-B1
2011-10-03 09:48 alex Resolution open => fixed
2011-10-03 09:48 alex Assigned To !COMMUNITY => alex
2011-10-03 09:48 alex Changeset attached 5.2.x r14610
2011-10-03 09:47 alex Note Added: 0003968
2011-10-03 09:47 alex Status needs testing => reviewed and tested
2011-10-03 09:47 alex Time Estimate Removed 1 =>
2011-10-03 09:47 alex Status needs work => needs testing
2011-10-03 09:47 alex File Added: priority_eh_v4_520.patch
2011-09-26 04:55 alex Time Estimate Added 1
2011-09-23 20:36 Dmitry Change Log Message => Add Priority handler to Core
2011-09-23 20:36 Dmitry Note Added: 0003876
2011-09-23 20:36 Dmitry Status needs testing => needs work
2011-09-23 20:36 Dmitry Target Version Icebox => 5.2.0
2011-09-16 07:00 alex Note Added: 0003738
2011-08-30 10:24 alex Issue Monitored: alex
2011-08-30 09:46 alex Note Added: 0003701
2011-08-30 09:45 alex File Added: priority_eh_v4.patch
2011-05-26 03:16 alex Note Added: 0003504
2011-05-26 03:15 alex File Added: priority_eh_v3.patch
2011-05-18 05:45 alex Note Added: 0003423
2011-05-18 05:43 alex File Added: priority_eh_v2.patch
2010-09-07 12:33 alex Note Added: 0002788
2010-09-07 12:33 alex Assigned To => !COMMUNITY
2010-09-07 12:33 alex Developer => alex
2010-09-07 12:33 alex Status active => needs testing
2010-09-07 12:31 alex Reporter alex => BaSSiST
2010-09-07 12:31 alex New Issue
2010-09-07 12:31 alex File Added: priority_eh.patch
2010-09-07 12:31 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/bf986a48dc1eade5

Notes
(0002788)
alex   
2010-09-07 12:33   
To test you need add unit config prefix (that already uses Move Up/Move Down functionality) to "priorities_config.php" (via OnAfterConfigRead hook of course).
(0003423)
alex   
2011-05-18 05:45   
New "priority_eh_v2.patch" has:
1. all constrain related functionality build-in into kPriorityHelper class
2. all priority processing moved away from CategoriesEventHandler class
3. categories are has central priority processing via PriorityEventHandler class
4. PriorityEventHandler class now has full support of constrains
(0003504)
alex   
2011-05-26 03:16   
Patch "priority_eh_v3.patch" fixes:
1. newly created category in empty parent category always was created with -2 instead of -1 priority.
(0003701)
alex   
2011-08-30 09:46   
Patch "priority_eh_v4.patch" fixes case, when "move up/move down" toolbar buttons were used in subitem grid in temp table. In such case live table was used instead of temp!
(0003738)
alex   
2011-09-16 07:00   
Remove:

if ( $object->IsTempTable() ) {
    $table_name = $this->Application->GetTempName($table_name, 'prefix:' . $object->Prefix);
}

from preparePriorities method in latest patch. Without this fix priorities dropdown on item editing will be build purely from temp table and that's bad.
(0003876)
Dmitry   
2011-09-23 20:36   
Needs to be implemented for 5.2.0 (PHP 5)
(0003968)
alex   
2011-10-03 09:47   
Will test all together.
(0003969)
alex   
2011-10-03 09:48   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000856: Add PriorityEventHandler to Core
(0005093)
alex   
2012-07-25 05:33   
Since 5.2.0 version was released.