In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
854 [In-Portal CMS] Admin Interfaces feature request N/A 2010-09-02 06:01 2011-10-04 02:38
alex  
alex  
normal  
reviewed and tested 5.1.0  
open  
 
none  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/3f00ab8c635261b6
0
0000854: Possible improvements to grid date range filter
We have pretty obvious "grid_date_range_filter" filter, that allows to enter date interval (from and to date) to filter grid records by.

I think, that we could make interval selection easier by placing dropdown above date fields with such possible values:

    * empty value
    * today
    * yesterday
    * 1 week (today minus 1 week)
    * 1 month (today minus 1 month)
patch date_range_filter_improvement.patch (4,625) 2010-09-02 06:01
http://tracker.in-portal.org/file_download.php?file_id=745&type=bug
patch date_range_filter_improvement_v2.patch (5,119) 2010-09-06 12:58
http://tracker.in-portal.org/file_download.php?file_id=746&type=bug
Issue History
2011-10-04 02:38 alex Target Version 5.2.0 => Icebox
2011-10-04 02:38 alex Note Added: 0003985
2011-09-24 22:35 Dmitry Target Version Icebox => 5.2.0
2010-09-06 14:37 Dmitry Note Added: 0002783
2010-09-06 14:37 Dmitry Assigned To !COMMUNITY => alex
2010-09-06 14:37 Dmitry Status needs testing => reviewed and tested
2010-09-06 12:59 alex Note Added: 0002782
2010-09-06 12:59 alex Assigned To alex => !COMMUNITY
2010-09-06 12:59 alex Status needs work => needs testing
2010-09-06 12:58 alex File Added: date_range_filter_improvement_v2.patch
2010-09-06 12:51 Dmitry Note Added: 0002781
2010-09-06 12:43 alex Note Added: 0002780
2010-09-06 12:41 alex Note Added: 0002779
2010-09-06 12:39 Dmitry Note Added: 0002778
2010-09-06 12:39 Dmitry Assigned To !COMMUNITY => alex
2010-09-06 12:39 Dmitry Status needs testing => needs work
2010-09-06 12:38 alex Developer Dmitry => alex
2010-09-06 12:36 Dmitry Assigned To alex => !COMMUNITY
2010-09-06 12:36 Dmitry Developer alex => Dmitry
2010-09-06 12:36 Dmitry Status needs work => needs testing
2010-09-06 05:45 alex Issue Monitored: Dmitry
2010-09-06 05:45 alex Note Added: 0002775
2010-09-05 20:38 Dmitry Note Added: 0002765
2010-09-05 20:36 Dmitry Note Added: 0002764
2010-09-05 20:36 Dmitry Assigned To !COMMUNITY => alex
2010-09-05 20:36 Dmitry Status needs testing => needs work
2010-09-02 06:01 alex Assigned To => !COMMUNITY
2010-09-02 06:01 alex Developer => alex
2010-09-02 06:01 alex Status active => needs testing
2010-09-02 06:01 alex New Issue
2010-09-02 06:01 alex File Added: date_range_filter_improvement.patch
2010-09-02 06:01 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/3f00ab8c635261b6

Notes
(0002764)
Dmitry   
2010-09-05 20:36   
Thanks, but patch needs to be reassembled - there seems to be some code which is different from current latest repo version (in tpl file).
(0002765)
Dmitry   
2010-09-05 20:38   
Also, I propose to test and include this in the current release so we don't have issues with this later. I know it's not entirely what we are looking for, but we can end up with lots of broken patches lately.
(0002775)
alex   
2010-09-06 05:45   
Reminder sent to: Dmitry

No need for that, since there only 1 new tag in kDBTagProcessor and template grid_blocks.tpl is modified.
(0002778)
Dmitry   
2010-09-06 12:39   
Reviewed and tested - basic functionality works okay, but there an issue with Calendar format date hard-coded in the block (Europe date fo.

We should be able to auto-apply "Input DATE format" from currently selected language.

Please let me know your thoughts on this.
(0002779)
alex   
2010-09-06 12:41   
Reminder sent to: Dmitry

When task is in "Needs Testing" status, then please:
1. test it
OR
2. ask question without status change

Since when you change status back and forth to "Needs Testing", then your username is set as Developer, however it's not always true.

Maybe we should review issue state transition diagram to fit whatever action you are performing on tasks. This is not the first time with messed Developer field by the way.
(0002780)
alex   
2010-09-06 12:43   
Reminder sent to: Dmitry

Date format fix is pretty easy:

replace calendar_format="d/m/Y" to calendar_format="" in filter block DefineElement statement.
(0002781)
Dmitry   
2010-09-06 12:51   
Reminder sent to: alex

Actually, I have tried that already and then it adds the TIME to the drop-down which is not exactly what we need. In best case scenario we need to have just a DATE (no time) as we see now, but in proper format.

What you think?
(0002782)
alex   
2010-09-06 12:59   
Fixed.

Also fix for "grid_date_range_filter" name was added, when used from unit config field array generator (was "grid_date_rage_filter" there).
(0002783)
Dmitry   
2010-09-06 14:37   
Thanks, tested good!
(0003985)
alex   
2011-10-04 02:38   
Maybe we shouldn't hurry with putting this to 5.2.0