In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
852 [In-Portal CMS] Front End feature request N/A 2010-09-01 03:22 2012-07-25 05:32
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: minor OS Version:  
Status: closed Product Version: 5.1.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: http://groups.google.com/group/in-portal-bugs/browse_thread/thread/f94e4aa50c158934
Change Log Message: Improved m_GetConfig tag
Estimate Points: 1
Summary: 0000852: Improvements to m_GetConfig tag
Description: 1. Add "as_label" parameter - when used will assume that configuration variable value is phrase and translate it

2. Add "formatted" parameter - when used will use data from ConfigurationValues.ValueList field to transform OPTION_ID, stored in configuration field to OPTION_NAME, that is visible on administrative console configuration page.

For example variable "CookieSessions" has 3 values:
* 0 for "Query String (SID)";
* 1 for "Cookies";
* 2 for "Auto-Detect".

Tag <inp2:m_GetConfig name="CookieSessions"/> will return 0 or 1 or 2.
Tag <inp2:m_GetConfig name="CookieSessions" formatted="1"/> should return "Query String (SID)" or "Cookies" or "Auto-Detect".
Steps To Reproduce:
Additional Information:
Relationships
Attached Files: patch getconfig_tag_852.patch (1,127) 2011-12-01 10:12
http://tracker.in-portal.org/file_download.php?file_id=1336&type=bug
patch getconfig_tag_852.2.patch (1,125) 2011-12-02 11:54
http://tracker.in-portal.org/file_download.php?file_id=1340&type=bug
patch getconfig_tag_v3_formatted.patch (1,175) 2011-12-05 11:06
http://tracker.in-portal.org/file_download.php?file_id=1345&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005038
2012-07-25 05:32 alex Status resolved => closed
2011-12-05 11:07 alex Note Added: 0004206
2011-12-05 11:07 alex Status reviewed and tested => resolved
2011-12-05 11:07 alex Fixed in Version => 5.2.0-B1
2011-12-05 11:07 alex Resolution open => fixed
2011-12-05 11:07 alex Assigned To !COMMUNITY => alex
2011-12-05 11:07 alex Changeset attached 5.2.x r14833
2011-12-05 11:06 alex File Added: getconfig_tag_v3_formatted.patch
2011-12-02 16:14 alex Assigned To alex => !COMMUNITY
2011-12-02 16:14 alex Status needs testing => reviewed and tested
2011-12-02 11:56 erik Note Added: 0004197
2011-12-02 11:56 erik Assigned To erik => alex
2011-12-02 11:56 erik Status needs work => needs testing
2011-12-02 11:54 erik File Added: getconfig_tag_852.2.patch
2011-12-02 02:39 alex Note Added: 0004190
2011-12-02 02:39 alex Assigned To alex => erik
2011-12-02 02:39 alex Status needs testing => needs work
2011-12-01 10:12 erik Time Estimate Removed 1 =>
2011-12-01 10:12 erik Note Added: 0004188
2011-12-01 10:12 erik Assigned To erik => alex
2011-12-01 10:12 erik Developer => erik
2011-12-01 10:12 erik Status needs work => needs testing
2011-12-01 10:12 erik File Added: getconfig_tag_852.patch
2011-11-06 15:58 Dmitry Change Log Message => Improved m_GetConfig tag
2011-11-06 15:58 Dmitry Assigned To => erik
2011-11-06 15:58 Dmitry Status active => needs work
2011-10-22 05:37 alex Estimate Points => 1
2011-09-27 06:25 alex Time Estimate Added 1
2011-09-23 21:38 Dmitry Priority normal => minor
2011-09-23 21:38 Dmitry Target Version Icebox => 5.2.0
2010-09-01 03:22 alex New Issue
2010-09-01 03:22 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/f94e4aa50c158934

Notes
(0004188)
erik   
2011-12-01 10:12   
Patch attached - needs testing
(0004190)
alex   
2011-12-02 02:39   
1. checking that parameter "formatted" is passed to tag isn't enough, since it could be in a form formatted="0" and nothing should happen.

2. no point in selecting ElementType from db field and then comparing it in PHP, because ElementType field could be directly added to WHERE clause in SQL.

3. sql query not formatted according to rules (e.g. SELECT, FROM, WHERE keywords on a new lines).
(0004197)
erik   
2011-12-02 11:56   
Patch getconfig_tag_852.2.patch attached - needs testing

1. Made additional parameter value check
2. Changed SQL logic
3. Changed SQL formatting
(0004206)
alex   
2011-12-05 11:07   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000852: Improvements to m_GetConfig tag
Commit on behalf of Erik
(0005038)
alex   
2012-07-25 05:32   
Since 5.2.0 version was released.