In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
841 [In-Portal CMS] Admin Interfaces task N/A 2010-08-28 07:15 2010-11-30 12:48
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.1-B1  
Reference:
Change Log Message:
Estimate Points: 0
Summary: 0000841: Massive refactoring of "form_blocks.tpl" template
Description: I have applied "design approach" to every form block in administrative console. This allows to use less HTML to create new blocks and even allow to use single table to place form blocks into 2 or more columns on same form.

Additionally some small improvements were made:
* each block now have "title_text" parameter, that allows to specify field title in plain text (before only phrases can be used via "title" parameter)
* blocks "inp_label", "inp_edit_box" now have "after_text" parameter, that allows to specify text, that should be displayed after control (e.g. measure unit after input field)
* block "inp_edit_box" now can be used with FCKEditor
* block "inp_edit_options" now also processes "style" parameter
* block "inp_edit_checkboxes" now have "has_br" parameter, that allow to list each checkbox option at new line or one after another (as before)
Steps To Reproduce:
Additional Information: I recommend this task for 5.1.1 release, since whole "form_blocks.tpl" template is changed from top till bottom and we'll have many issues when we'll try to merge it later from further release.
Relationships
parent of 0000853closed  (5.1.1)alex Even smaller form block declarations 
parent of 0001051closed  (5.1.3)alex Problems with using TAB on editing forms in Admin Console 
parent of 0001354closed  (5.2.0)alex Minor fixes to form blocks 
Attached Files: patch massive_form_blocks_refactoring.patch (93,700) 2010-08-28 07:15
http://tracker.in-portal.org/file_download.php?file_id=733&type=bug
jpg form-refactorying-issue.jpg (102,741) 2010-08-29 19:40
http://tracker.in-portal.org/file_download.php?file_id=739&type=bug
jpg

patch massive_form_blocks_refactoring_v2.patch (93,688) 2010-08-31 11:20
http://tracker.in-portal.org/file_download.php?file_id=742&type=bug
Issue History
Date Modified Username Field Change
2012-07-12 09:07 alex Relationship added parent of 0001354
2011-05-15 08:25 alex Relationship added parent of 0001051
2010-11-30 12:48 Dmitry Note Added: 0003046
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-01 05:53 alex Relationship added parent of 0000853
2010-08-31 11:26 alex Note Added: 0002758
2010-08-31 11:26 alex Status reviewed and tested => resolved
2010-08-31 11:26 alex Fixed in Version => 5.1.1-B1
2010-08-31 11:26 alex Resolution open => fixed
2010-08-31 11:26 alex Changeset attached 5.1.x r13917
2010-08-31 11:23 Dmitry Note Added: 0002757
2010-08-31 11:23 Dmitry Assigned To Dmitry => alex
2010-08-31 11:23 Dmitry Status needs testing => reviewed and tested
2010-08-31 11:20 alex File Added: massive_form_blocks_refactoring_v2.patch
2010-08-31 11:19 Dmitry Assigned To alex => Dmitry
2010-08-31 11:19 Dmitry Developer alex => Dmitry
2010-08-31 11:19 Dmitry Status needs work => needs testing
2010-08-29 19:40 Dmitry File Added: form-refactorying-issue.jpg
2010-08-29 19:40 Dmitry Note Added: 0002753
2010-08-29 19:40 Dmitry Assigned To !COMMUNITY => alex
2010-08-29 19:40 Dmitry Status needs testing => needs work
2010-08-28 07:18 alex Note Added: 0002696
2010-08-28 07:18 alex Assigned To => !COMMUNITY
2010-08-28 07:18 alex Developer => alex
2010-08-28 07:18 alex Status active => needs testing
2010-08-28 07:15 alex New Issue
2010-08-28 07:15 alex File Added: massive_form_blocks_refactoring.patch

Notes
(0002696)
alex   
2010-08-28 07:18   
Test, that nothing has been broken due refactoring. Optionally new block parameters could be tested as well.
(0002753)
Dmitry   
2010-08-29 19:40   
Reviewed and tested - everything seems to be well, BUT:

1. in FF (for sure) all New Catalog Items and Sections have less space for Title field and more for input one (see attachment).
(0002757)
Dmitry   
2010-08-31 11:23   
Reviewed and tested on different versions again - works well - please commit.

NOTE: most likely issue was with Windows font set to 125% which can't be controlled here.
(0002758)
alex   
2010-08-31 11:26   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000841: Massive refactoring of "form_blocks.tpl" template
(0003046)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.