In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
811 [In-Portal CMS] Data Management task always 2010-07-23 16:44 2010-11-30 12:48
alex  
alex  
normal  
closed 5.1.0  
fixed  
 
none 5.1.1-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/9c86c0bc202bfb34
0
0000811: Move grid total function definition to grid
Currently we have automatic grid totals calculation functionality. To activate it you need:

    * totals_render_as="grid_total_row" parameter in "m_RenderElement" tag, that renders "grid" block
    * add "totals" key (possible values are SUM, COUNT, AVG or any MySQL aggregate function) in field declaration in "Fields" property in unit config

Such approach works, but won't allow to have different totals function based on place, where grid is used or special-based.

I propose to move "totals" option to field declaration in grid definition part, where "filter_block" is defined.
For backwards compatibility we could still look in old place, when we don't have "totals" option in grid definition.
related to 0000786closed  (5.1.1)alex Column totals block customization issues 
patch grid_total_definition_moved.patch (5,206) 2010-07-23 17:22
http://tracker.in-portal.org/file_download.php?file_id=688&type=bug
Issue History
2010-11-30 12:48 Dmitry Note Added: 0003068
2010-11-30 12:48 Dmitry Status resolved => closed
2010-08-28 16:26 alex Note Added: 0002716
2010-08-28 16:26 alex Status reviewed and tested => resolved
2010-08-28 16:26 alex Fixed in Version => 5.1.1-B1
2010-08-28 16:26 alex Resolution open => fixed
2010-08-28 16:26 alex Changeset attached 5.1.x r13884
2010-08-02 16:40 Dmitry Note Added: 0002654
2010-08-02 16:40 Dmitry Status needs testing => reviewed and tested
2010-08-02 12:28 alex Status needs work => needs testing
2010-08-02 11:13 Dmitry Assigned To !COMMUNITY => alex
2010-08-02 11:13 Dmitry Status needs testing => needs work
2010-07-31 13:19 Dmitry Target Version Icebox => 5.1.1
2010-07-31 09:08 alex Note Added: 0002634
2010-07-31 09:08 alex Assigned To alex => !COMMUNITY
2010-07-31 09:08 alex Status needs work => needs testing
2010-07-30 17:12 Dmitry Note Added: 0002617
2010-07-30 17:12 Dmitry Assigned To !COMMUNITY => alex
2010-07-30 17:12 Dmitry Status needs testing => needs work
2010-07-23 17:22 alex Assigned To => !COMMUNITY
2010-07-23 17:22 alex Developer => alex
2010-07-23 17:22 alex Status active => needs testing
2010-07-23 17:22 alex File Added: grid_total_definition_moved.patch
2010-07-23 16:44 alex Relationship added related to 0000786
2010-07-23 16:44 alex New Issue
2010-07-23 16:44 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/9c86c0bc202bfb34

Notes
(0002617)
Dmitry   
2010-07-30 17:12   
Can't apply the patch to 5.1.0
(0002634)
alex   
2010-07-31 09:08   
Re-assembling gave same patch as current.

Did you reverted all previously applied patches, before testing this one (it's standard test practice)?
(0002654)
Dmitry   
2010-08-02 16:40   
Tested good, please commit.
(0002716)
alex   
2010-08-28 16:26   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000811: Move grid total function definition to grid
(0003068)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.