In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
776 [In-Portal CMS] Localization bug report always 2010-06-13 23:24 2010-07-22 15:07
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.0-B2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.0-RC1  
Reference:
Change Log Message:
Estimate Points: 0
Summary: 0000776: Change usage of "lu_rootcategory_name" Language label
Description: Currently we are using "lu_rootcategory_name" label in Admin to list in navigation bar in Catalog.

TODO:


1. For the FRONT

We need to change the following method to use "lu_home" (label in Advanced theme) instead of the one defined in ConfigValue('Root_Name') configuration variable.

function RootCategoryName($params)
{
    $phrase_name = $this->Application->ConfigValue('Root_Name');
    $no_editing = array_key_exists('no_editing', $params) && $params['no_editing'];

    return $this->Application->Phrase($phrase_name, !$no_editing);
}


Also, add "lu_home" to all Front end language packs of ALL themes (advanced already has it)



2. For ADMIN

Change lu_rootcategory_name to la_rootcategory_name and move to Admin Language pack and get rid of the deprecated variable "Root_Name".
Steps To Reproduce:
Additional Information:
Relationships
Attached Files: patch home_category_phrase_separated_core.patch (13,725) 2010-06-15 13:10
http://tracker.in-portal.org/file_download.php?file_id=647&type=bug
patch home_category_phrase_separated_themes.patch (5,713) 2010-06-15 13:10
http://tracker.in-portal.org/file_download.php?file_id=648&type=bug
patch home_category_phrase_separated_modules.patch (2,819) 2010-06-15 13:18
http://tracker.in-portal.org/file_download.php?file_id=649&type=bug
patch home_category_phrase_separated_core_addon1.patch (817) 2010-06-15 14:56
http://tracker.in-portal.org/file_download.php?file_id=650&type=bug
Issue History
Date Modified Username Field Change
2010-07-22 15:07 alex Note Added: 0002582
2010-07-22 15:07 alex Status resolved => closed
2010-06-15 16:00 alex Note Added: 0002471
2010-06-15 16:00 alex Status reviewed and tested => resolved
2010-06-15 16:00 alex Fixed in Version => 5.1.0-RC1
2010-06-15 16:00 alex Resolution open => fixed
2010-06-15 16:00 alex Changeset attached 5.1.x r13789
2010-06-15 15:58 alex Changeset attached 5.1.x r13788
2010-06-15 15:58 alex Changeset attached 5.1.x r13787
2010-06-15 15:57 alex Changeset attached 5.1.x r13786
2010-06-15 15:56 alex Changeset attached 1.1.x r13785
2010-06-15 15:56 alex Changeset attached 1.1.x r13784
2010-06-15 15:55 alex Changeset attached 1.1.x r13783
2010-06-15 15:53 Dmitry Note Added: 0002470
2010-06-15 15:53 Dmitry Assigned To !COMMUNITY => alex
2010-06-15 15:53 Dmitry Status needs testing => reviewed and tested
2010-06-15 14:56 alex File Added: home_category_phrase_separated_core_addon1.patch
2010-06-15 13:18 alex Note Added: 0002462
2010-06-15 13:18 alex File Added: home_category_phrase_separated_modules.patch
2010-06-15 13:12 alex Note Added: 0002461
2010-06-15 13:12 alex Assigned To => !COMMUNITY
2010-06-15 13:12 alex Developer => alex
2010-06-15 13:12 alex Status active => needs testing
2010-06-15 13:10 alex File Added: home_category_phrase_separated_themes.patch
2010-06-15 13:10 alex File Added: home_category_phrase_separated_core.patch
2010-06-14 15:11 Dmitry Description Updated bug_revision_view_page.php?rev_id=523#r523
2010-06-13 23:24 Dmitry New Issue

Notes
(0002461)
alex   
2010-06-15 13:12   
Because lack of time I didn't used "lu_Home", but leaved original used phrase "lu_rootcategory_name".
(0002462)
alex   
2010-06-15 13:18   
Reminder sent to: Dmitry

Patch for modules added. Please restart testing if you already started it.
(0002470)
Dmitry   
2010-06-15 15:53   
Patch tested. Please commit.
(0002471)
alex   
2010-06-15 16:00   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000776: Change usage of "lu_rootcategory_name" Language label
(0002582)
alex   
2010-07-22 15:07   
Closing, since 5.1.0 release has been released.