In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
77 [In-Portal CMS] Optimization task always 2009-06-15 08:04 2012-07-25 05:33
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference:
Change Log Message:
Estimate Points: 1
Summary: 0000077: Remove "grid_float_range_filter" block
Description: Remove "grid_float_range_filter" block and make "kSearchHelper::getCustomFilterSearchClause" method more intellectual to add float/int filter based on current field type from unit config.

This way it will be easier for users to work with filters and not to remember field type, when they are using this filter.
Steps To Reproduce:
Additional Information: Also replace any usages of "grid_float_range_filter" block with "grid_range_filter" block and remove that "grid_float_range_filter" block definition.
Relationships
Attached Files: patch range_filter_core_77.patch (5,830) 2011-10-31 12:38
http://tracker.in-portal.org/file_download.php?file_id=1277&type=bug
patch range_filter_modules_77.patch (33,566) 2011-10-31 13:04
http://tracker.in-portal.org/file_download.php?file_id=1279&type=bug
patch range_filter_core_v2.patch (6,343) 2011-11-01 05:33
http://tracker.in-portal.org/file_download.php?file_id=1280&type=bug
patch range_filter_modules_v2.patch (34,449) 2011-11-01 05:34
http://tracker.in-portal.org/file_download.php?file_id=1281&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005066
2012-07-25 05:33 alex Status resolved => closed
2011-11-01 05:40 alex Changeset attached 5.2.x r14718
2011-11-01 05:40 alex Note Added: 0004107
2011-11-01 05:40 alex Status reviewed and tested => resolved
2011-11-01 05:40 alex Fixed in Version => 5.2.0-B1
2011-11-01 05:40 alex Resolution open => fixed
2011-11-01 05:40 alex Assigned To !COMMUNITY => alex
2011-11-01 05:39 alex Changeset attached 5.2.x r14717
2011-11-01 05:39 alex Changeset attached 5.2.x r14716
2011-11-01 05:39 alex Changeset attached 1.2.x r14715
2011-11-01 05:36 alex Note Added: 0004106
2011-11-01 05:36 alex Assigned To alex => !COMMUNITY
2011-11-01 05:36 alex Status needs testing => reviewed and tested
2011-11-01 05:34 alex File Added: range_filter_modules_v2.patch
2011-11-01 05:33 alex File Added: range_filter_core_v2.patch
2011-10-31 13:04 erik File Added: range_filter_modules_77.patch
2011-10-31 13:04 erik File Deleted: range_filter_modules_77.patch
2011-10-31 12:51 erik Time Estimate Removed 1 =>
2011-10-31 12:51 erik Note Added: 0004105
2011-10-31 12:51 erik Assigned To erik => alex
2011-10-31 12:51 erik Developer => erik
2011-10-31 12:51 erik Status needs work => needs testing
2011-10-31 12:39 erik File Added: range_filter_modules_77.patch
2011-10-31 12:38 erik File Added: range_filter_core_77.patch
2011-10-31 03:08 alex Additional Information Updated bug_revision_view_page.php?rev_id=890#r890
2011-10-22 05:25 alex Estimate Points => 1
2011-10-21 09:09 Dmitry Assigned To => erik
2011-10-21 09:09 Dmitry Status active => needs work
2011-09-27 05:07 alex Time Estimate Added 1
2011-09-23 21:58 Dmitry Target Version Icebox => 5.2.0
2009-10-06 14:27 alex Type bug report => task
2009-06-15 23:31 Dmitry Target Version => Icebox
2009-06-15 08:04 alex New Issue

Notes
(0004105)
erik   
2011-10-31 12:51   
Patches are attached - needs testing.
(0004106)
alex   
2011-11-01 05:36   
Test in most cases, but theese cases were fixed additionally:

1. module "Custom" wasn't processed (still using grid_float_range_filter block) resulting fatal error, since block was removed

2. only "float" field type was checked, but there could be also "double" and "real" field types (was used in demo grid in Custom module)
(0004107)
alex   
2011-11-01 05:40   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000077: Remove "grid_float_range_filter" block
Commit on behalf of Erik
(0005066)
alex   
2012-07-25 05:33   
Since 5.2.0 version was released.