In-Portal Issue Tracker - In-Commerce
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
766 [In-Commerce] Payment Gateways bug report always 2010-06-08 22:39 2010-07-22 15:07
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.0-B2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.0-RC1  
Reference:
Change Log Message: Fixed Incorrect paths for In-Commerce & In-Auction gateway scripts
Estimate Points: 0
Summary: 0000766: Incorrect paths for In-Commerce & In-Auction gateway scripts
Description: There have been some issue with PATHS defined within Gateway scripts of In-Commerce and In-Auction mainly due to migration of all modules under /modules folder.
Steps To Reproduce:
Additional Information:
Relationships
child of 0000362closed  (5.1.0)!COMMUNITY In-Portal CMS We should move all module folders to new "modules" subfolder 
Attached Files: patch incorrect_modules_paths_defined.patch (18,690) 2010-06-08 22:39
http://tracker.in-portal.org/file_download.php?file_id=620&type=bug
patch path_fixes_in_auction_v2.patch (3,217) 2010-06-09 04:11
http://tracker.in-portal.org/file_download.php?file_id=624&type=bug
patch path_fixes_in_commerce_v2.patch (20,054) 2010-06-09 05:02
http://tracker.in-portal.org/file_download.php?file_id=625&type=bug
Issue History
Date Modified Username Field Change
2010-07-22 15:07 alex Note Added: 0002591
2010-07-22 15:07 alex Status resolved => closed
2010-06-10 15:06 alex Fixed in Version 5.1.0-B2 => 5.1.0-RC1
2010-06-09 09:52 alex Note Added: 0002398
2010-06-09 09:52 alex Status reviewed and tested => resolved
2010-06-09 09:52 alex Fixed in Version => 5.1.0-B2
2010-06-09 09:52 alex Resolution open => fixed
2010-06-09 09:52 alex Changeset attached 5.1.x r13704
2010-06-09 09:52 alex Changeset attached 5.1.x r13703
2010-06-09 09:25 Dmitry Note Added: 0002395
2010-06-09 09:25 Dmitry Assigned To Dmitry => alex
2010-06-09 09:25 Dmitry Status needs testing => reviewed and tested
2010-06-09 05:07 alex Note Added: 0002385
2010-06-09 05:07 alex Developer Dmitry => alex
2010-06-09 05:07 alex Status needs work => needs testing
2010-06-09 05:02 alex Assigned To alex => Dmitry
2010-06-09 05:02 alex Status needs testing => needs work
2010-06-09 05:02 alex File Added: path_fixes_in_commerce_v2.patch
2010-06-09 04:12 alex Note Added: 0002384
2010-06-09 04:11 alex File Added: path_fixes_in_auction_v2.patch
2010-06-08 22:45 Dmitry Relationship added child of 0000362
2010-06-08 22:39 Dmitry Note Added: 0002379
2010-06-08 22:39 Dmitry Assigned To => alex
2010-06-08 22:39 Dmitry Developer => Dmitry
2010-06-08 22:39 Dmitry Status active => needs testing
2010-06-08 22:39 Dmitry New Issue
2010-06-08 22:39 Dmitry File Added: incorrect_modules_paths_defined.patch
2010-06-08 22:39 Dmitry Change Log Message => Fixed Incorrect paths for In-Commerce & In-Auction gateway scripts

Notes
(0002379)
Dmitry   
2010-06-08 22:39   
Please review the code

I have tested all on some live transactions
(0002384)
alex   
2010-06-09 04:12   
Patch "patch file icon path_fixes_in_auction_v2.patch" also adds REL_PATH to all files, when appropriate. Also patch to "s.gif" was broken in "hitcounter.php".
(0002385)
alex   
2010-06-09 05:07   
Patch "path_fixes_in_commerce_v2.patch" also adds REL_PATH to all files, when appropriate.

1. Also I've removed "in-commerce/add_to_cart.php" since it wasn't working or used anyway.
2. Notification scripts were calling "gw_notify.php" using incorrect path.
3. You've copied one code into all files, but they were descendants of same class and you've could placed that code in parent class. I've did that.

Please test latest 2 patches on at least these payment gateways:
1. paypal direct, paypal normal, paypal reoccuring
2. google checkout
3. atosorigin/sella
(0002395)
Dmitry   
2010-06-09 09:25   
Tested, please commit.
(0002398)
alex   
2010-06-09 09:52   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000766: Incorrect paths for In-Commerce & In-Auction gateway scripts
(0002591)
alex   
2010-07-22 15:07   
Closing, since 5.1.0 release has been released.