In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
762 [In-Portal CMS] Template System bug report always 2010-06-07 22:53 2010-06-10 13:44
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.4-B1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.0.4-B2  
Reference: http://groups.google.com/group/in-portal-bugs/browse_thread/thread/bf453002d85ee5ef
Change Log Message: Minor fix for "TemplatesBase" tag to correctly build SSL links in Admin
Estimate Points: 0
Summary: 0000762: Issues with "TemplatesBase" tag and SSL
Description: When Admin is under SSL, and as such when I try to edit a content my page is
not loaded correctly because the <inp2:m_TemplatesBase /> tag I'm using to
load the css and images is not accessing the content via SSL:

<link rel='stylesheet' type='text/css' media='all'
href="<inp2:m_TemplatesBase />inc/css/navbar.css" />

generates a non-ssl fully qualified URL when loaded inside the admin. If I
view the SSL-enabled pages on the front end, it does use https. More I look
at it, the more I think that if the admin panel is used via SSL, so should
the content management (provided the html uses tags to build urls)
Steps To Reproduce:
Additional Information: This bug has been confirmed in 5.1.0-B1
Relationships
related to 0000761closed  (5.1.0)alex Bug related to SSL in JS/CSS compress feature 
Attached Files: patch broken_lock_in_browse_mode.patch (1,066) 2010-06-08 04:24
http://tracker.in-portal.org/file_download.php?file_id=614&type=bug
png ssl_front_end_problem.png (11,344) 2010-06-08 04:24
http://tracker.in-portal.org/file_download.php?file_id=615&type=bug
png
Issue History
Date Modified Username Field Change
2010-06-10 13:44 alex Note Added: 0002399
2010-06-10 13:44 alex Status resolved => closed
2010-06-09 07:51 alex Note Added: 0002394
2010-06-09 07:51 alex Status reviewed and tested => resolved
2010-06-09 07:51 alex Fixed in Version => 5.0.4-B2
2010-06-09 07:51 alex Resolution open => fixed
2010-06-09 07:51 alex Changeset attached 5.0.x r13692
2010-06-08 21:02 Dmitry Note Added: 0002374
2010-06-08 21:02 Dmitry Assigned To !COMMUNITY => alex
2010-06-08 21:02 Dmitry Status needs testing => reviewed and tested
2010-06-08 04:28 alex Note Added: 0002372
2010-06-08 04:28 alex Assigned To => !COMMUNITY
2010-06-08 04:28 alex Developer => alex
2010-06-08 04:28 alex Status active => needs testing
2010-06-08 04:25 alex Note Added: 0002371
2010-06-08 04:24 alex File Added: ssl_front_end_problem.png
2010-06-08 04:24 alex File Added: broken_lock_in_browse_mode.patch
2010-06-08 03:29 alex Target Version 5.1.0 => 5.0.4
2010-06-08 03:18 alex version 5.1.0-B1 => 5.0.4-B1
2010-06-08 03:09 alex Relationship added related to 0000761
2010-06-07 22:53 Dmitry New Issue
2010-06-07 22:53 Dmitry Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/bf453002d85ee5ef
2010-06-07 22:53 Dmitry Change Log Message => Minor fix for "TemplatesBase" tag to correctly build SSL links in Admin

Notes
(0002371)
alex   
2010-06-08 04:25   
Following (see "ssl_front_end_problem.png") configuration setting combination cause front-end to force redirect to "http://" while administrative console is using "https://" resulting broken lock.
(0002372)
alex   
2010-06-08 04:28   
What was fixed:
1. force front-end to use same ssl mode as in administrative console, while browse modes are used:
a. shows all front-end templates in ssl (no matter if they require it), when admin uses ssl
b. shown all front-end template in non-ssl (no matter if they require it), when admin not using ssl

2. when I've tried to edit design, then I've got infinite redirect between ssl and non-ssl caused by m_CheckSSL tag, called during internal template parsing (to determine editable design position in template).
(0002374)
Dmitry   
2010-06-08 21:02   
Tested Good. Please commit.
(0002394)
alex   
2010-06-09 07:51   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000762: Issues with "TemplatesBase" tag and SSL
(0002399)
alex   
2010-06-10 13:44   
Closing since version 5.0.4 is released.