In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
746 [In-Portal CMS] Admin Interfaces task N/A 2010-05-23 11:14 2010-11-30 12:48
alex  
alex  
normal  
closed 5.0.3  
fixed  
 
none 5.1.1-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/1d11a3fc2f8773ef
0
0000746: Remove useless filters from "View Menu"
Since 5.x versions each grid column have it's own filter. Because of it "View -> View" menu became useless, since it only duplicates existing code.

I propose to remove it in all places, when necessary.
Need to search for "FilterMenu" in all "*_config.php" files to find all View menus.

We also could remove "Select" and "Sort" submenus completely (delete related code at all).
patch View-Menu-Cleanup-CORE.patch (31,554) 2010-09-10 17:05
http://tracker.in-portal.org/file_download.php?file_id=756&type=bug
patch View-Menu-Cleanup-MODULES.patch (51,345) 2010-09-10 17:06
http://tracker.in-portal.org/file_download.php?file_id=757&type=bug
Issue History
2010-11-30 12:48 Dmitry Note Added: 0003034
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-14 04:16 alex Note Added: 0002827
2010-09-14 04:16 alex Status reviewed and tested => resolved
2010-09-14 04:16 alex Fixed in Version => 5.1.1-B1
2010-09-14 04:16 alex Resolution open => fixed
2010-09-14 04:16 alex Assigned To !COMMUNITY => alex
2010-09-14 04:16 alex Changeset attached 5.1.x r13941
2010-09-14 04:15 alex Changeset attached 5.1.x r13940
2010-09-14 04:14 alex Changeset attached 5.1.x r13939
2010-09-14 04:12 alex Changeset attached 5.1.x r13938
2010-09-14 04:11 alex Changeset attached 5.1.x r13937
2010-09-14 04:10 alex Note Added: 0002826
2010-09-14 04:10 alex Assigned To alex => !COMMUNITY
2010-09-14 04:10 alex Status needs testing => reviewed and tested
2010-09-10 17:07 Dmitry Note Added: 0002807
2010-09-10 17:07 Dmitry Assigned To Dmitry => alex
2010-09-10 17:07 Dmitry Developer => Dmitry
2010-09-10 17:07 Dmitry Status needs work => needs testing
2010-09-10 17:06 Dmitry File Added: View-Menu-Cleanup-MODULES.patch
2010-09-10 17:05 Dmitry File Added: View-Menu-Cleanup-CORE.patch
2010-09-01 16:23 Dmitry Note Added: 0002762
2010-09-01 16:23 Dmitry Assigned To => Dmitry
2010-09-01 16:23 Dmitry Status active => needs work
2010-09-01 15:51 alex Additional Information Updated bug_revision_view_page.php?rev_id=556#r556
2010-09-01 03:32 alex Note Added: 0002760
2010-09-01 03:32 alex Target Version Icebox => 5.1.1
2010-09-01 03:31 alex Additional Information Updated bug_revision_view_page.php?rev_id=555#r555
2010-05-23 11:14 alex New Issue
2010-05-23 11:14 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/1d11a3fc2f8773ef

Notes
(0002760)
alex   
2010-09-01 03:32   
Removing is not adding, so it's pretty fast to do -> Moving to 5.1.1
(0002762)
Dmitry   
2010-09-01 16:23   
I'll take this task.
(0002807)
Dmitry   
2010-09-10 17:07   
Please review and test.

NOTE: some very minor code clean-up has been done in some of Unit Configs on the way.
(0002826)
alex   
2010-09-14 04:10   
Tested, however some minor issues were found and fixed by me manually:

1. discounts grid:
- filter by Status was not deleted
- filter by Type field still present in unit config, however it duplicated Type column, that was already displayed before
2. coupons grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
3. downloadable product files grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
4. listings grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
5. categories grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
6. users/admins grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
(0002827)
alex   
2010-09-14 04:16   
Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000746: Remove useless filters from "View Menu"
2. Commit on behalf of Dmitry
(0003034)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.