In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
722 [In-Portal CMS] Localization bug report always 2010-05-02 04:49 2010-11-30 12:48
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.3-RC1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.1-B1  
Reference: http://groups.google.com/group/in-portal-bugs/browse_thread/thread/c2984f191167809c
Change Log Message:
Estimate Points: 0
Summary: 0000722: Adding more defaults to language adding form
Description: The issue comes up, when web-server (e.g. Apache) default served charset is not "utf-8". Unfortunately we can't rely on this setting here and this is what is proposed to do:

1. As Default CHARSET for Languages we put utf-8 (will be pre-filled on the form)

2. Always put utf-8 in the HTML when you are adding a NEW language and "<inp2:lang_Field name="Charset"/>" is empty (on the first form load). This will help to prevent default Webserver charset to be applied when

<meta http-equiv="content-type" content="text/html; charset="/> (EMPTY).

3. Additionally for convenience of saving time I propose to set Default values for:

a. Date Format [same as date ouput]
b. Time Format: [same as time ouput]
c. Decimal Point: .
d. MOVE "Icon URL" and "Icon URL (disabled)" before "User Documentation URL" field - since these are rarely filled with values.
Steps To Reproduce:
Additional Information: Charset is missing during new language adding resulting failure to save non-english text entered on form.

For example type to type "Русский" as "Local Name" field value during language creation. This will result given required field being empty when you try to edit that language later.
Relationships
Attached Files: patch New-Language-Defaults-and-Code-Cleanup.patch (30,502) 2010-08-02 12:11
http://tracker.in-portal.org/file_download.php?file_id=695&type=bug
patch New-Language-Defaults-and-Code-Cleanup-v2.patch (31,542) 2010-08-29 18:11
http://tracker.in-portal.org/file_download.php?file_id=736&type=bug
Issue History
Date Modified Username Field Change
2010-11-30 12:48 Dmitry Note Added: 0003030
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-14 05:53 alex Changeset attached 5.1.x r13950
2010-09-14 05:53 alex Note Added: 0002833
2010-09-14 05:53 alex Status reviewed and tested => resolved
2010-09-14 05:53 alex Fixed in Version => 5.1.1-B1
2010-09-14 05:53 alex Resolution open => fixed
2010-09-14 05:53 alex Assigned To !COMMUNITY => alex
2010-09-14 05:50 alex Note Added: 0002832
2010-09-14 05:50 alex Assigned To alex => !COMMUNITY
2010-09-14 05:50 alex Status needs testing => reviewed and tested
2010-08-29 18:12 Dmitry Note Added: 0002748
2010-08-29 18:12 Dmitry Assigned To Dmitry => alex
2010-08-29 18:12 Dmitry Status needs work => needs testing
2010-08-29 18:11 Dmitry File Added: New-Language-Defaults-and-Code-Cleanup-v2.patch
2010-08-29 07:18 alex Note Added: 0002744
2010-08-29 07:18 alex Assigned To alex => Dmitry
2010-08-29 07:18 alex Status needs testing => needs work
2010-08-02 12:11 Dmitry Note Added: 0002646
2010-08-02 12:11 Dmitry Assigned To Dmitry => alex
2010-08-02 12:11 Dmitry Developer => Dmitry
2010-08-02 12:11 Dmitry Status needs work => needs testing
2010-08-02 12:11 Dmitry File Added: New-Language-Defaults-and-Code-Cleanup.patch
2010-07-31 13:58 Dmitry Assigned To => Dmitry
2010-07-31 13:58 Dmitry Status active => needs work
2010-07-31 13:58 Dmitry Target Version Icebox => 5.1.1
2010-05-02 04:49 alex New Issue
2010-05-02 04:49 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/c2984f191167809c

Notes
(0002646)
Dmitry   
2010-08-02 12:11   
Please test.
(0002744)
alex   
2010-08-29 07:18   
1. Don't place any dynamic code in unit config file (e.g. "date" function call); also we use adodb for all date/time-related calls

2. Don't change block comments to add extra new lines, e.g. "/*$test" should not be replaced by "/*
$test"
(0002748)
Dmitry   
2010-08-29 18:12   
Updated based on posted comments.

Please review again and commit if successful.
(0002832)
alex   
2010-09-14 05:50   
Where problems during patch applying. Fixed on the way.

Also I've replaced back date formats from "d.m.Y" to "dd.mm.yyyy" as they were before, since it's more native to non-programmers.
(0002833)
alex   
2010-09-14 05:53   
Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000722: Adding more defaults to language adding form
2. Commit on behalf of Dmitry
(0003030)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.