In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
721 [In-Portal CMS] Admin Interfaces bug report always 2010-05-01 13:24 2010-05-11 02:59
alex  
alex  
normal  
closed 5.0.3-RC1  
fixed  
 
none 5.0.3  
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/7c1945ce50a2f492
0
0000721: Prev/Next buttons are always enabled
On 5.0.3-B2 release Prev/Next buttons are always enabled, even, when there is not prev. button available.

How to reproduce:

    * select 2 sections in structure & data
    * click edit button
    * now you see 1st selected section -> click next
    * now you see 2nd selected section -> click next
    * now you see broken page without any section


This is all because of fix, that disabled toolbar buttons until page is fully loaded and then enabled them.

There are two ways to fix this:

   1. call prev/next buttton js via $(document).ready event
   2. don't disable toolbar buttons until page is fully loaded, but just make them readonly (new state, that will act like disabled, but button won't be grayed out)

That new "ReadOnly" status will be for internal use only.
This is button code sample:
<inp2:m_if check="poll_IsSingle">
    a_toolbar.HideButton('prev');
    a_toolbar.HideButton('next');
    a_toolbar.HideButton('sep1');
<inp2:m_else/>
    <inp2:m_if check="poll_IsLast">
        a_toolbar.DisableButton('next');
    </inp2:m_if>
    <inp2:m_if check="poll_IsFirst">
        a_toolbar.DisableButton('prev');
    </inp2:m_if>
</inp2:m_if>
related to 0000594closed  (5.0.3)alex Quick "Modal Window" opening leads to js error 
patch prev_next_fix.patch (2,111) 2010-05-01 17:37
http://tracker.in-portal.org/file_download.php?file_id=512&type=bug
Issue History
2010-05-11 02:59 alex Note Added: 0002080
2010-05-11 02:59 alex Status resolved => closed
2010-05-02 04:42 alex Note Added: 0002041
2010-05-02 04:42 alex Status reviewed and tested => resolved
2010-05-02 04:42 alex Fixed in Version => 5.0.3
2010-05-02 04:42 alex Resolution open => fixed
2010-05-02 04:42 alex Changeset attached 5.0.x r13475
2010-05-01 20:32 Dmitry Note Added: 0002038
2010-05-01 20:32 Dmitry Assigned To !COMMUNITY => alex
2010-05-01 20:32 Dmitry Status needs testing => reviewed and tested
2010-05-01 17:37 alex Assigned To => !COMMUNITY
2010-05-01 17:37 alex Developer => alex
2010-05-01 17:37 alex Status active => needs testing
2010-05-01 17:37 alex File Added: prev_next_fix.patch
2010-05-01 13:36 alex Relationship added related to 0000594
2010-05-01 13:24 alex New Issue
2010-05-01 13:24 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/7c1945ce50a2f492

Notes
(0002038)
Dmitry   
2010-05-01 20:32   
Reviewed and tested good on 5.0.3-RC1.

Please commit.
(0002041)
alex   
2010-05-02 04:42   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000721: Prev/Next buttons are always enabled
(0002080)
alex   
2010-05-11 02:59   
Closing all tasks from released versions.