In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
709 [In-Portal CMS] Data Management task N/A 2010-04-25 13:00 2012-07-25 05:33
alex  
alex  
normal  
closed 5.0.3-B2  
fixed  
 
none 5.2.0-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/cb3ca3167a129dff
1
0000709: Make "kUploadFormatter::_ensureUniqueFilename" more accessible
I propose to move "kUploadFormatter::_ensureUniqueFilename" to "FileHelper::ensureUniqueFilename", because it could be very useful, when we need to ensure, that filename is unique in given directory.
patch unique_filename_709.patch (7,541) 2011-10-17 12:40
http://tracker.in-portal.org/file_download.php?file_id=1253&type=bug
patch unique_filename_refactoring_v2.patch (8,633) 2011-10-19 04:28
http://tracker.in-portal.org/file_download.php?file_id=1261&type=bug
Issue History
2012-07-25 05:33 alex Note Added: 0005121
2012-07-25 05:33 alex Status resolved => closed
2011-10-22 05:25 alex Estimate Points => 1
2011-10-19 04:31 alex Changeset attached 5.2.x r14681
2011-10-19 04:31 alex Note Added: 0004078
2011-10-19 04:31 alex Status reviewed and tested => resolved
2011-10-19 04:31 alex Fixed in Version => 5.2.0-B1
2011-10-19 04:31 alex Resolution open => fixed
2011-10-19 04:31 alex Assigned To !COMMUNITY => alex
2011-10-19 04:30 alex Note Added: 0004077
2011-10-19 04:30 alex Assigned To alex => !COMMUNITY
2011-10-19 04:30 alex Status needs testing => reviewed and tested
2011-10-19 04:28 alex File Added: unique_filename_refactoring_v2.patch
2011-10-17 12:40 erik Time Estimate Removed 1 =>
2011-10-17 12:40 erik Note Added: 0004066
2011-10-17 12:40 erik Assigned To erik => alex
2011-10-17 12:40 erik Developer => erik
2011-10-17 12:40 erik Status needs work => needs testing
2011-10-17 12:40 erik File Added: unique_filename_709.patch
2011-10-14 02:40 alex Assigned To => erik
2011-10-14 02:40 alex Status active => needs work
2011-09-27 06:22 alex Time Estimate Added 1
2011-09-23 21:50 Dmitry Target Version Icebox => 5.2.0
2010-04-25 13:00 alex New Issue
2010-04-25 13:00 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/cb3ca3167a129dff

Notes
(0004066)
erik   
2011-10-17 12:40   
patch attached - needs testing
(0004077)
alex   
2011-10-19 04:30   
Works generally, however few things were fixed:

1. there was no need to do a recallObject of FileHelper class in kUploadFormatter class, since it was already available via $this->fileHelper class attribute declared & used in same file already.

2. method comments in FileHelper class adjusted to match "public" scope operator that you've added.
(0004078)
alex   
2011-10-19 04:31   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000709: Make "kUploadFormatter::_ensureUniqueFilename" more accessible
Commit on behalf of Erik
(0005121)
alex   
2012-07-25 05:33   
Since 5.2.0 version was released.