In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
701 [In-Portal CMS] Data Management bug report always 2010-04-16 17:49 2010-11-30 12:48
Dmitry  
alex  
normal  
closed 5.1.0  
fixed  
 
none 5.1.1-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/8195138be50c2e85/f495aa3fbf42c0a4
0
0000701: Add "Run Now" toolbar button to Agents grid
Add "Run Now" button on toolbar in Agents section. It will run selected agents immediately, but only, when they are not already running. Simply passing agent event in url won't guarantee parallel execution protection.
patch run_agent_button.patch (9,741) 2010-09-11 14:17
http://tracker.in-portal.org/file_download.php?file_id=759&type=bug
patch run_agent_button_v2.patch (9,442) 2010-09-12 05:06
http://tracker.in-portal.org/file_download.php?file_id=760&type=bug
patch run_agent_button_modules.patch (566) 2010-09-12 05:07
http://tracker.in-portal.org/file_download.php?file_id=761&type=bug
Issue History
2010-11-30 12:48 Dmitry Note Added: 0003037
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-12 11:40 alex Note Added: 0002817
2010-09-12 11:40 alex Status reviewed and tested => resolved
2010-09-12 11:40 alex Fixed in Version => 5.1.1-B1
2010-09-12 11:40 alex Resolution open => fixed
2010-09-12 11:40 alex Changeset attached 5.1.x r13934
2010-09-12 11:39 alex Changeset attached 5.1.x r13933
2010-09-12 11:28 Dmitry Note Added: 0002816
2010-09-12 11:28 Dmitry Assigned To !COMMUNITY => alex
2010-09-12 11:28 Dmitry Status needs testing => reviewed and tested
2010-09-12 05:08 alex Note Added: 0002813
2010-09-12 05:08 alex Assigned To alex => !COMMUNITY
2010-09-12 05:08 alex Status needs work => needs testing
2010-09-12 05:07 alex File Added: run_agent_button_modules.patch
2010-09-12 05:06 alex File Added: run_agent_button_v2.patch
2010-09-11 22:13 Dmitry Status reviewed and tested => needs work
2010-09-11 22:13 Dmitry Note Added: 0002812
2010-09-11 22:13 Dmitry Assigned To !COMMUNITY => alex
2010-09-11 22:13 Dmitry Status needs testing => reviewed and tested
2010-09-11 14:17 alex Time Estimate Removed 3 =>
2010-09-11 14:17 alex Assigned To alex => !COMMUNITY
2010-09-11 14:17 alex Developer => alex
2010-09-11 14:17 alex Status needs work => needs testing
2010-09-11 14:17 alex File Added: run_agent_button.patch
2010-08-31 14:11 alex version => 5.1.0
2010-08-27 13:12 alex Time Estimate Added 3
2010-07-31 14:06 Dmitry Assigned To => alex
2010-07-31 14:06 Dmitry Status active => needs work
2010-07-31 14:06 Dmitry Target Version Icebox => 5.1.1
2010-04-17 04:50 alex Target Version 5.1.0 => Icebox
2010-04-16 17:49 Dmitry New Issue
2010-04-16 17:49 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/8195138be50c2e85/f495aa3fbf42c0a4

Notes
(0002812)
Dmitry   
2010-09-11 22:13   
Some issues seems to be found.

In runAgent method the following code:

if ($next_run && ($next_run > adodb_mktime())) {
   return false;
}

prevents the system from starting ANY agents manually (new button) that scheduled to run in the future which won't work for us. User should be able to start ANY event (that is not running already) at any given time.

Back to you for review.
(0002813)
alex   
2010-09-12 05:08   
Patch "run_agent_button_modules.patch" contains fix for "listing_payments" agent, that failed to run because of Fatal Error.
(0002816)
Dmitry   
2010-09-12 11:28   
Tested both patches good, please commit!
(0002817)
alex   
2010-09-12 11:40   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000701: Add "Run Now" toolbar button to Agents grid
(0003037)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.