In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
698 [In-Portal CMS] Refactoring task always 2010-04-16 14:17 2012-07-25 05:31
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B3  
Reference: http://groups.google.com/group/in-portal-dev/browse_thread/thread/deaafa625ff7c376 https://groups.google.com/d/topic/in-portal-dev/V08YrUJfsYM/discussion
Change Log Message:
Estimate Points: 1
Summary: 0000698: Refactor all module Toolbar Buttons by Merge into one PNG file
Description: We can merge all 135 "tool_*.gif" files of Core module into singe
file. We could do the same for all other modules as well, so we end up with
1 file per module, that will contain all toolbar images.

This approach allows to save page load time. Also we will add css classes,
that will contain position of each toolbar button in the file.

Toolbar buttons will be located in file like this:
[Add Button Enabled] [Add Button Hover] [Add Button Disabled]
[Modify Button Enabled] [Modify Button Hover] [Modify Button Disabled]
Steps To Reproduce:
Additional Information: 3 Tips for making CSS sprites in Photoshop:

http://www.thebrightlines.com/2009/11/05/3-tips-for-making-css-sprites-in-photoshop/
Relationships
parent of 0001262closed  (5.2.0)alex Broken Toolbar buttons 
Attached Files: ? to_sprite.php (4,798) 2012-04-09 09:57
http://tracker.in-portal.org/file_download.php?file_id=1611&type=bug
rar core-toolbar-sprite.rar (95,022) 2012-04-09 09:57
http://tracker.in-portal.org/file_download.php?file_id=1612&type=bug
patch admin_toolbar_via_sprites.patch (8,818) 2012-04-10 07:57
http://tracker.in-portal.org/file_download.php?file_id=1613&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:31 alex Note Added: 0004929
2012-07-25 05:31 alex Status resolved => closed
2012-04-20 07:41 alex Relationship added parent of 0001262
2012-04-10 08:00 alex Note Added: 0004576
2012-04-10 08:00 alex Status reviewed and tested => resolved
2012-04-10 08:00 alex Fixed in Version => 5.2.0-B3
2012-04-10 08:00 alex Resolution open => fixed
2012-04-10 08:00 alex Assigned To !COMMUNITY => alex
2012-04-10 08:00 alex Changeset attached 5.2.x r15284
2012-04-10 07:59 alex Changeset attached 5.2.x r15283
2012-04-10 07:59 alex Changeset attached 5.2.x r15282
2012-04-10 07:59 alex Changeset attached 5.2.x r15281
2012-04-10 07:58 alex Changeset attached 5.2.x r15280
2012-04-10 07:58 alex Changeset attached 5.2.x r15279
2012-04-10 07:57 alex Estimate Points 0 => 1
2012-04-10 07:57 alex Note Added: 0004575
2012-04-10 07:57 alex Status needs testing => reviewed and tested
2012-04-10 07:57 alex Assigned To alex => !COMMUNITY
2012-04-10 07:57 alex Developer => alex
2012-04-10 07:57 alex Status needs work => needs testing
2012-04-10 07:57 alex File Added: admin_toolbar_via_sprites.patch
2012-04-09 13:28 Dmitry Assigned To => alex
2012-04-09 13:28 Dmitry Status active => needs work
2012-04-09 13:28 Dmitry Target Version Icebox => 5.2.0
2012-04-09 13:08 Dmitry Additional Information Updated bug_revision_view_page.php?rev_id=1003#r1003
2012-04-09 09:58 Dmitry Note Added: 0004574
2012-04-09 09:57 Dmitry File Added: core-toolbar-sprite.rar
2012-04-09 09:57 Dmitry File Added: to_sprite.php
2012-04-08 21:50 Dmitry Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/deaafa625ff7c376 => http://groups.google.com/group/in-portal-dev/browse_thread/thread/deaafa625ff7c376 https://groups.google.com/d/topic/in-portal-dev/V08YrUJfsYM/discussion
2012-04-08 21:50 Dmitry Estimate Points => 0
2010-09-28 14:15 administrator Category Optimization => Refactoring
2010-08-31 14:12 alex version => 5.1.0
2010-07-31 14:04 Dmitry Type bug report => task
2010-07-31 14:04 Dmitry Category Admin Interfaces => Optimization
2010-04-18 12:05 Dmitry Target Version 5.1.0 => Icebox
2010-04-16 14:17 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/deaafa625ff7c376
2010-04-16 14:17 Dmitry New Issue

Notes
(0004574)
Dmitry   
2012-04-09 09:58   
Uploaded files on behalf of Alex.

We already discussed a way to convert all toolbar images into sprites and I even write a script that:

- takes all given module toolbar icon images (normal, hover, disabled)
- removes duplicates
- combines them into a single PNG file
- creates CSS file that has selectors named as original toolbar images were named
- creates HTML file to show every button in a sprite (for verification purposes only)

I've attached script and it's result.
(0004575)
alex   
2012-04-10 07:57   
Will test all together later.
(0004576)
alex   
2012-04-10 08:00   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000698: Refactor all module Toolbar Buttons by Merge into one PNG file
(0004929)
alex   
2012-07-25 05:31   
Since 5.2.0 version was released.