In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
695 [In-Portal CMS] Optimization bug report always 2010-04-13 10:43 2010-11-30 12:48
Dmitry  
alex  
normal  
closed 5.0.3-B2  
fixed  
 
none 5.1.1-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/1565976435f1f2ab
0
0000695: Remove endless "!" inside admin templates
In earlier template parser versions, used in In-Portal we had problems
distinguishing simple text and labels, that should be translated. At that
times we invented ability to escape text with "!" in form "!label_here!" so
it will be translated.

For quite some time this is no longer a problem and that ! in admin template
actually do nothing and are stripped at the end. Example code:
*<inp2:m_RenderElement name="inp_edit_options" prefix="formflds"
field="ElementType" title="!la_prompt_InputType!"/>*

As you can notice title parameter value displays the problem I've described.
We will remove all such occurrences of "!" in one release and will remove
code, that strips ! in next version, so all users will be forced to to
change their code as well.
patch Remove-ExplainationMarks-from-Phrases-Core.patch (84,977) 2010-08-29 18:51
http://tracker.in-portal.org/file_download.php?file_id=737&type=bug
patch Remove-ExplainationMarks-from-Phrases-Modules.patch (229,284) 2010-08-29 18:51
http://tracker.in-portal.org/file_download.php?file_id=738&type=bug
Issue History
2010-11-30 12:48 Dmitry Note Added: 0003031
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-14 04:58 alex Note Added: 0002831
2010-09-14 04:58 alex Status reviewed and tested => resolved
2010-09-14 04:58 alex Fixed in Version => 5.1.1-B1
2010-09-14 04:58 alex Resolution open => fixed
2010-09-14 04:58 alex Assigned To !COMMUNITY => alex
2010-09-14 04:58 alex Changeset attached 5.1.x r13949
2010-09-14 04:57 alex Changeset attached 5.1.x r13948
2010-09-14 04:57 alex Changeset attached 5.1.x r13947
2010-09-14 04:56 alex Changeset attached 5.1.x r13946
2010-09-14 04:56 alex Changeset attached 5.1.x r13945
2010-09-14 04:55 alex Changeset attached 5.1.x r13944
2010-09-14 04:53 alex Changeset attached 1.1.x r13943
2010-09-14 04:53 alex Note Added: 0002830
2010-09-14 04:53 alex Assigned To alex => !COMMUNITY
2010-09-14 04:53 alex Status needs testing => reviewed and tested
2010-08-29 19:03 Dmitry Note Edited: 0002749 bug_revision_view_page.php?bugnote_id=0002749#r553
2010-08-29 18:53 Dmitry Time Estimate Removed 3 =>
2010-08-29 18:53 Dmitry Note Added: 0002749
2010-08-29 18:53 Dmitry Assigned To Dmitry => alex
2010-08-29 18:53 Dmitry Developer => Dmitry
2010-08-29 18:53 Dmitry Status needs work => needs testing
2010-08-29 18:51 Dmitry File Added: Remove-ExplainationMarks-from-Phrases-Modules.patch
2010-08-29 18:51 Dmitry File Added: Remove-ExplainationMarks-from-Phrases-Core.patch
2010-08-27 13:14 Dmitry Time Estimate Added 3
2010-07-31 13:35 Dmitry Assigned To => Dmitry
2010-07-31 13:35 Dmitry Status active => needs work
2010-07-31 13:35 Dmitry Target Version Icebox => 5.1.1
2010-05-10 14:50 alex Target Version 5.0.4 => Icebox
2010-04-13 10:43 Dmitry New Issue
2010-04-13 10:43 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/1565976435f1f2ab

Notes
(0002749)
Dmitry   
2010-08-29 18:53   
(edited on: 2010-08-29 19:03)
Please review and commit if works as expected.

NOTE: need to remove the code below from "phrases_cache.php" (line 264) in the next release:

// cut exclamation marks - depricated form of passing phrase name from templates
$label = preg_replace('/^!(.*)!$/', '\\1', $label);


To find and replace all !la_! used - REGEX "!la_(.*)!" and replace with "la_$1"

(0002830)
alex   
2010-09-14 04:53   
ok
(0002831)
alex   
2010-09-14 04:58   
Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
(0003031)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.