In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
667 [In-Portal CMS] Data Management bug report always 2010-03-27 17:52 2010-06-10 13:44
alex  
alex  
normal  
closed 5.0.3-B1  
fixed  
 
none 5.0.4-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/78a99ec279bd9f1e
0
0000667: Phrase labels are not validated leading to errors
We should add restriction to "Labels" so ONLY "alpha-number" symbols can be used. In some case I saw users putting "spaces" and other non-latin letters which actually messes up during the Import. Also validate, that phrase starts with "lu_" or "la_".

I propose we tell admin (during phrase adding/editing), what other phrases in language pack have same translation as it's phrase. In most cases duplicate translation will mean nothing, but sometimes it will help to prevent duplicate translations. Validate by CRC32 of translation.
patch phrase_validation.patch (883) 2010-05-19 08:51
http://tracker.in-portal.org/file_download.php?file_id=570&type=bug
Issue History
2010-06-10 13:44 alex Note Added: 0002412
2010-06-10 13:44 alex Status resolved => closed
2010-05-19 12:52 alex Note Added: 0002263
2010-05-19 12:52 alex Status reviewed and tested => resolved
2010-05-19 12:52 alex Fixed in Version => 5.0.4-B1
2010-05-19 12:52 alex Resolution open => fixed
2010-05-19 12:52 alex Assigned To !COMMUNITY => alex
2010-05-19 12:52 alex Changeset attached 5.0.x r13591
2010-05-19 11:58 Dmitry Note Added: 0002255
2010-05-19 11:58 Dmitry Status needs testing => reviewed and tested
2010-05-19 08:53 alex Note Added: 0002254
2010-05-19 08:53 alex Assigned To => !COMMUNITY
2010-05-19 08:53 alex Developer => alex
2010-05-19 08:53 alex Status active => needs testing
2010-05-19 08:51 alex File Added: phrase_validation.patch
2010-05-19 08:35 alex Description Updated bug_revision_view_page.php?rev_id=488#r488
2010-03-27 17:52 alex New Issue
2010-03-27 17:52 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/78a99ec279bd9f1e

Notes
(0002254)
alex   
2010-05-19 08:53   
I didn't implemented 2nd task part about phrase suggestion, since I don't know how to do it in not annoying way.

For example we have phrases "la_col_Id" and "la_fld_Id" which have same translation (mostly all column and field phrases have same translations) and I don't want to see warning every time I edit that phrase.
(0002255)
Dmitry   
2010-05-19 11:58   
Tested good. Let's commit and resolve this task for now.
(0002263)
alex   
2010-05-19 12:52   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000667: Phrase labels are not validated leading to errors
(0002412)
alex   
2010-06-10 13:44   
Closing since version 5.0.4 is released.