|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
662 |
[In-Portal CMS] Data Management |
bug report |
always |
2010-03-27 17:28 |
2010-07-22 15:03 |
|
|
Reporter:
|
BaSSiST |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.0.3-B1 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.1.0-B2 |
|
|
Reference:
|
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/20695723e4de34bd |
|
Change Log Message:
|
|
|
Estimate Points:
|
0 |
|
|
Summary:
|
0000662: Filenames of uploaded files are not escaped, when used in url |
|
Description:
|
Try to upload file with symbols such as "#" or "+" in file name via
our standard SWF uploader. You'll see that when full url is built,
it's incorrect because file name is not urlencoded. Also this is
applicable to folder names in URL - for example, in URL
http://www.sitename.com/system/part1/part2/filename.ext part1, part2 &
filename.ext (& system?) need to be urlencoded. Another case is non-
formatter URL building to uploaded files, I found one in OnViewFile
event. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | | related to | 0000456 | closed (5.1.0) | alex | Major Flash Uploader Redesign |
|
|
Attached Files:
|
 escaping_filenames_in_url.patch (9,692) 2010-06-01 04:14
http://tracker.in-portal.org/file_download.php?file_id=610&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2010-07-22 15:03 |
alex |
Note Added: 0002509 |
|
|
2010-07-22 15:03 |
alex |
Status |
resolved => closed |
|
2010-07-11 08:47 |
alex |
Issue End Monitor: alex |
|
|
2010-06-01 04:22 |
alex |
Issue Monitored: Dmitry |
|
|
2010-06-01 04:22 |
alex |
Note Added: 0002366 |
|
|
2010-06-01 04:15 |
alex |
Note Added: 0002365 |
|
|
2010-06-01 04:15 |
alex |
Status |
reviewed and tested => resolved |
|
2010-06-01 04:15 |
alex |
Fixed in Version |
=> 5.1.0-B2 |
|
2010-06-01 04:15 |
alex |
Resolution |
open => fixed |
|
2010-06-01 04:15 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2010-06-01 04:15 |
alex |
Changeset attached |
5.1.x r13667 |
|
2010-06-01 04:15 |
alex |
Note Added: 0002364 |
|
|
2010-06-01 04:15 |
alex |
Status |
needs testing => reviewed and tested |
|
2010-06-01 04:14 |
alex |
Assigned To |
=> !COMMUNITY |
|
2010-06-01 04:14 |
alex |
Developer |
=> alex |
|
2010-06-01 04:14 |
alex |
Status |
active => needs testing |
|
2010-06-01 04:14 |
alex |
File Added: escaping_filenames_in_url.patch |
|
|
2010-06-01 01:41 |
alex |
Target Version |
Icebox => 5.1.0 |
|
2010-05-31 22:30 |
Dmitry |
Issue Monitored: alex |
|
|
2010-05-31 22:30 |
Dmitry |
Note Added: 0002353 |
|
|
2010-05-30 09:46 |
alex |
Relationship added |
related to 0000456 |
|
2010-05-10 14:50 |
alex |
Target Version |
5.0.4 => Icebox |
|
2010-03-27 17:29 |
alex |
Reporter |
alex => BaSSiST |
|
2010-03-27 17:28 |
alex |
New Issue |
|
|
2010-03-27 17:28 |
alex |
Reference |
=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/20695723e4de34bd |
|
Notes |
|
|
(0002353)
|
|
Dmitry
|
|
2010-05-31 22:30
|
|
|
Reminder sent to: alex
I propose to move this to 5.1.0 along with other Flash Uploader tasks.
Please complete task and commit into 5.1.0.
|
|
|
|
(0002364)
|
|
alex
|
|
2010-06-01 04:15
|
|
|
Dmitry allowed me to commit this without testing. Testing will be performed as part if 5.1.0-B2 testing. |
|
|
|
(0002365)
|
|
alex
|
|
2010-06-01 04:15
|
|
Fix committed to 5.1.x branch. Commit Message:
Fixes 0000662: Filenames of uploaded files are not escaped, when used in url |
|
|
|
(0002366)
|
|
alex
|
|
2010-06-01 04:22
|
|
|
Reminder sent to: Dmitry
Please test. You can use "Копия horseback_ridding1 ! ' (aa) # to be.JPG" filename for tests, since it contains all (at least I think so) problematic symbols and non-latin chars too. |
|
|
|
(0002509)
|
|
alex
|
|
2010-07-22 15:03
|
|
|
Closing, since 5.1.0 release has been released. |
|