In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
645 [In-Portal CMS] Permissions feature request always 2010-03-26 10:41 2012-07-25 05:33
Dmitry  
alex  
normal  
closed 5.1.0  
fixed  
 
none 5.2.0-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/375394a2d516c850
2
0000645: User / Group Access restriction by IP
Propose to add "IP access" field to both user and group editing screens (user can change it's value on front-end). This will work as follow:

1. when user tries to login using IP address that doesn't match provided, then login will fail

2. when user/admin will successfully login, but it's IP address doesn't match all/some defined in it's groups, then all will work, like user was never added to that group.

NOTES:

a. Of course we can enter networks and other stuff, like in DBG_IP setting in debug.php

b. we need to have ability to overwrite the access check when DBG is enabled
parent of 0001385resolved  (5.2.1)alex Wrong grid filter for user's IP address 
related to 0001201closed  (5.2.0)alex Fatal error during Installation on States import with MySQL in Strict Mode 
patch ip_addr_check_user_group_feat.patch (20,395) 2011-10-04 06:53
http://tracker.in-portal.org/file_download.php?file_id=1199&type=bug
patch ip_addr_check_user_group_feat_v2.patch (20,548) 2011-10-04 06:57
http://tracker.in-portal.org/file_download.php?file_id=1200&type=bug
patch ip_addr_check_user_group_usertype_fix.patch (4,087) 2011-10-04 09:22
http://tracker.in-portal.org/file_download.php?file_id=1202&type=bug
patch ip_address_login_restrition_broken_install_data_fix.patch (1,193) 2011-10-06 05:40
http://tracker.in-portal.org/file_download.php?file_id=1220&type=bug
Issue History
2012-09-02 10:31 alex Relationship added parent of 0001385
2012-07-25 05:33 alex Note Added: 0005110
2012-07-25 05:33 alex Status resolved => closed
2012-02-06 04:03 alex Relationship added related to 0001201
2011-10-22 05:30 alex Estimate Points => 2
2011-10-06 05:41 alex Changeset attached 5.2.x r14643
2011-10-06 05:40 alex Note Added: 0004030
2011-10-06 05:40 alex File Added: ip_address_login_restrition_broken_install_data_fix.patch
2011-10-04 09:23 alex Changeset attached 5.2.x r14631
2011-10-04 09:23 alex Note Added: 0004002
2011-10-04 09:22 alex File Added: ip_addr_check_user_group_usertype_fix.patch
2011-10-04 06:59 alex Note Added: 0004000
2011-10-04 06:59 alex Status reviewed and tested => resolved
2011-10-04 06:59 alex Fixed in Version => 5.2.0-B1
2011-10-04 06:59 alex Resolution open => fixed
2011-10-04 06:59 alex Assigned To !COMMUNITY => alex
2011-10-04 06:59 alex Changeset attached 5.2.x r14630
2011-10-04 06:59 alex Note Added: 0003999
2011-10-04 06:59 alex Status needs testing => reviewed and tested
2011-10-04 06:59 alex Time Estimate Removed 2 =>
2011-10-04 06:59 alex Note Added: 0003998
2011-10-04 06:59 alex Assigned To => !COMMUNITY
2011-10-04 06:59 alex Developer => alex
2011-10-04 06:59 alex Status active => needs testing
2011-10-04 06:57 alex File Added: ip_addr_check_user_group_feat_v2.patch
2011-10-04 06:53 alex File Added: ip_addr_check_user_group_feat.patch
2011-09-27 06:25 alex Time Estimate Added 2
2011-09-23 21:43 Dmitry Target Version Icebox => 5.2.0
2010-08-31 14:18 alex version => 5.1.0
2010-03-26 14:37 alex Target Version => Icebox
2010-03-26 10:44 Dmitry Type bug report => feature request
2010-03-26 10:41 Dmitry New Issue
2010-03-26 10:41 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/375394a2d516c850

Notes
(0003998)
alex   
2011-10-04 06:59   
Patch "..._v2.patch" adds ability to skip IP checks in debug mode.

Also done:
1. IP address is always recorded on user registration (was only recorded for cases, when user subscribed to newsletter)
2. IP address is shown in user list and on user editing form (hidden as before in "simple" interface preset)
(0003999)
alex   
2011-10-04 06:59   
Will test all together.
(0004000)
alex   
2011-10-04 06:59   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000645: User / Group Access restriction by IP
(0004002)
alex   
2011-10-04 09:23   
Patch "ip_addr_check_user_group_usertype_fix.patch" solves problem, when IP restrictions set to Member/admin groups (from config settings) had no effect, since they were added back to user groups based on UserType column.
(0004030)
alex   
2011-10-06 05:40   
Patch "ip_address_login_restrition_broken_install_data_fix.patch" fixes problem with clean install.
(0005110)
alex   
2012-07-25 05:33   
Since 5.2.0 version was released.