In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
599 [In-Portal CMS] Other bug report always 2010-03-13 06:02 2010-06-10 13:44
alex  
alex  
normal  
closed 5.0.2  
fixed  
 
none 5.0.4-B1  
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/56a1c759f9625416
0
0000599: Revise error types (warning or notice) raised by system
We are currently reporting around 100 custom error messages, that will help developers to take care of possible problems before they happen. We should set proper error message type for each of them using following logic:

    * notice - information stuff, should be fixed, but not top priority and doesn't affect system's stability
    * warning - possible cause for larger problem, must be fixed before project is shown to client
    * fatal - critical, application failure and must not exist at all at any of development stages
patch trigger_error_fixes_core.patch (10,996) 2010-03-13 06:02
http://tracker.in-portal.org/file_download.php?file_id=347&type=bug
patch trigger_error_fixes_modules.patch (1,406) 2010-03-13 06:02
http://tracker.in-portal.org/file_download.php?file_id=348&type=bug
patch trigger_error_fixes_core_for_503.patch (9,993) 2010-04-06 03:55
http://tracker.in-portal.org/file_download.php?file_id=438&type=bug
patch trigger_error_fixes_core_for_510_addon.patch (1,384) 2010-04-06 03:55
http://tracker.in-portal.org/file_download.php?file_id=439&type=bug
Issue History
2010-06-10 13:44 alex Note Added: 0002432
2010-06-10 13:44 alex Status resolved => closed
2010-05-11 03:38 alex Note Added: 0002180
2010-05-11 03:38 alex Status reviewed and tested => resolved
2010-05-11 03:38 alex Fixed in Version => 5.0.4-B1
2010-05-11 03:38 alex Resolution open => fixed
2010-05-11 03:38 alex Assigned To !COMMUNITY => alex
2010-05-11 03:38 alex Changeset attached 5.0.x r13528
2010-05-11 03:33 alex Issue Monitored: alex
2010-05-11 03:33 alex Changeset attached 5.0.x r13527
2010-05-11 03:33 alex Changeset attached 5.0.x r13526
2010-04-09 00:57 Dmitry Note Added: 0001837
2010-04-09 00:57 Dmitry Status needs testing => reviewed and tested
2010-04-06 03:59 alex Note Added: 0001813
2010-04-06 03:59 alex Assigned To alex => !COMMUNITY
2010-04-06 03:59 alex Status needs work => needs testing
2010-04-06 03:55 alex File Added: trigger_error_fixes_core_for_510_addon.patch
2010-04-06 03:55 alex File Added: trigger_error_fixes_core_for_503.patch
2010-04-04 23:18 Dmitry Note Added: 0001792
2010-04-04 23:18 Dmitry Assigned To !COMMUNITY => alex
2010-04-04 23:18 Dmitry Status needs testing => needs work
2010-03-13 06:02 alex Assigned To => !COMMUNITY
2010-03-13 06:02 alex Developer => alex
2010-03-13 06:02 alex Status active => needs testing
2010-03-13 06:02 alex Target Version => 5.0.4
2010-03-13 06:02 alex File Added: trigger_error_fixes_modules.patch
2010-03-13 06:02 alex New Issue
2010-03-13 06:02 alex File Added: trigger_error_fixes_core.patch
2010-03-13 06:02 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/56a1c759f9625416

Notes
(0001792)
Dmitry   
2010-04-04 23:18   
Patches can NOT be applied as is to In-Portal 5.0.x (5.0.3-B1)

1. In "trigger_error_fixes_core.patch" some Unmatched code in:
- kernel/application.php
- kernel/nparser/nparser.php
(0001813)
alex   
2010-04-06 03:59   
Please use "trigger_error_fixes_core_for_503.patch" patch instead of "trigger_error_fixes_core.patch" patch for testing on 5.0.3 release.

Patch "trigger_error_fixes_core.patch" was created for 5.1.0 release and files "nparser.php" and "application.php" really doesn't contain source code for patching in 5.0.3 release. Because of that I've also created "trigger_error_fixes_core_for_510_addon.patch" to be applied on 5.1.0 after 5.1.0 will be merged with 5.0.4.
(0001837)
Dmitry   
2010-04-09 00:57   
Tested Okay
(0002180)
alex   
2010-05-11 03:38   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000599: Revise error types (warning or notice) raised by system
(0002432)
alex   
2010-06-10 13:44   
Closing since version 5.0.4 is released.