In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
591 [In-Portal CMS] Admin Interfaces bug report always 2010-03-02 08:51 2010-11-30 12:48
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.1-B1  
Reference: http://groups.google.com/group/in-portal-bugs/browse_thread/thread/241f423e8f8666ad
Change Log Message:
Estimate Points: 0
Summary: 0000591: Double border under toolbar on editing/config templates
Description: We have double black border on editing forms and configuration templates (see attachment). This happens because toolbar is one table with bottom border and editing/confuration form is other table (with no top border) with "blue subsection", that has top border. Both borders combined create that effect. Also not all forms start with toolbar OR have subsection before first field.

To fix that we need to introduce css class, that removes bottom border and use it along with "toolbar" class when appropriate.

Also we have grey instead of black right border on configuration sections. This is because it shares it with grid cell class.

-----

Sample section without toolbar is: "Tools -> Service".
Steps To Reproduce:
Additional Information:
Relationships
Attached Files: png admin_double_border_problem.png (6,547) 2010-03-02 08:51
http://tracker.in-portal.org/file_download.php?file_id=313&type=bug
png

png config_section_right_border.png (4,690) 2010-03-02 08:52
http://tracker.in-portal.org/file_download.php?file_id=314&type=bug
png

patch admin_right_border_fix_part1.patch (33,601) 2010-03-02 08:55
http://tracker.in-portal.org/file_download.php?file_id=315&type=bug
patch FixesSubSectionBorder.patch (34,111) 2010-08-02 16:02
http://tracker.in-portal.org/file_download.php?file_id=700&type=bug
patch FixesSubSectionBorder_core_v3.patch (34,824) 2010-08-29 06:57
http://tracker.in-portal.org/file_download.php?file_id=734&type=bug
patch FixesSubSectionBorder_modules_v3.patch (1,156) 2010-08-29 06:57
http://tracker.in-portal.org/file_download.php?file_id=735&type=bug
Issue History
Date Modified Username Field Change
2010-11-30 12:48 Dmitry Note Added: 0003048
2010-11-30 12:48 Dmitry Status resolved => closed
2010-08-29 06:59 alex Note Added: 0002743
2010-08-29 06:59 alex Status reviewed and tested => resolved
2010-08-29 06:59 alex Fixed in Version => 5.1.1-B1
2010-08-29 06:59 alex Resolution open => fixed
2010-08-29 06:59 alex Assigned To !COMMUNITY => alex
2010-08-29 06:59 alex Changeset attached 5.1.x r13913
2010-08-29 06:58 alex Changeset attached 5.1.x r13912
2010-08-29 06:58 alex Assigned To alex => !COMMUNITY
2010-08-29 06:58 alex Status needs testing => reviewed and tested
2010-08-29 06:57 alex Note Added: 0002742
2010-08-29 06:57 alex File Added: FixesSubSectionBorder_modules_v3.patch
2010-08-29 06:57 alex File Added: FixesSubSectionBorder_core_v3.patch
2010-08-02 16:03 Dmitry Note Added: 0002651
2010-08-02 16:03 Dmitry Assigned To Dmitry => alex
2010-08-02 16:03 Dmitry Developer => Dmitry
2010-08-02 16:03 Dmitry Status needs work => needs testing
2010-08-02 16:02 Dmitry File Added: FixesSubSectionBorder.patch
2010-07-31 13:46 Dmitry Assigned To => Dmitry
2010-07-31 13:46 Dmitry Status active => needs work
2010-07-31 13:46 Dmitry Target Version Icebox => 5.1.1
2010-05-10 14:50 alex Target Version 5.0.4 => Icebox
2010-03-02 08:56 alex Note Added: 0001503
2010-03-02 08:55 alex File Added: admin_right_border_fix_part1.patch
2010-03-02 08:53 alex Target Version => 5.0.4
2010-03-02 08:53 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/241f423e8f8666ad
2010-03-02 08:53 alex Description Updated bug_revision_view_page.php?rev_id=393#r393
2010-03-02 08:52 alex File Added: config_section_right_border.png
2010-03-02 08:51 alex File Added: admin_double_border_problem.png
2010-03-02 08:51 alex File Deleted: mail[1].1&disp=inline&realattid=f_g61tipvq0&zw
2010-03-02 08:51 alex New Issue
2010-03-02 08:51 alex File Added: mail[1].1&disp=inline&realattid=f_g61tipvq0&zw

Notes
(0001503)
alex   
2010-03-02 08:56   
Patch "admin_right_border_fix_part1.patch" fixed on all configuration sections, but contains all necessary CSS classes to be placed on other needed templates.
(0002651)
Dmitry   
2010-08-02 16:03   
Please test my patch.

It's more elegant solution when we remove Top Border from the 1st sub-section element.
(0002742)
alex   
2010-08-29 06:57   
v3 patch includes fix for all section under Tools, which were not affected by Dmitry's patch.
(0002743)
alex   
2010-08-29 06:59   
Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000591: Double border under toolbar on editing/config templates
2. Commit on behalf of Dmitry
(0003048)
Dmitry   
2010-11-30 12:48   
Closing released 5.1.1 task.