In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
580 [In-Portal CMS] Data Management bug report always 2010-02-24 02:32 2010-08-30 09:44
alex  
Dmitry  
normal  
closed 5.0.2  
fixed  
 
none 5.1.0  
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/5932bd0b414248aa
0
0000580: Issues with change log section
There are a few issues with change log section:

    * warning message about missing Status field
    * only first letter of each changed field value is shown
    * there no way to delete session log or change log records
    * even if you manage to delete change log record, then new change log records will be created, indicating delete from change log :)

-----------------

I've stumbled upon another issue yesterday: we have CachedRating field (in category items), that has "0.0000000000" value in database and "0.00" default value (format with 2 digits after comma). When value is submitted from form, then we have "0.0000000000" in original field and "0.00" as field value. They are compared as strings (to determine changes) and they differ resulting wrong change log record to be created.

I propose for each changed field we compare it's formatted original field and normal field values to determine if they are really different.

-----------------

When field has a really long value and it is changed, then all that value is displayed in grid makes it near to impossible to use it. I propose we add new format for "kChangesFormatter", like "auto_cut" or something similar and then it can cut each changed field value to normal size, when displayed in grid. When viewing change log record details, then no cutting should be made of course.
Also change log records are not optimized. For example when you open product editing page and change one field, then press on "General" tab and change that field again and again, then press Save. As a result you will get 3 change log records, but you've opened editing page only once, so we could merge all change log records together.
related to 0000107closed  (5.1.0)alex In-Portal CMS Implement "MemCached" functionality 
related to 0000842active  (Icebox) In-Portal CMS Change Log records the changes in Temporarily tables 
parent of 0000581closed  (5.0.4)alex In-Commerce Wrong calculation of HasRequiredOptions field resulting additional change log record 
related to 0000578closed  (5.0.3)alex In-Portal CMS Foreign key update problem in temp handler 
related to 0000357closed  (5.1.0)alex In-Portal CMS Form modification detector (it's php part) works strange 
patch change_log_fixes.patch (35,858) 2010-02-24 07:18
http://tracker.in-portal.org/file_download.php?file_id=300&type=bug
patch change_log_fixes_part2.patch (866) 2010-02-24 08:25
http://tracker.in-portal.org/file_download.php?file_id=302&type=bug
patch change_log_fixes_part3.patch (648) 2010-02-24 09:26
http://tracker.in-portal.org/file_download.php?file_id=303&type=bug
Issue History
2010-08-30 09:44 Dmitry Note Added: 0002756
2010-08-30 09:44 Dmitry Status needs testing => closed
2010-08-30 09:44 Dmitry Resolution open => fixed
2010-08-30 09:44 Dmitry Fixed in Version => 5.1.0
2010-08-30 09:42 Dmitry Assigned To alex => Dmitry
2010-08-30 09:42 Dmitry Status needs work => needs testing
2010-08-30 09:42 Dmitry Relationship added related to 0000842
2010-08-30 05:58 alex Note Added: 0002755
2010-08-29 19:01 Dmitry Note Added: 0002750
2010-08-29 19:01 Dmitry Assigned To Dmitry => alex
2010-08-29 19:01 Dmitry Status needs testing => needs work
2010-08-29 19:00 Dmitry Developer alex => Dmitry
2010-08-29 19:00 Dmitry Status needs work => needs testing
2010-08-02 11:14 Dmitry Target Version Icebox => 5.1.1
2010-07-31 13:48 Dmitry Note Added: 0002636
2010-07-31 13:48 Dmitry Assigned To alex => Dmitry
2010-05-10 14:50 alex Target Version 5.0.4 => Icebox
2010-05-10 14:33 alex Relationship added related to 0000357
2010-04-04 17:48 Dmitry Note Added: 0001777
2010-04-04 17:48 Dmitry Assigned To !COMMUNITY => alex
2010-04-04 17:48 Dmitry Status needs testing => needs work
2010-02-26 16:38 alex Developer => alex
2010-02-24 09:26 alex File Added: change_log_fixes_part3.patch
2010-02-24 09:24 alex Changeset attached 5.1.x r13167
2010-02-24 08:25 alex File Added: change_log_fixes_part2.patch
2010-02-24 08:24 alex Changeset attached 5.1.x r13166
2010-02-24 07:29 alex Relationship added related to 0000107
2010-02-24 07:29 alex Relationship added related to 0000578
2010-02-24 07:27 alex Assigned To => !COMMUNITY
2010-02-24 07:27 alex Status active => needs testing
2010-02-24 07:20 alex Changeset attached 5.1.x r13161
2010-02-24 07:18 alex File Added: change_log_fixes.patch
2010-02-24 02:35 alex Relationship added parent of 0000581
2010-02-24 02:32 alex Target Version => 5.0.4
2010-02-24 02:32 alex New Issue
2010-02-24 02:32 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/5932bd0b414248aa

Notes
(0001777)
Dmitry   
2010-04-04 17:48   
There are many mismatches in the 1st patch.

Please review and update so it can be safely applied to the current 5.0.x once 5.0.3 Released.

Thanks.
(0002636)
Dmitry   
2010-07-31 13:48   
Please test cases described by Alex.
(0002750)
Dmitry   
2010-08-29 19:01   
Reviewed and tested mostly okay, but some issues FOUND.

The following is still does NOT work properly:
============
Also change log records are not optimized. For example when you open product editing page and change one field, then press on "General" tab and change that field again and again, then press Save. As a result you will get 3 change log records, but you've opened editing page only once, so we could merge all change log records together.
============
(0002755)
alex   
2010-08-30 05:58   
That's not true, since such optimization code was never implemented. It's only a suggestion with lower priority and can be splitted into other issue.
(0002756)
Dmitry   
2010-08-30 09:44   
This task has been committed in 5.1.0 and tested in 5.1.1.

Separate task (bug) for Change Log saving changes in Temporarily tables has been created ( 0000842 ).