In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
555 [In-Portal CMS] Admin Interfaces bug report always 2010-01-26 13:08 2010-05-11 02:59
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.0.3-B1  
Reference: http://groups.google.com/group/in-portal-bugs/browse_thread/thread/34eeff0797659f0e
Change Log Message:
Estimate Points: 0
Summary: 0000555: Column selector (picker) doesn't remember multilingual column position
Description: Column selector (picker) doesn't remember multilingual column position. For example we have "Subject" field, which is multilingual. We place it in grid and later kMultiLanguage formatter replaces it with "l<ID>_Subject", where <ID> is ID of current language. So at the end column picker remembers position of "l1_Subject" column. Then we change language to ID = 2. Our column becomes "l2_Subject", which is new to column picker and "l1_Subject" column is gone. This was same column, but on different language is added at the end of the list, because column picker considers it as newly added column.
Steps To Reproduce:
Additional Information: I suppose we could fix this by using this idea:

1. in case if kMultiLanguage formatter renames grid column, then it added new option "formatter_renamed" to it's declaration
2. when column picker identifies column position, then it should strip language prefix ("l<ID>_") from column name (only for position detection).
Relationships
related to 0000285closed  (5.1.0)alex Translation system refactoring 
parent of 0000655closed  (5.0.3)alex "Sections" tab doesn't work in "Show All" mode with "simple" interface preset on 
Attached Files: patch ml_grid_column_fix2.patch (2,365) 2010-01-26 13:08
http://tracker.in-portal.org/file_download.php?file_id=244&type=bug
png 555-Column-Selector-FRENCH.png (161,512) 2010-03-15 18:55
http://tracker.in-portal.org/file_download.php?file_id=374&type=bug
png

png 555-Column-Selector-ENGLISH.png (159,141) 2010-03-15 18:56
http://tracker.in-portal.org/file_download.php?file_id=375&type=bug
png

patch ml_grid_column_fix2_v2.patch (3,190) 2010-03-23 14:13
http://tracker.in-portal.org/file_download.php?file_id=401&type=bug
Issue History
Date Modified Username Field Change
2010-05-11 02:59 alex Note Added: 0002111
2010-05-11 02:59 alex Status resolved => closed
2010-04-06 04:54 alex Relationship added parent of 0000655
2010-03-23 16:01 alex Note Added: 0001738
2010-03-23 16:01 alex Status reviewed and tested => resolved
2010-03-23 16:01 alex Fixed in Version => 5.0.3-B1
2010-03-23 16:01 alex Resolution open => fixed
2010-03-23 16:01 alex Assigned To !COMMUNITY => alex
2010-03-23 16:01 alex Changeset attached 5.0.x r13290
2010-03-23 15:30 Dmitry Note Added: 0001735
2010-03-23 15:30 Dmitry Status needs testing => reviewed and tested
2010-03-23 14:14 alex Note Added: 0001734
2010-03-23 14:14 alex Assigned To alex => !COMMUNITY
2010-03-23 14:14 alex Status needs work => needs testing
2010-03-23 14:13 alex File Added: ml_grid_column_fix2_v2.patch
2010-03-23 03:29 alex Note Added: 0001731
2010-03-23 01:38 Dmitry Note Added: 0001727
2010-03-19 09:53 alex Note Added: 0001701
2010-03-19 09:17 Dmitry Note Added: 0001700
2010-03-19 08:20 alex Issue Monitored: Dmitry
2010-03-19 08:20 alex Note Added: 0001696
2010-03-15 18:56 Dmitry File Added: 555-Column-Selector-ENGLISH.png
2010-03-15 18:55 Dmitry File Added: 555-Column-Selector-FRENCH.png
2010-03-15 18:55 Dmitry Note Added: 0001646
2010-03-15 18:55 Dmitry Assigned To !COMMUNITY => alex
2010-03-15 18:55 Dmitry Status needs testing => needs work
2010-02-26 18:48 Dmitry Developer => alex
2010-01-26 14:47 alex Changeset attached 5.1.x r13142
2010-01-26 14:29 alex Relationship added related to 0000285
2010-01-26 13:10 alex Assigned To => !COMMUNITY
2010-01-26 13:10 alex Status active => needs testing
2010-01-26 13:10 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/34eeff0797659f0e
2010-01-26 13:10 alex Target Version => 5.0.3
2010-01-26 13:08 alex New Issue
2010-01-26 13:08 alex File Added: ml_grid_column_fix2.patch

Notes
(0001646)
Dmitry   
2010-03-15 18:55   
1. Preserving Column order doesn't seem to work in Structure and Data Catalog Grid (tested on Links) with English primary and French.

2. Additional issues with NON-Multilingual fields - see 2 attachments.
(0001696)
alex   
2010-03-19 08:20   
Reminder sent to: Dmitry

Can you please provide grid definitions, used in tests.
(0001700)
Dmitry   
2010-03-19 09:17   
Reminder sent to: alex

This is regular 5.0.3 installation, In-Link Catalog grid with French as 2nd language.
(0001701)
alex   
2010-03-19 09:53   
Reminder sent to: Dmitry

ID and Url are not multilingual fields in default installation, that's why I need that unit config of yours to be able to replicate this on my end.
(0001727)
Dmitry   
2010-03-23 01:38   
Reminder sent to: alex

Alex, what we are doing here.

I think you should review the issue I reported.
(0001731)
alex   
2010-03-23 03:29   
This patch is missing once change:

$grids[$name]['Fields'][$field_name]['formatter_renamed'] = true;

from kMultiLanguage class. I'll check if I missed it in this patch or it's just in another task, that should be applied before this one.
(0001734)
alex   
2010-03-23 14:14   
I've actually forgot to add one more file to original patch. Here is new patch "ml_grid_column_fix2_v2.patch".
(0001735)
Dmitry   
2010-03-23 15:30   
Good work Patch works well now!
(0001738)
alex   
2010-03-23 16:01   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000555: Column selector (picker) doesn't remember multilingual column position
(0002111)
alex   
2010-05-11 02:59   
Closing all tasks from released versions.