In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
493 [In-Portal CMS] Admin Interfaces task always 2009-12-23 07:39 2012-07-25 05:32
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: Icebox  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e0b5726fdae28ea8
Change Log Message:
Estimate Points: 2
Summary: 0000493: Redirect template (kEvent::redirect attribute) has no effect, when popups are used
Description: There is way to specify template name, that should be shown after event is completed successfully. This is done by assigning it's name to $event->redirect attribute. Sadly, but this doesn't work in case if popups are used, where next shown template is retrieved from opener stack, e.g. active template before popup was opened. I propose to modify opener stack in case if $event->redirect is manually change by developer.
Steps To Reproduce:
Additional Information:
Relationships
related to 0000392closed  (5.2.0)alex Section renaming using "Section Properties" button causes one more section to be created 
related to 0001024closed  (5.2.0)alex Phrase type detection based on it's name 
related to 0001171closed  (5.2.0)alex Fatal when trying to Relate Catalog Items 
Attached Files: patch event_redirect_settings_works_with_opener_stack.patch (6,202) 2011-10-15 13:41
http://tracker.in-portal.org/file_download.php?file_id=1237&type=bug
patch event_redirect_settings_works_with_opener_stack_addon.patch (9,055) 2011-10-19 03:22
http://tracker.in-portal.org/file_download.php?file_id=1258&type=bug
patch opener_stack_change_fix.patch (2,008) 2011-11-04 13:02
http://tracker.in-portal.org/file_download.php?file_id=1298&type=bug
patch opener_stack_change_another_fix.patch (2,911) 2011-12-21 06:33
http://tracker.in-portal.org/file_download.php?file_id=1396&type=bug
patch opener_stack_urlencode_fix.patch (862) 2011-12-28 14:22
http://tracker.in-portal.org/file_download.php?file_id=1426&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005015
2012-07-25 05:32 alex Status resolved => closed
2011-12-28 14:24 alex Note Added: 0004342
2011-12-28 14:23 alex Changeset attached 5.2.x r14937
2011-12-28 14:22 alex File Added: opener_stack_urlencode_fix.patch
2011-12-21 06:35 alex Changeset attached 5.2.x r14895
2011-12-21 06:34 alex Note Added: 0004290
2011-12-21 06:33 alex File Added: opener_stack_change_another_fix.patch
2011-12-21 06:33 alex File Deleted: opener_stack_change_another_fix.patch
2011-12-21 06:33 alex File Added: opener_stack_change_another_fix.patch
2011-12-21 06:32 alex File Deleted: opener_stack_change_another_fix.patch.patch
2011-12-21 06:32 alex File Added: opener_stack_change_another_fix.patch.patch
2011-11-24 03:38 alex Relationship added related to 0001171
2011-11-04 13:06 alex Relationship added related to 0001024
2011-11-04 13:05 alex Changeset attached 5.2.x r14732
2011-11-04 13:04 alex Note Added: 0004133
2011-11-04 13:02 alex File Added: opener_stack_change_fix.patch
2011-10-22 05:26 alex Estimate Points => 2
2011-10-19 03:24 alex Changeset attached 5.2.x r14674
2011-10-19 03:23 alex Note Added: 0004073
2011-10-19 03:22 alex File Added: event_redirect_settings_works_with_opener_stack_addon.patch
2011-10-15 13:44 alex Note Added: 0004052
2011-10-15 13:44 alex Status reviewed and tested => resolved
2011-10-15 13:44 alex Fixed in Version => 5.2.0-B1
2011-10-15 13:44 alex Resolution open => fixed
2011-10-15 13:44 alex Assigned To !COMMUNITY => alex
2011-10-15 13:44 alex Changeset attached 5.2.x r14665
2011-10-15 13:43 alex Note Added: 0004051
2011-10-15 13:43 alex Status needs testing => reviewed and tested
2011-10-15 13:42 alex Time Estimate Removed 1 =>
2011-10-15 13:42 alex Assigned To => !COMMUNITY
2011-10-15 13:42 alex Developer => alex
2011-10-15 13:42 alex Status active => needs testing
2011-10-15 13:41 alex File Added: event_redirect_settings_works_with_opener_stack.patch
2011-10-15 12:30 alex Relationship added related to 0000392
2011-09-26 05:07 alex Time Estimate Added 1
2010-12-06 13:03 alex Target Version Icebox => 5.2.0
2010-12-06 13:03 alex Type bug report => task
2009-12-23 07:42 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e0b5726fdae28ea8
2009-12-23 07:42 alex Type feature request => bug report
2009-12-23 07:42 alex Reproducibility N/A => always
2009-12-23 07:42 alex Target Version => Icebox
2009-12-23 07:39 alex New Issue

Notes
(0004051)
alex   
2011-10-15 13:43   
Will test together with other tasks.
(0004052)
alex   
2011-10-15 13:44   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0000493: Redirect template (kEvent::redirect attribute) has no effect, when popups are used
(0004073)
alex   
2011-10-19 03:23   
Patch "event_redirect_settings_works_with_opener_stack_addon.patch" contains the code, that was using openerStackChange method before, but no longer does it thanks to "event_redirect_settings_works_with_opener_stack.patch" patch.

I've just forgot to commit it, since this "cat_event_handler.php" file was involved another change at the moment.
(0004133)
alex   
2011-11-04 13:04   
Patch "opener_stack_change_fix.patch" solves problem, that:
1. 'pass' => 'all' parameter was added to opener stack for events, which closed popup windows
2. last unit event was added to opener stack for events, which closed popup windows resulting event be called twice
(0004290)
alex   
2011-12-21 06:34   
Patch "opener_stack_change_another_fix.patch" fixes problem when there was no way to relate one link with another due fatal error "unknown prefix l%5Crel" error.
(0004342)
alex   
2011-12-28 14:24   
Patch "opener_stack_urlencode_fix.patch" fixes case, when parameter "param_name", set via kEvent::setRedirectParam were passed as "amp;param_name" to page, restored from opener stack.
(0005015)
alex   
2012-07-25 05:32   
Since 5.2.0 version was released.