In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
473 [In-Portal CMS] Data Management feature request N/A 2009-12-23 02:15 2010-07-22 15:06
Reporter: alex Platform:  
Assigned To: !COMMUNITY OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.2-B1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.0-B1  
Reference: http://groups.google.com/group/in-portal-dev/browse_thread/thread/fd2f3109d5fb5489?hl=en
Change Log Message:
Estimate Points: 0
Summary: 0000473: Improvements to Form Submissions
Description: 1. Form specific setting to FORCE the User to Login before they can
submit the form. If user NOT logged in it will redirect him to the
registration login template. From implementation point it's a new DB
field which is checked on the Form template with IF and ReguireLogin
inside.

2. Use Security Image (CAPTCHA) - you proposed.

3. "Show if Logged In" - I have changed the name a bit since we check
whether user is logged in.

4. Add IPAddress field (filled automatically, of course).

5. Add ReferrerURL field (filled automatically, of course).
Steps To Reproduce:
Additional Information: Also conversation feature (email-based) available in "Messages" tab during form submission editing also could be useful feature:

1. The email that is received by system Administrator should have in
Reply-to email address of user who's submitted the Form. In other
words if I submit a form and specify my Email address, the email that
will be received by the Admin will have Reply-To as my address so
Admin can reply right from he email client. Email field can be
identified if Validation has been set for it.

2. Ability to continue communication with User via Form Submission in
Admin. Example, user submitted a form specifying his email address,
next thing Admin got an email notification or perhaps the entire
submission in the email and now can reply from his Email Client. It's
would be quite useful if Admin can actually reply back (with
attachment) to User directly from the Admin and then user replies back
to Admin and so on. All this communication is stored as Submission
Messages of course. We'll be using POP3 and SMTP as well processing
for bounced messages. Preferably this requires a separate mail box
setup, but should work with any mailbox. Besides that there will be
multiple Statuses to help indicate Submissions that have new updates.
Also, the ability to "Save as Draft" the Reply to User, then come back
later to finish.

All this will be enabled if Admin marks something like "Enable Email
Communication" setting for the Form.
Relationships
related to 0000476closed  (5.0.3)alex Got no permission error, when I was trying to delete form submission 
related to 0000563closed  (5.0.3)alex Toolbar button phrase translation doesn't work 
parent of 0000794closed  (5.1.0)alex Minor tune-up for "Improvements to Form Submissions" functionality 
parent of 0000784closed  (5.1.0)alex Addition to Communication in Form Submission feature 
has duplicate 0000234closed  (Icebox) Ability to Reply to the Sender when Form submitted and Email received 
Attached Files: patch form_submissions_core.patch (190,983) 2010-04-21 11:07
http://tracker.in-portal.org/file_download.php?file_id=469&type=bug
rar img.rar (132,806) 2010-04-21 11:09
http://tracker.in-portal.org/file_download.php?file_id=470&type=bug
patch form_submissions_themes.patch (3,140) 2010-04-21 11:10
http://tracker.in-portal.org/file_download.php?file_id=471&type=bug
jpg Mailbox_DBG_output.jpg (144,776) 2010-04-22 10:11
http://tracker.in-portal.org/file_download.php?file_id=472&type=bug
jpg

patch form_submissions_core_v2.patch (198,050) 2010-04-22 15:46
http://tracker.in-portal.org/file_download.php?file_id=473&type=bug
patch 473-Improvements to Form Submissions-DEFAULT_theme_installdata.patch (2,396) 2010-04-22 17:29
http://tracker.in-portal.org/file_download.php?file_id=474&type=bug
patch form_field_edit_fix.patch (472) 2010-05-15 04:47
http://tracker.in-portal.org/file_download.php?file_id=545&type=bug
Issue History
Date Modified Username Field Change
2012-01-03 17:39 Dmitry Relationship added has duplicate 0000234
2010-07-22 15:06 alex Note Added: 0002516
2010-07-22 15:06 alex Status resolved => closed
2010-07-11 08:48 alex Issue End Monitor: alex
2010-07-07 14:14 Dmitry Relationship added parent of 0000784
2010-07-07 14:14 Dmitry Relationship added parent of 0000794
2010-05-16 18:23 Dmitry Status reviewed and tested => resolved
2010-05-16 18:23 Dmitry Resolution reopened => fixed
2010-05-16 18:23 Dmitry Note Added: 0002215
2010-05-16 18:23 Dmitry Status needs testing => reviewed and tested
2010-05-15 04:52 alex Assigned To alex => !COMMUNITY
2010-05-15 04:52 alex Status needs feedback => needs testing
2010-05-15 04:51 alex Note Edited: 0002208 bug_revision_view_page.php?bugnote_id=0002208#r484
2010-05-15 04:49 alex Changeset attached 5.1.x r13563
2010-05-15 04:48 alex Note Added: 0002208
2010-05-15 04:47 alex File Added: form_field_edit_fix.patch
2010-05-14 17:25 Dmitry Note Added: 0002204
2010-05-14 17:25 Dmitry Status resolved => needs feedback
2010-05-14 17:25 Dmitry Resolution fixed => reopened
2010-04-25 07:40 alex Note Added: 0001923
2010-04-25 07:37 alex Changeset attached 5.1.x r13400
2010-04-24 15:12 alex Note Added: 0001909
2010-04-24 15:12 alex Status reviewed and tested => resolved
2010-04-24 15:12 alex Fixed in Version => 5.1.0-B1
2010-04-24 15:12 alex Resolution open => fixed
2010-04-24 15:12 alex Changeset attached 5.1.x r13390
2010-04-24 15:11 alex Changeset attached 5.1.x r13389
2010-04-24 14:54 alex Changeset attached 5.1.x r13388
2010-04-24 14:53 alex Changeset attached 1.1.x r13387
2010-04-22 17:33 Dmitry Note Added: 0001908
2010-04-22 17:33 Dmitry Assigned To !COMMUNITY => alex
2010-04-22 17:33 Dmitry Status needs testing => reviewed and tested
2010-04-22 17:29 Dmitry File Added: 473-Improvements to Form Submissions-DEFAULT_theme_installdata.patch
2010-04-22 15:46 alex Note Added: 0001907
2010-04-22 15:46 alex Assigned To alex => !COMMUNITY
2010-04-22 15:46 alex Status needs work => needs testing
2010-04-22 15:46 alex File Added: form_submissions_core_v2.patch
2010-04-22 13:51 Dmitry Note Added: 0001906
2010-04-22 13:22 alex Issue Monitored: Dmitry
2010-04-22 13:22 alex Note Added: 0001905
2010-04-22 13:22 alex Note Added: 0001904
2010-04-22 12:11 Dmitry Note Edited: 0001903 bug_revision_view_page.php?bugnote_id=0001903#r441
2010-04-22 12:06 Dmitry Note Added: 0001903
2010-04-22 11:36 Dmitry Note Added: 0001902
2010-04-22 10:13 Dmitry Note Added: 0001901
2010-04-22 10:11 Dmitry File Added: Mailbox_DBG_output.jpg
2010-04-22 07:58 Dmitry Issue Monitored: alex
2010-04-22 07:58 Dmitry Note Added: 0001900
2010-04-22 06:32 alex Note Added: 0001899
2010-04-21 18:37 Dmitry Note Added: 0001898
2010-04-21 18:36 Dmitry Note Added: 0001897
2010-04-21 18:36 Dmitry Assigned To !COMMUNITY => alex
2010-04-21 18:36 Dmitry Status needs testing => needs work
2010-04-21 11:12 alex Time Estimate Removed 3 =>
2010-04-21 11:12 alex Note Added: 0001894
2010-04-21 11:12 alex Assigned To => !COMMUNITY
2010-04-21 11:12 alex Developer => alex
2010-04-21 11:12 alex Status active => needs testing
2010-04-21 11:10 alex File Added: form_submissions_themes.patch
2010-04-21 11:09 alex File Added: img.rar
2010-04-21 11:07 alex File Added: form_submissions_core.patch
2010-04-14 08:20 alex Relationship added related to 0000563
2010-04-14 06:38 alex Relationship added related to 0000476
2010-01-12 11:11 alex Time Estimate Added 3
2010-01-12 10:49 alex Target Version Icebox => 5.1.0
2009-12-23 02:16 alex Target Version => Icebox
2009-12-23 02:15 alex New Issue
2009-12-23 02:15 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/fd2f3109d5fb5489?hl=en

Notes
(0001894)
alex   
2010-04-21 11:12   
1. apply both patches
2. extract attached "img.rar" archive under "core/admin_templates" folder with overwrite existing file option.
3. create "/system/user_files/submission_log" folder and make it writable.

Then test install/upgrade.
(0001897)
Dmitry   
2010-04-21 18:36   
I got the following error message when trying to create a new form (fresh install):


Fatal Error: Column 'ReplyMessageSignature' cannot be null (1048)
SQL:
    INSERT INTO ses_739072766_2_edit_Forms (`FormId`, `Title`, `Description`, `RequireLogin`, `UseSecurityImage`, `EnableEmailCommunication`, `ReplyFromName`, `ReplyFromEmail`, `ReplyCc`, `ReplyBcc`, `ReplyMessageSignature`, `ReplyServer`, `ReplyPort`, `ReplyUsername`, `ReplyPassword`, `BounceEmail`, `BounceServer`, `BouncePort`, `BounceUsername`, `BouncePassword`)
    VALUES (DEFAULT, 'Test', NULL, '0', '0', '0', '', '', '', '', NULL, '', '110', '', '', '', '', '110', '', '') in w:\dev\SVN\5.1.x\core\kernel\application.php on line 2614
(0001898)
Dmitry   
2010-04-21 18:37   
Reminder sent to: alex

Please see last note.
(0001899)
alex   
2010-04-22 06:32   
That field should be "NULL" instead of "NOT NULL" (in db and forms_config.php).

Also there is bug in MIME header decoding code.

Please replace top of "_decodeHeader" method (1 line after "Remove white space between encoded-words" comment) with this code:

// Remove white space between encoded-words (http://www.ietf.org/rfc/rfc2047.txt)
$regexp = '/(=\?[^?]+\?(Q|B)\?[^?]*\?=)(\s)+=\?/i';

while (preg_match($regexp, $input)) {
    // process each word separately
    $input = preg_replace($regexp, '\1=?', $input);
}
(0001900)
Dmitry   
2010-04-22 07:58   
Thanks, some further notes:

1. I see LA_EMPTYVALUE for Type field in the grid of Fields (which ok), but also it's on the Add Field form - which leads to a Validation error if selected.

I believe it should not be there? or what's the purpose of it?
(0001901)
Dmitry   
2010-04-22 10:13   
2. There is some output when DBG is ON, but it should be moved to DBG (see attachment Mailbox_DBG_output). I suggest adding something like "Reading MAILBOX (mailbox@name)" right before these messages.
(0001902)
Dmitry   
2010-04-22 11:36   
3. I believe "Resend Reply" doesn't work at all (in the Grid of Replies).

This is the SQLs for pulling selected Form and Submission id for Resending:
==========

Name:
    SELECT FormSubmissions.* ,(FormSubmissions.SubmissionTime) AS `SubmissionTime_date`,(FormSubmissions.SubmissionTime) AS `SubmissionTime_time`,(FormSubmissions.LastUpdatedOn) AS `LastUpdatedOn_date`,(FormSubmissions.LastUpdatedOn) AS `LastUpdatedOn_time`
    FROM FormSubmissions
    WHERE (`FormSubmissions`.FormSubmissionId = '0')
    LIMIT 0,1
[Runtime: 0.00055789947509766s] [File: dbitem.php:405] [Query Number: 15] [PrefixSpecial: formsubs.-item]

Name:
    SELECT Forms.*
    FROM Forms
    WHERE (`Forms`.FormId = '0')
    LIMIT 0,1
[Runtime: 0.00054407119750977s] [File: dbitem.php:405] [Query Number: 16] [PrefixSpecial: form]

Name:
    SELECT SubmissionLog.* ,(SubmissionLog.SentOn) AS `SentOn_date`,(SubmissionLog.SentOn) AS `SentOn_time`,(SubmissionLog.RepliedOn) AS `RepliedOn_date`,(SubmissionLog.RepliedOn) AS `RepliedOn_time`,(SubmissionLog.BounceDate) AS `BounceDate_date`,(SubmissionLog.BounceDate) AS `BounceDate_time`
    FROM SubmissionLog
    WHERE (`SubmissionLog`.SubmissionLogId = '1')
    LIMIT 0,1
==========

I don't think it should be " `FormSubmissions`.FormSubmissionId = '0' "
(0001903)
Dmitry   
2010-04-22 12:06   
(edited on: 2010-04-22 12:11)
After long testings, I have some additional notes that would make system much more flexible - if possible of course.

USABILITY notes:

1. On General tab of Submission

a. make possible to change:
- "Status" field (drop-down)
- all of Submission Data (if possible)

b. add new sub-section called Submission Notes
- Notes - text-area field that will be always there and entered by the Admin.

2. On Reply Email tab of Message

a. Ability to EDIT Send From address - right now it's read-only - so it's custom if needed.

Please review and reply if this possible and quick to do.
(0001904)
alex   
2010-04-22 13:22   
1. Issue in 0000473:0001900 note has already been fixed in 5.0.3, see 0000634 task.
2. About note 0000473:0001901 - I agree.
3. Will check that.

About 0000473:0001903 note:
1a - why to make it editable, since it's managed automatically?
1b - agree.

2a - why this is need, since "Reply-To" header will anyway be set to default submission email.
(0001905)
alex   
2010-04-22 13:22   
Reminder sent to: Dmitry

see my previous note
(0001906)
Dmitry   
2010-04-22 13:51   
Thanks your reply, please see below things under question:

1a - I was going through the tests as a real Admin with real scenarios + I had some feedback from VO people on the other day.

In some cases it's very useful to be able to adjust things, but I think STATUS should remain unchanged(some other things rely on it) when "Submission Data" can be adjusted by Admin. I image there is a need to correct a phone number or Name if initial submission.

- "Status" field (drop-down) - NOT NEEDED (agreed)
- all of Submission Data (if possible) - NEEDED


2a - you are correct - NOT NEEDED
(0001907)
alex   
2010-04-22 15:46   
Fixed version uploaded.
(0001908)
Dmitry   
2010-04-22 17:33   
Reviewed and tested okay for commit!

2 quick notes:

1. I have reviewed necessity for ability to change Status of Submission by Hand and I think it's necessary IF Communication via Message is NOT enabled - can we do that? This means that User can not update status to Replied if he already replied to the Submission (by email on he own).

2. Attached "473-Improvements to Form Submissions-DEFAULT_theme_installdata.patch" for fix for Default theme installation data to support new functionality.


Please do both and COMMIT this!
(0001909)
alex   
2010-04-24 15:12   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000473: Improvements to Form Submissions
(0001923)
alex   
2010-04-25 07:40   
Reminder sent to: Dmitry

During testing also check that proper licensing information is also present.

Also we have 2009 year in all licenses, but it's middle of 2010 year now.
(0002204)
Dmitry   
2010-05-14 17:25   
Found a new issue:

1. Can NOT Save(update) any existing Field once Form has been initially created. ALL data fields of the Field are EMPTY when trying to edit it.
(0002208)
alex   
2010-05-15 04:48   
(edited on: 2010-05-15 04:51)
Patch "form_field_edit_fix.patch" (already commited) fixed issue found in 0000473:0002204.

Found problem was always there, but only became visible once 0000435 task was completed.
(0002215)
Dmitry   
2010-05-16 18:23   
Tested good! Thanks for the patch.
(0002516)
alex   
2010-07-22 15:06   
Closing, since 5.1.0 release has been released.