Notes |
|
(0001447)
|
Dmitry
|
2010-02-01 14:28
|
|
2 Additional things that we need is (discussed in Groups, link above)
1. Email Events FROM Address (or just domain part of it)
2. SSL settings should be Site based too. |
|
|
(0001449)
|
Dmitry
|
2010-02-02 10:57
|
|
Additional notes in regards to:
1. Regex option (check-box) for Domain and SSL Domains
2. Geo-Location:
a. List of IPs or IP networks (one per line)
b. "Force Redirect to this Domain" if IP matched |
|
|
(0001451)
|
alex
|
2010-02-02 11:29
|
|
My interpretation:
1. add IPRange field (textarea) for to make this domain current no matter what domain was visited by user
2. add UseRegExpInDomainName, UseRegExpInSSLUrl to determine if regular expression is entered as domain/ssl domain name |
|
|
(0001453)
|
alex
|
2010-02-03 06:22
|
|
Ready to be test, but we need to draw new icon for the tree. |
|
|
(0001526)
|
alex
|
2010-03-09 09:12
|
|
TODO: move querySiteDomain and related functionality method from event handler to helper |
|
|
(0001527)
|
alex
|
2010-03-09 12:51
|
|
Without "site_domains_application_only_v2.patch" method kApplication::siteDomainField fails to store current domain object in static variable. Patch uses kApplication class attribute for that purpose. |
|
|
(0001528)
|
alex
|
2010-03-09 13:00
|
|
Patch "site_domains_lang_theme_v2.patch" fixes problem, that language/theme defined in site domain wasn't used as default, when mod-rewrite mode was off. |
|
|
(0001529)
|
alex
|
2010-03-09 13:05
|
|
Also DomainIPRange field must not be "NOT NULL", since it's of "text" data type. Without it we will get SQL error, when we are creating domain without that field filled. |
|
|
(0001533)
|
alex
|
2010-03-10 03:18
|
|
BUG: SiteDomains table isn't listed in "core/install/remove_schema.sql" file. |
|
|
(0001893)
|
alex
|
2010-04-18 05:45
(edited on: 2010-04-18 05:46) |
|
There have been new ideas on how to improve interface of this feature here:
http://groups.google.com/group/in-portal-dev/browse_thread/thread/448bb75ce0b078f7
Based on it there is what should be changed:
1. move all In-Commerce related fields to new tab named "In-Commerce" in site domain adding/editing form (added by In-Commerce module)
2. perform ALTER statement when In-Commerce is installed to all In-Commerce only used columns to SiteDomains table
Also we need to all "alt"/"title" attribute to "Use Regular Expressions" checkbox near domain name and domain ssl path fields.
|
|
|
(0002034)
|
alex
|
2010-05-01 11:25
|
|
Only apply "site_domains_core_v2.patch" and "site_domains_modules_v2.patch" files. |
|
|
(0002051)
|
Dmitry
|
2010-05-02 22:13
(edited on: 2010-05-02 23:06) |
|
Tested the patch, overall results are good!
Please find the notes below:
1. I get the following Warning on any installation step
Warning: Table 'inportal_51X.Currencies' doesn't exist (1146)
SQL:
SELECT ISO
FROM Currencies
WHERE IsPrimary = 1
LIMIT 0,1 in w:\SVN\in-portal-5.1.x\core\kernel\application.php on line 2679
Sounds like we need to move Currencies into the CORE module?
2. Clear "CachedUrls" table on change of Site Domains or other related operation (need to think what else is effected here).
3. We might want to completely DISABLE languages that are not listed as Available for current SiteDomain. I have came across the situation when I had French language loaded (ie. http://domain1.riga.com/SVN/in-portal-5.1.x/french/index.html). while it's NOT even available for selection of Languages, but once I typed it the language name in URL it worked.
I propose we:
Make that User can't load the items that are in list of Selected (if there are any) and simple redirect to Primary one (if exists). This reflects on:
- Languages
- Currencies
- Payment Types.
Additional Question
I want to clarify on how to do the setup when I need to have the same domain (ie. www.jurmala.com), but based on User IP be able to load different settings as we have now. Like if I come from Latvia (checked by IP) I want them so see site in Latvian by default, if come from US they will see in English, but still the domain will be the same. It's kind of different content on the same Domain based on Geo-Location.
As fas as I can see right now we are trying to match/query the DOMAIN name in querySiteDomain by name once and ONLY if not found will go search through this:
foreach ($site_domains as $id => $site_domain) {
if (ipMatch($site_domain['DomainIPRange'], "\n")) {
if ($site_domain['RedirectOnIPMatch']) {
$this->Application->Redirect('external:http://' . $site_domain['DomainName'] . $_SERVER['REQUEST_URI']);
}
return $id;
}
}
Does it make sense to you what I am asking?
|
|
|
(0002052)
|
Dmitry
|
2010-05-02 23:05
|
|
Please see my prev. comments. |
|
|
(0002054)
|
Dmitry
|
2010-05-04 15:13
|
|
Based on our last discussion - let's do the following:
1. Cleanup when changes made to SiteDomains
Clear "CachedUrls" table on change of Site Domains or other related operation (need to think what else is effected here).
2. Disable NOT available languages, currencies (optional), payment types (optional)
We might want to completely DISABLE languages that are not listed as Available for current SiteDomain. I have came across the situation when I had French language loaded (ie. http://domain1.riga.com/SVN/in-portal-5.1.x/french/index.html). while it's NOT even available for selection of Languages, but once I typed it the language name in URL it worked.
I propose we:
Make that User can't load the items that are in list of Selected (if there are any) and simple redirect to Primary one (if exists). This reflects on:
- Languages
- Currencies
- Payment Types.
3. Fix for IP based match redirect:
Please make sure IP if range is changed and redirected first as it's discussed here - http://groups.google.com/group/tba-discussion/browse_thread/thread/0a0e0047ccf319df#
Also, I think we would need to set a COOKIE if we completed redirect already so it won't happen next time.
4. Additions to Site Domains
Please add:
1. Description field
2. Adjust Redirecting options:
a. Change "Force Redirect" check-box to drop-down with 2 options:
- Disabled (nothing done)
- This Domain if IP matched
- External Domain if IP matched
b. Add "ExternalRedirectDomain" field (translation External Redirect Domain) after IP textarea field.
5. Possible issues multiple-records of the same SiteDomain.
In some cases users might want to show different Primary language and other Domain based settings based on IP address (network), but still remain on the same domain.
For example if I would setup 2 site domains - jurmala.com and jurmala.com and both would have different Primary (available) languages and Force Redirect based on IP match.
Example:
a. jurmala.com/index.html (from Riga would should show Latvian as primary language)
b. jurmala.com/index.html (from Chicago would should show English as primary language)
Now if we have MOD-REWRITE enabled this will NOT be working since we are using CachedUrl table and look at URL based on the CRC32 from URL so both will be the same in the above case.
I propose:
Add currently loaded Domain as a new field to CachedUrls or add it to the CRC32 mix which ever is more efficient. |
|
|
(0002063)
|
alex
|
2010-05-05 09:23
|
|
|
|
(0002068)
|
Dmitry
|
2010-05-05 12:44
|
|
Tested okay, please commit. |
|
|
(0002195)
|
alex
|
2010-05-12 04:36
|
|
Fix committed to 5.1.x branch. Commit Message:
Fixes 0000472: Domain-based site auto-configuration |
|
|
(0002517)
|
alex
|
2010-07-22 15:06
|
|
Closing, since 5.1.0 release has been released. |
|