|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
447 |
[In-Portal CMS] Mailing System |
bug report |
always |
2009-12-16 11:18 |
2012-07-25 05:32 |
|
|
Reporter:
|
Dmitry |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.0.1 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.2.0-B1 |
|
|
Reference:
|
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/0b67fe3fe5da1229 |
|
Change Log Message:
|
|
|
Estimate Points:
|
1 |
|
|
Summary:
|
0000447: Update EmailLog table only when Email has been physically sent |
|
Description:
|
Currently record in EmailLog table is created after
"kEmailSendingHelper::Deliver" method is called. This approach is correct in
most cases, but when email is placed into email queue and is sent later via
cron, then log record is created immediately.
I propose to create "kEmailSendingHelper::setLogData" method, that should
accept EmailLog table fields (e.g. fromuser, event, EventParams) and store
all given data in "kEmailSendingHelper::_logData" attribute. Add new field
LogData to EmailQueue table and store "kEmailSendingHelper::_logData"
attribute contents in case, when email is placed into queue. In case, when
Deliver method is called it will use log data stored before to create log
record. Method "kEmailSendingHelper::Clear" should also clear log data
stored before. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | |
|
Attached Files:
|
 email_log_writing_changes_447.patch (3,715) 2011-12-12 09:18
http://tracker.in-portal.org/file_download.php?file_id=1368&type=bug
log_email_only_after_sending_v2.patch (7,178) 2011-12-13 03:37
http://tracker.in-portal.org/file_download.php?file_id=1370&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2012-07-25 05:32 |
alex |
Status |
resolved => closed |
|
2012-07-25 05:32 |
alex |
Note Added: 0005027 |
|
|
2011-12-13 03:39 |
alex |
Note Added: 0004249 |
|
|
2011-12-13 03:39 |
alex |
Status |
reviewed and tested => resolved |
|
2011-12-13 03:39 |
alex |
Fixed in Version |
=> 5.2.0-B1 |
|
2011-12-13 03:39 |
alex |
Resolution |
open => fixed |
|
2011-12-13 03:39 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2011-12-13 03:39 |
alex |
Changeset attached |
5.2.x r14861 |
|
2011-12-13 03:39 |
alex |
Target Version |
Icebox => 5.2.0 |
|
2011-12-13 03:39 |
alex |
Note Added: 0004248 |
|
|
2011-12-13 03:39 |
alex |
Assigned To |
alex => !COMMUNITY |
|
2011-12-13 03:39 |
alex |
Status |
needs testing => reviewed and tested |
|
2011-12-13 03:37 |
alex |
File Added: log_email_only_after_sending_v2.patch |
|
|
2011-12-13 02:32 |
alex |
Reference |
Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/0b67fe3fe5da1229[url] => [url]http://groups.google.com/group/in-portal-bugs/browse_thread/thread/0b67fe3fe5da1229 |
|
2011-12-13 02:32 |
alex |
Estimate Points |
=> 1 |
|
2011-12-12 09:18 |
erik |
Note Added: 0004245 |
|
|
2011-12-12 09:18 |
erik |
Assigned To |
erik => alex |
|
2011-12-12 09:18 |
erik |
Developer |
=> erik |
|
2011-12-12 09:18 |
erik |
Status |
needs work => needs testing |
|
2011-12-12 09:18 |
erik |
File Added: email_log_writing_changes_447.patch |
|
|
2011-12-12 08:07 |
erik |
Assigned To |
alex => erik |
|
2009-12-16 11:18 |
Dmitry |
New Issue |
|
|
2009-12-16 11:18 |
Dmitry |
Status |
active => needs work |
|
2009-12-16 11:18 |
Dmitry |
Assigned To |
=> alex |
|
2009-12-16 11:18 |
Dmitry |
Reference |
=> Google Groups [url]http://groups.google.com/group/in-portal-bugs/browse_thread/thread/0b67fe3fe5da1229[url] |
|
Notes |
|
|
(0004245)
|
|
erik
|
|
2011-12-12 09:18
|
|
|
Patch attached - needs testing. |
|
|
|
(0004248)
|
|
alex
|
|
2011-12-13 03:39
|
|
|
What was written in task was done. However obviously e-mail sending process, that doesn't use send queue should also use setLogData method. This was fixed in 2nd patch attached. |
|
|
|
(0004249)
|
|
alex
|
|
2011-12-13 03:39
|
|
Fix committed to 5.2.x branch. Commit Message:
Fixes 0000447: Update EmailLog table only when Email has been physically sent |
|
|
|
(0005027)
|
|
alex
|
|
2012-07-25 05:32
|
|
|
Since 5.2.0 version was released. |
|