In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
44 [In-Portal CMS] Data Management bug report always 2009-06-03 14:37 2011-09-19 16:08
alex  
alex  
normal  
closed 5.1.0  
fixed  
 
none 5.1.3-B1  
0
0000044: "Files" are NOT Deleted when Editing Sub-Items
When deleting files on subitem edit form, then they are scheduled for deleting and should be deleted later in OnSave event for main item.

But they were not be deleted at all, because of schedule variable ("<prefix_special>_pending_actions_<window_id>") contains <window_id> in it, which will differ between window, where "Save" and "Delete" buttons are located.

I propose to process file pending actions from OnUpdate/OnCreate events (when in live mode) and from "OnAfterCopyToLive" temp handler event, when temp tables are used.
Maybe using actual topmost wid will help.
related to 0000043closed  (5.2.0)alex SWFUploader and "Save" button. 
related to 0001064closed  (5.1.3)alex Parent methods not called in UsersEventHandler class 
patch subitems_files_not_deleted_on_main_item_save.patch (4,037) 2011-05-21 11:15
http://tracker.in-portal.org/file_download.php?file_id=1016&type=bug
Issue History
2011-09-19 16:08 alex Note Added: 0003855
2011-09-19 16:08 alex Status resolved => closed
2011-05-28 14:35 alex Relationship added related to 0001064
2011-05-23 02:36 alex Changeset attached 5.1.x r14336
2011-05-23 02:36 alex Note Added: 0003479
2011-05-23 02:36 alex Status reviewed and tested => resolved
2011-05-23 02:36 alex Fixed in Version => 5.1.3-B1
2011-05-23 02:36 alex Resolution open => fixed
2011-05-22 01:12 Dmitry Note Added: 0003458
2011-05-22 01:12 Dmitry Assigned To !COMMUNITY => alex
2011-05-22 01:12 Dmitry Status needs testing => reviewed and tested
2011-05-21 11:17 alex Note Added: 0003457
2011-05-21 11:17 alex Target Version Icebox => 5.1.3
2011-05-21 11:17 alex Note Added: 0003456
2011-05-21 11:17 alex Assigned To Dmitry => !COMMUNITY
2011-05-21 11:17 alex Developer => alex
2011-05-21 11:17 alex Status needs work => needs testing
2011-05-21 11:15 alex File Added: subitems_files_not_deleted_on_main_item_save.patch
2010-12-06 12:34 alex Relationship added related to 0000043
2010-12-06 12:33 Dmitry Target Version 5.1.2 => Icebox
2010-09-28 14:00 Dmitry Fixed in Version 5.1.2 =>
2010-09-28 14:00 Dmitry Target Version Icebox => 5.1.2
2010-09-28 12:06 Dmitry Assigned To alex => Dmitry
2010-09-28 12:06 Dmitry Fixed in Version => 5.1.2
2010-08-31 14:21 alex version => 5.1.0
2009-11-25 01:20 Dmitry Status active => needs work
2009-10-08 18:21 Dmitry Note Added: 0000856
2009-10-08 18:21 Dmitry Summary Files are NOT Deleted when Editing Sub-Items => "Files" are NOT Deleted when Editing Sub-Items
2009-10-03 07:53 administrator Status reviewed and tested => active
2009-09-20 15:29 alex Target Version 5.1.0 => Icebox
2009-08-03 15:50 Dmitry Assigned To => alex
2009-08-03 15:50 Dmitry Status active => reviewed and tested
2009-08-03 15:50 Dmitry Target Version 5.0.1 => 5.1.0
2009-07-05 09:51 Dmitry Target Version 5.2.x => 5.0.1
2009-06-29 02:49 alex Additional Information Updated bug_revision_view_page.php?rev_id=87#r87
2009-06-07 06:37 alex Reproducibility @70@ => always
2009-06-07 06:07 alex Category (No Category) => Data Management
2009-06-06 23:15 Dmitry Target Version => 5.2.x
2009-06-06 23:15 Dmitry Summary Files are not deleted when editing subitems. => Files are NOT Deleted when Editing Sub-Items
2009-06-03 14:37 alex New Issue

Notes
(0000856)
Dmitry   
2009-10-08 18:21   
Confirming the issue here.
(0003456)
alex   
2011-05-21 11:17   
At last I did it.

Without this patch flash uploader isn't deleting files, that are no longer referenced by any unit.
(0003457)
alex   
2011-05-21 11:17   
Moving to 5.1.3, since it's good to have 2-year old bug fixed.
(0003458)
Dmitry   
2011-05-22 01:12   
Tested ok, please commit.
(0003479)
alex   
2011-05-23 02:36   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000044: "Files" are NOT Deleted when Editing Sub-Items
(0003855)
alex   
2011-09-19 16:08   
Closing, since 5.1.3 release has been released.