|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
436 |
[In-Portal CMS] Template System |
task |
always |
2009-12-04 13:04 |
2010-01-11 22:01 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.0.1 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.0.2-B1 |
|
|
Reference:
|
Google Groups http://groups.google.com/group/in-portal-dev/browse_thread/thread/7a9e3e7e7bdb7505?hl=en |
|
Change Log Message:
|
|
|
Estimate Points:
|
0 |
|
|
Summary:
|
0000436: Changing behavior of "m_Comments" tag to better support internal comments |
|
Description:
|
Currently <inp2: tags inside HTML comment tags are not processed, but there are cases, like:
<!--[if IE 6]><script type="text/javascript"
src="<inp2:m_TemplatesBase/>/js/min-max.js"></script><![endif]-->
when they should work. Currently we have tag <inp2:m_Comment>...</inp2:m_Comment> that doesn't show it's contents after parsing. It's pretty useless since we can write comments in form <!--## to
remove ##--> that will do the same without additional tags. I propose we
make <inp2:m_Comment> tag create areas in template where <inp2: tags inside
comments could be parsed (it will change NParser->InsideComment mark and
then restore it's back at the end). Resulting code will be:
<inp2:m_Comment><!--[if IE 6]><script type="text/javascript"
src="<inp2:m_TemplatesBase/>/js/min-max.js"></script><![endif]--></inp2:m_Comment>
We could also rename this tag to make sure it's named by the action it does. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | |
|
Attached Files:
|
 tags_inside_comments.patch (1,365) 2009-12-04 13:04
http://tracker.in-portal.org/file_download.php?file_id=152&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2010-01-11 22:01 |
Dmitry |
Note Added: 0001310 |
|
|
2010-01-11 22:01 |
Dmitry |
Status |
resolved => closed |
|
2009-12-20 06:57 |
alex |
Note Added: 0001185 |
|
|
2009-12-20 06:57 |
alex |
Status |
reviewed and tested => resolved |
|
2009-12-20 06:57 |
alex |
Fixed in Version |
=> 5.0.2-B1 |
|
2009-12-20 06:57 |
alex |
Resolution |
open => fixed |
|
2009-12-20 06:57 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2009-12-20 06:57 |
alex |
Changeset attached |
5.0.x r12956 |
|
2009-12-20 06:57 |
alex |
Summary |
Changing behaviour of "m_Comments" tag to better support internal comments => Changing behavior of "m_Comments" tag to better support internal comments |
|
2009-12-20 01:58 |
Dmitry |
Note Added: 0001175 |
|
|
2009-12-20 01:58 |
Dmitry |
Status |
needs testing => reviewed and tested |
|
2009-12-11 00:16 |
Dmitry |
Reporter |
Dmitry => alex |
|
2009-12-11 00:16 |
Dmitry |
Target Version |
=> 5.0.2 |
|
2009-12-04 13:05 |
Dmitry |
Reference |
Google Groups => Google Groups http://groups.google.com/group/in-portal-dev/browse_thread/thread/7a9e3e7e7bdb7505?hl=en |
|
2009-12-04 13:05 |
Dmitry |
Assigned To |
=> !COMMUNITY |
|
2009-12-04 13:05 |
Dmitry |
Status |
active => needs testing |
|
2009-12-04 13:04 |
Dmitry |
New Issue |
|
|
2009-12-04 13:04 |
Dmitry |
File Added: tags_inside_comments.patch |
|
|
2009-12-04 13:04 |
Dmitry |
Reference |
=> Google Groups |