|
Notes |
|
|
(0001012)
|
|
Dmitry
|
|
2009-10-28 01:21
|
|
This seems to be fixed it self with patch symlink_for_physical_templates_v3.patch from 0000359
|
|
|
|
(0001019)
|
|
alex
|
|
2009-10-29 03:39
|
|
|
Reminder sent to: Dmitry
Not exactly, I was fixed, when I removed code, that was setting "m_cat_id" when physical template name was used in url, because it was breaking permission check on link add review page. |
|
|
|
(0001020)
|
|
alex
|
|
2009-10-29 03:40
|
|
|
Anyway I think, that we should use "MenuTitle" field of "index" page for navigation bar, not it's "Name" field contents. |
|
|
|
(0001021)
|
|
Dmitry
|
|
2009-10-29 10:14
|
|
|
Real question is what happens when you are in Simple admin interface and not able to manage all 3 Titles, then you update 1 and other 2 are stay un-updated? |
|
|
|
(0001022)
|
|
alex
|
2009-10-29 10:19
(edited on: 2009-10-29 10:32) |
|
There is fix somewhere in e_category_eh.php in 0000392 (task about page renaming), that does this:
in case if visible title field is changed and menu title and html title value matches previous title field value, then they are also updated.
|
|
|
|
(0001023)
|
|
Dmitry
|
|
2009-10-30 17:08
|
|
Hi Alex,
I thought it would make more sense to show things visually, here it comes:
1. I had Title section created in Simple interf.
2. Renamed it (1st field only available) to New Title in Simple interf.
3. TO Test -- opened on Front End see that
4. TO Confirm -- opened Edit section in Admin in Advanced interf.
Can you confirm that this won't be happening when we apply patch from 0000392 ? |
|
|
|
(0001053)
|
|
Dmitry
|
|
2009-11-09 01:16
|
|
Addition to above we need to address the issue with highlighting the Home section for Default and Simple menus.
The best this can be accomplished by adjusting CachedMenu method itself so it thinks of index.tpl template as of Home section and highlights it. |
|
|
|
(0001066)
|
|
alex
|
|
2009-11-10 04:06
|
|
1. Both 0000407:0001023 and 0000407:0001053 fixed and commited.
2. "Home > Home" problem in navigation bar is back if you apply patch I've attached.
If you don't apply patch, then link to home page from menu will be "home.html", but from header/footer/navigation bar will be "index.html". So it seems, that we still need to fix this in this or next release.
What you think about it? |
|
|
|
(0001079)
|
|
Dmitry
|
|
2009-11-11 02:08
|
|
Is it possible that I can't get new patch to work as described:
http://simone1.intechnic.com/dev/SVN/5.0.x-bf/simple/index.html
Please try Home URLs |
|
|
|
(0001083)
|
|
alex
|
|
2009-11-11 02:34
|
|
It works as expected:
1. visit http://simone1.intechnic.com/dev/SVN/5.0.x-bf/simple/index.html
2. Site logo (which is missing) in top left corner lead to home.html and "Home" menu item also leads to home.html
3. Go to mentioned links and see "home > home" navigation bar. |
|
|
|
(0001151)
|
|
alex
|
|
2009-11-15 05:15
|
|
|
Agreed with Dmitry, that solution, where st_CachedMenu tag will always use physical template name for link to home page (e.g. "index.html") instead of structure-based name (e.g. "home.html") will be more appropriate under current conditions. |
|
|
|
(0001156)
|
|
alex
|
|
2009-11-18 08:38
|
|
|
Please use "duplicate_home_in_navigation_bar_v2.patch" for testing. This patch only affects 0000407:0001151 comment. |
|
|
|
(0001161)
|
|
Dmitry
|
|
2009-11-25 01:15
|
|
|
|
|
(0001166)
|
|
alex
|
|
2009-12-19 04:04
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000407: Issue with Home section |
|
|
|
(0001315)
|
|
Dmitry
|
|
2010-01-11 22:01
|
|
|
EditingSectionTitleInSIMPLEAdmin-20091030.jpeg (88,188) 2009-10-30 17:03
dupe_home_problem_display.patch (5,514) 2009-11-10 04:02