|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
391 |
[In-Portal CMS] Front End |
bug report |
always |
2009-10-15 01:11 |
2010-01-11 22:01 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.0.1 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.0.2-B1 |
|
|
Reference:
|
Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/810c9df924457c59 |
|
Change Log Message:
|
|
|
Estimate Points:
|
0 |
|
|
Summary:
|
0000391: Link "View in Browse Mode" doesn't respect default browse mode setting |
|
Description:
|
When I use "View in Browse Mode" link near section or category item, then I'm directed to it's page on Front-End not in default browse mode set by current interface preset (settings.php in current site config set), but always in "Browse Mode" mode.
On the other hand link really says "View in BROWSE MODE", so maybe it should always use "Browse Mode", but what in case if it was disabled by interface preset? |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | |
|
Attached Files:
|
 default_browse_mode_fix.patch (2,655) 2009-12-20 07:39
http://tracker.in-portal.org/file_download.php?file_id=171&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2010-01-11 22:01 |
Dmitry |
Note Added: 0001304 |
|
|
2010-01-11 22:01 |
Dmitry |
Status |
resolved => closed |
|
2009-12-22 05:18 |
alex |
Note Added: 0001212 |
|
|
2009-12-22 05:18 |
alex |
Status |
reviewed and tested => resolved |
|
2009-12-22 05:18 |
alex |
Fixed in Version |
=> 5.0.2-B1 |
|
2009-12-22 05:18 |
alex |
Resolution |
open => fixed |
|
2009-12-22 05:18 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2009-12-22 05:18 |
alex |
Changeset attached |
5.0.x r12971 |
|
2009-12-20 19:00 |
Dmitry |
Reference |
=> Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/810c9df924457c59 |
|
2009-12-20 18:32 |
Dmitry |
Note Added: 0001195 |
|
|
2009-12-20 18:32 |
Dmitry |
Status |
needs testing => reviewed and tested |
|
2009-12-20 07:42 |
alex |
Note Added: 0001191 |
|
|
2009-12-20 07:42 |
alex |
Assigned To |
alex => !COMMUNITY |
|
2009-12-20 07:42 |
alex |
Status |
needs work => needs testing |
|
2009-12-20 07:39 |
alex |
File Added: default_browse_mode_fix.patch |
|
|
2009-12-20 00:20 |
Dmitry |
Note Added: 0001168 |
|
|
2009-12-20 00:20 |
Dmitry |
Assigned To |
Dmitry => alex |
|
2009-12-20 00:20 |
Dmitry |
Status |
needs feedback => needs work |
|
2009-11-25 02:28 |
alex |
Note Added: 0001162 |
|
|
2009-11-25 02:28 |
alex |
Assigned To |
alex => Dmitry |
|
2009-11-25 02:28 |
alex |
Status |
needs work => needs feedback |
|
2009-11-25 01:14 |
Dmitry |
Assigned To |
=> alex |
|
2009-11-25 01:14 |
Dmitry |
Status |
active => needs work |
|
2009-11-25 01:14 |
Dmitry |
Target Version |
Icebox => 5.0.2 |
|
2009-10-15 01:11 |
alex |
Target Version |
=> Icebox |
|
2009-10-15 01:11 |
alex |
New Issue |
|
|
Notes |
|
|
(0001162)
|
|
alex
|
|
2009-11-25 02:28
|
|
|
What should I do? Need I change code the way I've proposed? |
|
|
|
(0001168)
|
|
Dmitry
|
|
2009-12-20 00:20
|
|
I think we should:
1. Leave "wording" as is for now.
2. Change the code to settings in "settings.php" as applied to that Browse option.
Thanks. |
|
|
|
(0001191)
|
|
alex
|
|
2009-12-20 07:42
|
|
While creating this patch I've came across several issues and fixed them too:
1. "View in Browse Mode" link was ignoring mod-rewrite setting - was always build in non-mod-rewrite mode.
2. Even, when I've transformed them to work according to mod-rewrite setting:
- both (category, category item) links were having theme name in url even if it was default theme;
- category item url was containing "admin" in url.
All mentioned above is fixed now. |
|
|
|
(0001195)
|
|
Dmitry
|
|
2009-12-20 18:32
|
|
|
Tested out Okay, please Commit! |
|
|
|
(0001212)
|
|
alex
|
|
2009-12-22 05:18
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000391: Link "View in Browse Mode" doesn't respect default browse mode setting |
|
|
|
(0001304)
|
|
Dmitry
|
|
2010-01-11 22:01
|
|
|