In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
362 [In-Portal CMS] Install / Upgrages task always 2009-10-07 06:19 2010-07-22 15:06
Reporter: alex Platform:  
Assigned To: !COMMUNITY OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.1  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.0-B1  
Reference:
Change Log Message: All Modules moved under "modules/" folder
Estimate Points: 0
Summary: 0000362: We should move all module folders to new "modules" subfolder
Description: Currently we have all module folders located in top folder. In case, when multiple modules are used, then it's not obvious to user, when folder belongs to module and what folder is system. Also during search for unit configs we also don't know it and scan all folders. This raises a problem in case if site has it's backup under main installation folder.

I propose we create new folder on top level names modules or extensions or something like that and move all current modules there. After moving folder structure will be like this:

/admin
/core
/modules
/modules/in-auction
/modules/in-bulletin
/modules/in-commerce
/modules/in-link
/modules/in-news
/modules/custom
/system
/themes
/tools

Then we scan only "core" and "modules" folder for possible unit configs and installator only will search for modules inside "modules" subfolder. For upgrade we will scan for "core" folder too, because it contains upgrade scripts for In-Portal main module.

As of existing users, who have old folder structure we will post a upgrade notice, that following folders (list of all possible modules) should be moved to "modules" subfolder before performing upgrade.
Steps To Reproduce:
Additional Information:
Relationships
parent of 0000664closed  (5.1.0) In-Portal CMS Don't ask user to make "themes/" folder writable upon installation 
parent of 0000766closed  (5.1.0)alex In-Commerce Incorrect paths for In-Commerce & In-Auction gateway scripts 
parent of 0000781closed  (5.1.0)alex In-Portal CMS Upgrade from 5.1.0-B2 to 5.1.0-RC1 fails 
Attached Files: patch move_modules_inside_separate_folder_other_modules_fix.patch (7,206) 2010-01-13 12:57
http://tracker.in-portal.org/file_download.php?file_id=220&type=bug
patch move_modules_inside_separate_folder_core_fix.patch (19,852) 2010-01-13 12:57
http://tracker.in-portal.org/file_download.php?file_id=221&type=bug
patch move_modules_inside_separate_folder_core_fix_part2.patch (770) 2010-01-13 13:21
http://tracker.in-portal.org/file_download.php?file_id=222&type=bug
patch move_modules_inside_separate_folder_other_modules_fix_part2.patch (9,218) 2010-01-13 13:22
http://tracker.in-portal.org/file_download.php?file_id=223&type=bug
patch move_modules_inside_separate_folder_other_modules_fix_part3.patch (3,085) 2010-03-02 14:38
http://tracker.in-portal.org/file_download.php?file_id=321&type=bug
patch move_modules_inside_separate_folder_core_fix_part3.patch (6,244) 2010-03-10 04:44
http://tracker.in-portal.org/file_download.php?file_id=334&type=bug
patch move_modules_inside_separate_folder_other_modules_fix_part4.patch (3,920) 2010-03-10 04:45
http://tracker.in-portal.org/file_download.php?file_id=335&type=bug
patch category_item_import_export_fix.patch (2,206) 2010-03-11 12:58
http://tracker.in-portal.org/file_download.php?file_id=341&type=bug
patch category_item_import_export_fix_part2.patch (1,654) 2010-03-11 13:11
http://tracker.in-portal.org/file_download.php?file_id=342&type=bug
patch modules_missing_on_upgrade_fix.patch (3,407) 2010-04-10 07:09
http://tracker.in-portal.org/file_download.php?file_id=448&type=bug
patch incorrect_version_during_upgrade.patch (927) 2010-04-11 07:55
http://tracker.in-portal.org/file_download.php?file_id=454&type=bug
jpg Fatal-when-editing-Catalog-Item.jpg (167,220) 2010-04-25 17:03
http://tracker.in-portal.org/file_download.php?file_id=479&type=bug
jpg

patch broken_link_in_catalog_grid.patch (635) 2010-04-27 08:17
http://tracker.in-portal.org/file_download.php?file_id=489&type=bug
Issue History
Date Modified Username Field Change
2010-07-22 15:06 alex Note Added: 0002551
2010-07-22 15:06 alex Status resolved => closed
2010-06-17 14:32 alex Relationship added parent of 0000781
2010-06-08 22:45 Dmitry Relationship added parent of 0000766
2010-05-10 14:29 alex Relationship added parent of 0000664
2010-04-27 09:04 Dmitry Status reviewed and tested => resolved
2010-04-27 09:04 Dmitry Resolution reopened => fixed
2010-04-27 09:03 Dmitry Note Added: 0001973
2010-04-27 09:03 Dmitry Status needs testing => reviewed and tested
2010-04-27 08:18 alex Note Edited: 0001971 bug_revision_view_page.php?bugnote_id=0001971#r461
2010-04-27 08:17 alex Note Added: 0001971
2010-04-27 08:17 alex Assigned To alex => !COMMUNITY
2010-04-27 08:17 alex Status needs work => needs testing
2010-04-27 08:17 alex File Added: broken_link_in_catalog_grid.patch
2010-04-27 08:17 alex Changeset attached 5.1.x r13437
2010-04-27 07:29 Dmitry Note Edited: 0001933 bug_revision_view_page.php?bugnote_id=0001933#r459
2010-04-25 17:04 Dmitry Change Log Message => All Modules moved under "modules/" folder
2010-04-25 17:03 Dmitry File Added: Fatal-when-editing-Catalog-Item.jpg
2010-04-25 17:02 Dmitry Status needs feedback => needs work
2010-04-25 17:02 Dmitry Assigned To !COMMUNITY => alex
2010-04-25 17:02 Dmitry Note Added: 0001933
2010-04-25 17:02 Dmitry Status resolved => needs feedback
2010-04-25 17:02 Dmitry Resolution fixed => reopened
2010-04-11 07:58 alex Changeset attached 5.1.x r13369
2010-04-11 07:57 alex Note Added: 0001843
2010-04-11 07:55 alex File Added: incorrect_version_during_upgrade.patch
2010-04-10 07:13 alex Status reviewed and tested => resolved
2010-04-10 07:13 alex Resolution reopened => fixed
2010-04-10 07:12 alex Changeset attached 5.1.x r13367
2010-04-10 07:11 alex Note Added: 0001839
2010-04-10 07:09 alex File Added: modules_missing_on_upgrade_fix.patch
2010-04-06 22:12 Dmitry Note Added: 0001831
2010-04-06 22:12 Dmitry Status needs testing => reviewed and tested
2010-03-11 13:14 alex Changeset attached 5.1.x r13205
2010-03-11 13:13 alex Note Added: 0001565
2010-03-11 13:11 alex File Added: category_item_import_export_fix_part2.patch
2010-03-11 13:00 alex Changeset attached 5.1.x r13204
2010-03-11 12:59 alex Note Added: 0001564
2010-03-11 12:58 alex File Added: category_item_import_export_fix.patch
2010-03-10 04:46 alex Note Added: 0001534
2010-03-10 04:45 alex File Added: move_modules_inside_separate_folder_other_modules_fix_part4.patch
2010-03-10 04:44 alex File Added: move_modules_inside_separate_folder_core_fix_part3.patch
2010-03-10 04:44 alex Changeset attached 5.1.x r13197
2010-03-10 04:44 alex Changeset attached 5.1.x r13196
2010-03-10 04:43 alex Changeset attached 5.1.x r13195
2010-03-10 04:43 alex Changeset attached 5.1.x r13194
2010-03-10 04:43 alex Changeset attached 5.1.x r13193
2010-03-10 04:39 alex Changeset attached 1.1.x r13190
2010-03-10 04:37 alex Changeset attached 5.1.x r13189
2010-03-02 14:41 alex Changeset attached 5.1.x r13179
2010-03-02 14:40 alex Changeset attached 5.1.x r13178
2010-03-02 14:40 alex Changeset attached 5.1.x r13177
2010-03-02 14:40 alex Changeset attached 5.1.x r13176
2010-03-02 14:40 alex Changeset attached 5.1.x r13175
2010-03-02 14:40 alex Changeset attached 1.1.x r13174
2010-03-02 14:39 alex Note Added: 0001510
2010-03-02 14:39 alex Assigned To alex => !COMMUNITY
2010-03-02 14:39 alex Status needs feedback => needs testing
2010-03-02 14:38 alex File Added: move_modules_inside_separate_folder_other_modules_fix_part3.patch
2010-03-01 14:58 Dmitry Note Added: 0001501
2010-03-01 14:58 Dmitry Status resolved => needs feedback
2010-03-01 14:58 Dmitry Resolution fixed => reopened
2010-02-27 05:02 alex Developer => alex
2010-01-16 06:52 alex Changeset attached 5.1.x r13128
2010-01-13 13:26 alex Fixed in Version 5.1.0 => 5.1.0-B1
2010-01-13 13:23 alex Changeset attached 5.1.x r13120
2010-01-13 13:23 alex Changeset attached 5.1.x r13119
2010-01-13 13:22 alex Changeset attached 5.1.x r13118
2010-01-13 13:22 alex Changeset attached 5.1.x r13117
2010-01-13 13:22 alex Changeset attached 5.1.x r13116
2010-01-13 13:22 alex Changeset attached 1.1.x r13115
2010-01-13 13:22 alex Changeset attached 5.1.x r13114
2010-01-13 13:22 alex File Added: move_modules_inside_separate_folder_other_modules_fix_part2.patch
2010-01-13 13:21 alex File Added: move_modules_inside_separate_folder_core_fix_part2.patch
2010-01-13 13:00 alex Issue Monitored: Dmitry
2010-01-13 13:00 alex Note Added: 0001413
2010-01-13 13:00 alex Changeset attached 5.1.x r13113
2010-01-13 13:00 alex Note Added: 0001412
2010-01-13 13:00 alex Status needs testing => resolved
2010-01-13 13:00 alex Fixed in Version => 5.1.0
2010-01-13 13:00 alex Resolution open => fixed
2010-01-13 13:00 alex Assigned To !COMMUNITY => alex
2010-01-13 12:59 alex Changeset attached 5.1.x r13112
2010-01-13 12:59 alex Changeset attached 5.1.x r13111
2010-01-13 12:59 alex Changeset attached 5.1.x r13110
2010-01-13 12:59 alex Changeset attached 5.1.x r13109
2010-01-13 12:58 alex Changeset attached 5.1.x r13108
2010-01-13 12:58 alex Changeset attached 1.1.x r13107
2010-01-13 12:58 alex Time Estimate Removed 4 =>
2010-01-13 12:58 alex Assigned To => !COMMUNITY
2010-01-13 12:58 alex Status active => needs testing
2010-01-13 12:57 alex File Added: move_modules_inside_separate_folder_core_fix.patch
2010-01-13 12:57 alex File Added: move_modules_inside_separate_folder_other_modules_fix.patch
2010-01-13 08:21 alex Changeset attached 5.1.x r13102
2010-01-12 11:56 alex Time Estimate Added 4
2010-01-12 11:56 alex Target Version Icebox => 5.1.0
2009-10-08 11:44 Dmitry Note Added: 0000834
2009-10-07 06:19 alex Target Version => Icebox
2009-10-07 06:19 alex New Issue

Notes
(0000834)
Dmitry   
2009-10-08 11:44   
I support this idea - there are many advantages in this approach.
(0001412)
alex   
2010-01-13 13:00   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000362: We should move all module folders to new "modules" subfolder
(0001413)
alex   
2010-01-13 13:00   
Reminder sent to: Dmitry

Already commited, since "svn:externals" property of all 3 profiles was changed. Please test.
(0001501)
Dmitry   
2010-03-01 14:58   
During fresh install of 5.1.0 on Choose Modules step all module Icons are broken (incorrect path).
(0001510)
alex   
2010-03-02 14:39   
Patch "move_modules_inside_separate_folder_other_modules_fix_part3.patch" fixes what you've found. I've already commited fix, because all other code related to this task is commited already.
(0001534)
alex   
2010-03-10 04:46   
Patches "move_modules_inside_separate_folder_core_fix_part3.patch" and "move_modules_inside_separate_folder_other_modules_fix_part4.patch" are already commited and they fix the following issues (strange, that they weren't noticed during first testing stage):

1. prerequisites were not checked during installation
2. all modules were having 5.0.0 version on installation instead of actual version
3. not installed modules also were having 5.0.0 version on modules list in administrative console
4. prerequisites were not checked on modules list in administrative console
(0001564)
alex   
2010-03-11 12:59   
Patch "category_item_import_export_fix.patch" fixes missing template error on category item import/export screens (module path was used instead of it's lowercased name).
(0001565)
alex   
2010-03-11 13:13   
Patch "category_item_import_export_fix_part2.patch" fixes same error on import progress dialog and on export finish screens.
(0001831)
Dmitry   
2010-04-06 22:12   
Tested in multiple cases and good so far!
(0001839)
alex   
2010-04-10 07:11   
It seems, that upgrade were not tested at all since I've found several problems with that, that are fixed by "modules_missing_on_upgrade_fix.patch" patch (already commited):

1. module icon was missing for "Core" module during upgrade to 5.1.0 version
2. all modules except for "Core" were not visible on upgrade modules screen
(0001843)
alex   
2010-04-11 07:57   
Patch "incorrect_version_during_upgrade.patch" (commited) fixes problem, that after upgrade from 5.0.3-B2 to 5.1.0-B1 all modules are marked with 5.0.0 version instead of 5.1.0-B1 version.
(0001933)
Dmitry   
2010-04-25 17:02   
(edited on: 2010-04-27 07:29)
Can't Edit Catalog Item on Show All (add works okay) - see screenshot.
(0001971)
alex   
2010-04-27 08:17   
(edited on: 2010-04-27 08:18)
Fixed, please test.

Patch "broken_link_in_catalog_grid.patch" (already commited) fixes broken link on category item name in catalog and comments grid.
(0001973)
Dmitry   
2010-04-27 09:03   
Tested good.
(0002551)
alex   
2010-07-22 15:06   
Closing, since 5.1.0 release has been released.