Notes |
|
(0000828)
|
Dmitry
|
2009-10-06 16:41
|
|
Agreed, but 2 notes:
1. I think we should do this for all Sections NOT only the ones that marked as IsMenu since can foresee cases when I have something hidden from the Menu, but still need to refer to correct Section / URL.
2. We should make additional parameter available which will allow to by pass/exclude from build URL to the template using that mapping instead will do as before. This might be helpful for the future.
Both things are more like improvements to proposed functionality.
Please move forward with this development. |
|
|
(0000830)
|
alex
|
2009-10-08 07:38
|
|
Here is one more idea: when number is given instead of template name, then use structure page url as template name and also pass this number as m_cat_id to link building system.
This will solve the cases, when we need to address specific virtual page in some processing code, like events or tags, but we don't want all this to crash, when client renames that virtual page (because ID will stay the same anyway). |
|
|
(0000832)
|
Dmitry
|
2009-10-08 11:40
|
|
Yes, this is a good point.
Let's just cover up the case when Template can be the ID what id we pass as @@ID@@ format - same as we do in Content Blocks for path building?
Back to you for the feedback. |
|
|
(0000839)
|
alex
|
2009-10-08 14:06
|
|
Ups, did that in "id:ID" format really before you suggested @@ID@@ format. |
|
|
(0000845)
|
Dmitry
|
2009-10-08 14:40
|
|
Is it hard to change so we can actually test this in multiple scenarios.
Also it would help if you list some basic cases for the test please (especially with passing Events) |
|
|
(0000846)
|
alex
|
2009-10-08 15:02
|
|
Test Case (need to create templates mentioned here by hand):
1. we have physical template "sample/file" ("file.tpl" in "sample" folder in theme root)
2. test, that it's accessible by it's physical location: http://www.site.com/sample/file.html
3. Rebuild theme files and place this template under "directory" subfolder (it now has structure path as "directory/file".
4. Test, that it is accessible by it's structure url, like: http://www.site.com/directory/file.html
5. Rename structure page corresponding to "file.tpl" template to "Other file".
6. Test, that it is accessible by it's new structure url, like: http://www.site.com/directory/other_file.html
7. In any theme file, e.g. index.tpl build link to this page:
<inp2:m_Link template="sample/file"/> - work
<inp2:m_Link template="directory/file"/> - don't work
<inp2:m_Link template="directory/other_file"/> - work
<inp2:m_Link template="id:#ID#"/> - work (replace #ID# with page id)
First links, that work should be identical no matter what template name is given to tag.
|
|
|
(0000853)
|
Dmitry
|
2009-10-08 17:57
|
|
Can't Apply the patch against latest SVN version.
There was 1 related Commit which can affect this.
Please check. |
|
|
(0000865)
|
alex
|
2009-10-09 05:17
|
|
Of course it's impossible to apply patch against latest SVN version, because it's changed since patch was created. You can only apply patch to SVN version based on what it was created. There are two ways to solve the problem:
Way #1
------
There are revision numbers in patch file near each filename to be patched. You can update your working copy to one (maybe largest number) of them and apply patch then. Then, when some files were changed/created merge these changes to other in-portal installation, which should updated to HEAD branch, not individual revision, where patch was applied.
Way #2
------
Same as way #1, except of that as source project for applying patch you choose last released branch.
-----
Maybe we should write such rule, that patch should be created against svn version, which was used for reporting task (see "Product Version" field). For now I create patches from "5.0.x" branch and continue developing in it, that's why patches, that changes same files can't be applied without problems. |
|
|
(0000928)
|
Dmitry
|
2009-10-18 03:23
|
|
|
|
(0000994)
|
Dmitry
|
2009-10-26 17:11
|
|
Issues with Current solution. Let's hold off on applying new method automatically on ALL URLs in In-Portal 5.0.2
================
We came across some major issues with building and parsing URLs using new method.
More specifically there are situations when new URL consist of 2 sections:
NOW with Patch:
Section (category) and Section-Page (section in the structure, design already assigned to the structure)
BEFORE
Section (category) and Template (physical template)
As you can see the problem is that we aren't able to properly parse and gather the Design template from the Section.
=============
For now it was decided to pass a new use_section="1" parameter to m_Link and similar URL build tags (HREF method) that will apply new functionality and include it in 5.0.2
Please update and attach a new patch here.
|
|
|
(0001005)
|
Dmitry
|
2009-10-28 00:36
(edited on: 2009-10-28 01:18) |
|
Tested and there is problem - with System sections in CachedMenu
Example is here -- http://simone1.intechnic.com/dev/SVN/5.0.x/index.html
Click on Privacy Policy in top menu, I get
http://simone1.intechnic.com/dev/SVN/5.0.x/privacy:1.html
Also, could you please describe how "external" forward works/operated now?
|
|
|
(0001043)
|
alex
|
2009-11-03 14:05
|
|
1. Issue with "http://simone1.intechnic.com/dev/SVN/5.0.x/privacy:1.html" url in menu fixed (use_section="$use_section" should be now used in links for blocks, that are used by st_CachedMenu tag and it's fixed for current themes inside this patch).
2. External works this way:
You edit any section and check "Use External Url" checkbox. Additional field with url appears. If url starts with a protocol, like "http://" or any other protocol, e.g. "ftp://", then link to such category (when used in menu) will be given link. When url doesn't start with protocol, then base url of site is applied before entered url and result is used for links in menu. This works with mod-rewrite on and off.
For now links build by c_CategoryLink doesn't support external links, because it will require additional query to match given category id to external url (if any) and I don't see any direct application for it today.
In case, if link is made to physical template with use_section="1" parameter, then, when corresponding physical template category have external url, then it will be used. That's kind of side effect, because why physical template should link to other site. |
|
|
(0001044)
|
alex
|
2009-11-03 14:10
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000359: Two different urls will lead to same physical template on Front-End |
|
|
(0001045)
|
alex
|
2009-11-03 14:13
|
|
Reminder sent to: Dmitry This is largest patch among ones I've attached throughout the mantis, and based on your ability to quickly change the theme templates I'm afraid, that it will be really hard to apply it after testing. Also because it's 4th version of this patch, then this time it should definitely work and I've already commited it to SVN.
Also be sure to test, that require login and no permission redirects are made using full url now, because this patch also implements this. |
|
|
(0001112)
|
alex
|
2009-11-13 12:57
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000359: Two different urls will lead to same physical template on Front-End |
|
|
(0001116)
|
alex
|
2009-11-13 12:59
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000359: Two different urls will lead to same physical template on Front-End |
|
|
(0001125)
|
alex
|
2009-11-13 13:06
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000359: Two different urls will lead to same physical template on Front-End |
|
|
(0001129)
|
alex
|
2009-11-13 13:34
|
|
This task was resolved multiple times, because of themes were moved into separate modules. I will revert issue status and fixed in version fields back to normal manually. |
|
|
(0001327)
|
Dmitry
|
2010-01-11 22:05
|
|
|