In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
357 [In-Portal CMS] Data Management bug report always 2009-10-06 05:48 2010-07-22 15:07
alex  
alex  
normal  
closed 5.0.1  
fixed  
 
none 5.1.0  
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/5fe6f07765659682
0
0000357: Form modification detector (it's php part) works strange
When I open link (in catalog) for editing and click on "General" tab without changing anything, then message "Modifications will not take effect until you click the Save button!" is shown, but I didn't change a thing.

It is possible, that something I don't see on form was changed, but then such fields shouldn't cause such warning message to appear.

It's possible, that other forms also have same behavior.
We have field named "Modified" in certain tables (including category items), that holds last modification date of and database record. There are several problems in current implementation:

    * field is updated no matter was something changed or not;
    * field is always updated no matter what user have entered on editing template.

I propose to fix that by:

    * check that other fields (except that Modified) field were changed before changing it
    * make Modified field on editing form as label, since user entered value will be always ignored.

Same about ModifiedById field around the system.
related to 0000580closed  (5.1.1)Dmitry In-Portal CMS Issues with change log section 
parent of 0000910closed  (5.1.1)alex In-Link Fatal error when Modifying Pending Link on Front-end 
related to 0000581closed  (5.0.4)alex In-Commerce Wrong calculation of HasRequiredOptions field resulting additional change log record 
child of 0000107closed  (5.1.0)alex In-Portal CMS Implement "MemCached" functionality 
patch form_modification_detector_part1.patch (2,848) 2010-03-02 08:36
http://tracker.in-portal.org/file_download.php?file_id=310&type=bug
patch modification_detector_core.patch (3,851) 2010-05-26 04:16
http://tracker.in-portal.org/file_download.php?file_id=597&type=bug
patch modification_detector_modules.patch (7,357) 2010-05-26 04:16
http://tracker.in-portal.org/file_download.php?file_id=598&type=bug
Issue History
2010-10-31 08:19 alex Relationship added parent of 0000910
2010-07-22 15:07 alex Note Added: 0002577
2010-07-22 15:07 alex Status resolved => closed
2010-07-07 04:41 alex Note Added: 0002485
2010-07-07 04:41 alex Status reviewed and tested => resolved
2010-07-07 04:41 alex Fixed in Version => 5.1.0
2010-07-07 04:41 alex Resolution open => fixed
2010-07-07 04:41 alex Changeset attached 5.1.x r13811
2010-07-07 04:38 alex Changeset attached 5.1.x r13810
2010-07-07 04:37 alex Changeset attached 5.1.x r13809
2010-07-07 03:57 alex Target Version Icebox => 5.1.0
2010-05-30 22:28 Dmitry Note Edited: 0002341 bug_revision_view_page.php?bugnote_id=0002341#r504
2010-05-30 22:28 Dmitry Note Added: 0002341
2010-05-30 22:28 Dmitry Assigned To !COMMUNITY => alex
2010-05-30 22:28 Dmitry Status needs testing => reviewed and tested
2010-05-26 04:17 alex Note Added: 0002323
2010-05-26 04:17 alex Assigned To => !COMMUNITY
2010-05-26 04:17 alex Developer => alex
2010-05-26 04:17 alex Status active => needs testing
2010-05-26 04:16 alex File Added: modification_detector_modules.patch
2010-05-26 04:16 alex File Added: modification_detector_core.patch
2010-05-26 03:50 alex Relationship added related to 0000581
2010-05-10 14:50 alex Target Version 5.0.4 => Icebox
2010-05-10 14:33 alex Relationship added related to 0000580
2010-03-14 14:17 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/5fe6f07765659682
2010-03-14 14:16 alex Additional Information Updated bug_revision_view_page.php?rev_id=405#r405
2010-03-02 08:37 alex Note Added: 0001502
2010-03-02 08:36 alex File Added: form_modification_detector_part1.patch
2010-02-24 11:58 alex Note Added: 0001487
2010-02-24 11:58 alex Target Version 5.1.0 => 5.0.4
2010-02-11 14:34 alex Relationship added child of 0000107
2010-02-11 14:33 alex Note Added: 0001476
2010-02-11 14:33 alex Target Version 5.0.3 => 5.1.0
2010-01-06 06:25 alex Target Version Icebox => 5.0.3
2009-10-06 05:48 alex Target Version => Icebox
2009-10-06 05:48 alex New Issue

Notes
(0001476)
alex   
2010-02-11 14:33   
Moving to 5.1.0, because this will be implemented to use in memcache functionality.
(0001487)
alex   
2010-02-24 11:58   
After all this task wasn't involved in memcache task, so move it back.
(0001502)
alex   
2010-03-02 08:37   
Patch "form_modification_detector_part1.patch" is for categories and category items only. All other unit configs should be also scanned to complete this task.
(0002323)
alex   
2010-05-26 04:17   
Latest 2 patches are ones to be tested.

Also apply patch from 0000581 task before starting testing.
(0002341)
Dmitry   
2010-05-30 22:28   
Tested good. Please commit to 5.1.0.

I believe no reason to push this back since 5.2.0 will be converting to PHP5.

(0002485)
alex   
2010-07-07 04:41   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000357: Form modification detector (it's php part) works strange
(0002577)
alex   
2010-07-22 15:07   
Closing, since 5.1.0 release has been released.