|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
306 |
[In-Portal CMS] Template System |
bug report |
always |
2009-09-18 03:24 |
2010-01-11 22:05 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.0.0 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.0.2 |
|
|
Reference:
|
|
|
Change Log Message:
|
|
|
Estimate Points:
|
0 |
|
|
Summary:
|
0000306: Parameter "result_to_var" doesn't work for m_Param tag |
|
Description:
|
Parameter "result_to_var" allows to store tag result into parser parameter name, that is specified. It doesn't work for this code:
<inp2:m_Capture to_var="test">
data
</inp2:m_Capture>
<inp2:m_Param name="test" result_to_var="other"/>
Parameter "other" will be empty, but should contain "data" as it's value. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
Problem is hidden in "result_to_var" parameter implementation code. There are two places, where this parameter is processed:
* compiled template code
* PostProcess method of TagProcessor class
1. for non-pair tags this parameter is processed in both places
2. for pair tags this parameter is processed on in 2nd place (PostProcess method).
PostProcess method set's tag result to parser parameter on current deep level. That raises a problem, when deep level is changed after that. For example: all pair tags change deep level and they automatically loose parameter value, when deep level is restored.
I propose, that we should move all "result_to_var" parameter processing into compiled template code to avoid such problem in future.
=====================
In case if we comment-out "result_to_var" processing in PostProcess method, then there is fatal error about missing "_TagProcessor" in all grids in administrative console. |
| Relationships | |
|
Attached Files:
|
 result_to_var fix in parser.patch (4,741) 2009-10-11 09:35
http://tracker.in-portal.org/file_download.php?file_id=97&type=bug
 test.tpl (3,294) 2009-10-11 09:35
http://tracker.in-portal.org/file_download.php?file_id=98&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2010-01-11 22:05 |
Dmitry |
Note Added: 0001374 |
|
|
2010-01-11 22:05 |
Dmitry |
Status |
resolved => closed |
|
2009-10-20 03:55 |
alex |
Note Added: 0000930 |
|
|
2009-10-20 03:55 |
alex |
Status |
reviewed and tested => resolved |
|
2009-10-20 03:55 |
alex |
Fixed in Version |
=> 5.0.2 |
|
2009-10-20 03:55 |
alex |
Resolution |
open => fixed |
|
2009-10-20 03:55 |
alex |
Changeset attached |
5.0.x r12704 |
|
2009-10-18 02:18 |
Dmitry |
Note Added: 0000914 |
|
|
2009-10-18 02:18 |
Dmitry |
Assigned To |
!COMMUNITY => alex |
|
2009-10-18 02:18 |
Dmitry |
Status |
needs testing => reviewed and tested |
|
2009-10-11 09:39 |
alex |
Time Estimate Removed |
2 => |
|
2009-10-11 09:39 |
alex |
Note Added: 0000876 |
|
|
2009-10-11 09:39 |
alex |
Assigned To |
alex => !COMMUNITY |
|
2009-10-11 09:39 |
alex |
Status |
active => needs testing |
|
2009-10-11 09:35 |
alex |
File Added: test.tpl |
|
|
2009-10-11 09:35 |
alex |
File Added: result_to_var fix in parser.patch |
|
|
2009-10-03 07:53 |
administrator |
Status |
reviewed and tested => active |
|
2009-09-23 13:25 |
alex |
Time Estimate Added |
2 |
|
2009-09-21 11:35 |
Dmitry |
Note Added: 0000500 |
|
|
2009-09-21 11:35 |
Dmitry |
Assigned To |
Dmitry => alex |
|
2009-09-21 11:35 |
Dmitry |
Status |
needs work => reviewed and tested |
|
2009-09-21 03:20 |
alex |
Target Version |
=> 5.0.2 |
|
2009-09-18 16:55 |
alex |
Note Added: 0000483 |
|
|
2009-09-18 16:55 |
alex |
Assigned To |
alex => Dmitry |
|
2009-09-18 16:55 |
alex |
Status |
needs feedback => needs work |
|
2009-09-18 11:11 |
Dmitry |
Note Added: 0000481 |
|
|
2009-09-18 11:11 |
Dmitry |
Assigned To |
=> alex |
|
2009-09-18 11:11 |
Dmitry |
Status |
active => needs feedback |
|
2009-09-18 07:53 |
alex |
Additional Information Updated |
bug_revision_view_page.php?rev_id=232#r232 |
|
2009-09-18 03:24 |
alex |
New Issue |
|
|
Notes |
|
|
(0000481)
|
|
Dmitry
|
|
2009-09-18 11:11
|
|
|
How much development time we need here? |
|
|
|
(0000483)
|
|
alex
|
|
2009-09-18 16:55
|
|
|
|
|
(0000500)
|
|
Dmitry
|
|
2009-09-21 11:35
|
|
|
Ok, I think we need to address this in 5.0.2 |
|
|
|
(0000876)
|
|
alex
|
|
2009-10-11 09:39
|
|
Fixed, for testing place "test.tpl" (attached) into root of front-end theme and go see it in browser by url: http://www.site.com/?t=test.
There are 10 tests and among them:
9 pass in after patch is applied
3 pass before patch is applied
1 (last one) fail in any case (see test.tpl for details)
Also I've discovered problem, that "plus" parameter (of m_Param tag) was applied to original parameter instead of one, specified in result_to_var parameter (when used).
Please compare results before/after patch was applied and see test.tpl to ensure, that what you see as result is the one you expect from tags used.
|
|
|
|
(0000914)
|
|
Dmitry
|
|
2009-10-18 02:18
|
|
|
Seems to be working good. |
|
|
|
(0000930)
|
|
alex
|
|
2009-10-20 03:55
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000306: Parameter "result_to_var" doesn't work for m_Param tag |
|
|
|
(0001374)
|
|
Dmitry
|
|
2010-01-11 22:05
|
|
|