In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
284 [In-Portal CMS] Security bug report always 2009-09-13 08:33 2011-03-30 09:53
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.1.2-B1  
Reference: https://groups.google.com/d/topic/in-portal-dev/Fy4bvP4pNFg/discussion
Change Log Message: Implemented original User Ban rules
Estimate Points: 0
Summary: 0000284: Only 1 of 5 ban rule types is implemented
Description: Currently there is only 1 of 5 ban rule types implemented. This way after upgrade for users, who use other ban rule types they won't be working.
Steps To Reproduce:
Additional Information:
Relationships
Attached Files: patch Implement-additional-UserBan-rules-CORE.patch (6,022) 2011-01-03 13:31
http://tracker.in-portal.org/file_download.php?file_id=893&type=bug
patch Implement-additional-UserBan-rules-CORE_v2.patch (11,239) 2011-01-05 04:14
http://tracker.in-portal.org/file_download.php?file_id=903&type=bug
Issue History
Date Modified Username Field Change
2011-03-30 09:53 Dmitry Note Added: 0003369
2011-03-30 09:53 Dmitry Status resolved => closed
2011-01-05 04:16 alex Changeset attached 5.1.x r14106
2011-01-05 04:16 alex Note Added: 0003135
2011-01-05 04:16 alex Status reviewed and tested => resolved
2011-01-05 04:16 alex Fixed in Version => 5.1.2-B1
2011-01-05 04:16 alex Resolution open => fixed
2011-01-05 04:16 alex Assigned To !COMMUNITY => alex
2011-01-05 04:14 alex File Added: Implement-additional-UserBan-rules-CORE_v2.patch
2011-01-05 04:13 alex Note Added: 0003134
2011-01-05 04:13 alex Status needs testing => reviewed and tested
2011-01-03 13:40 Dmitry Reference => https://groups.google.com/d/topic/in-portal-dev/Fy4bvP4pNFg/discussion
2011-01-03 13:40 Dmitry Change Log Message => Implemented original User Ban rules
2011-01-03 13:32 Dmitry Time Estimate Removed 2 =>
2011-01-03 13:32 Dmitry Assigned To Dmitry => !COMMUNITY
2011-01-03 13:32 Dmitry Status needs work => needs testing
2011-01-03 13:31 Dmitry File Added: Implement-additional-UserBan-rules-CORE.patch
2010-09-28 14:02 Dmitry Assigned To => Dmitry
2010-09-28 14:02 Dmitry Status active => needs work
2010-09-28 13:59 Dmitry Fixed in Version 5.1.2 =>
2010-09-28 13:59 Dmitry Target Version Icebox => 5.1.2
2010-09-28 13:33 Dmitry Developer => Dmitry
2010-09-28 13:33 Dmitry Fixed in Version => 5.1.2
2010-05-18 14:00 Dmitry Status needs work => active
2010-05-18 14:00 Dmitry Assigned To alex =>
2010-05-18 14:00 Dmitry Note Added: 0002237
2010-05-18 14:00 Dmitry Target Version 5.1.0 => Icebox
2010-05-17 17:50 Dmitry Note Added: 0002220
2010-05-17 17:49 Dmitry Assigned To Dmitry => alex
2010-01-12 11:33 alex Time Estimate Added 2
2010-01-12 11:33 alex Status active => needs work
2009-10-03 07:52 administrator Status reviewed and tested => active
2009-10-02 09:54 Dmitry Assigned To => Dmitry
2009-10-02 09:53 Dmitry Assigned To Dmitry =>
2009-10-02 09:53 Dmitry Status needs work => reviewed and tested
2009-10-02 09:52 Dmitry Target Version 5.0.2 => 5.1.0
2009-10-02 09:52 Dmitry Note Added: 0000601
2009-10-02 03:28 alex Note Added: 0000600
2009-10-02 03:28 alex Assigned To alex => Dmitry
2009-10-02 03:28 alex Status needs feedback => needs work
2009-10-02 01:24 Dmitry Time Estimate Removed 1 =>
2009-10-02 01:24 Dmitry Status reviewed and tested => needs feedback
2009-09-30 06:59 alex Assigned To andrew => alex
2009-09-30 06:58 alex Status active => reviewed and tested
2009-09-30 06:58 alex Assigned To => andrew
2009-09-30 00:00 Dmitry Note Added: 0000593
2009-09-23 12:50 alex Time Estimate Added 1
2009-09-23 12:50 alex Note Added: 0000519
2009-09-13 15:03 Dmitry Note Added: 0000431
2009-09-13 15:03 Dmitry Target Version => 5.0.2
2009-09-13 08:33 alex New Issue

Notes
(0000431)
Dmitry   
2009-09-13 15:03   
Need to carefully review all options and submit proposals for implementation.
(0000519)
alex   
2009-09-23 12:50   
Actually this all was already implemented in old In-Portal code, so I just get all implementation from there and adapt it to be used in K4 environment.
(0000593)
Dmitry   
2009-09-30 00:00   
Reminder sent to: alex

I propose we move this into Features release In-Portal 5.1.0 for the time being.
(0000600)
alex   
2009-10-02 03:28   
I agree.
(0000601)
Dmitry   
2009-10-02 09:52   
Moving to the Features release (In-Portal 5.1.0) - this item is not critical now.
(0002220)
Dmitry   
2010-05-17 17:50   
Hi Alex,


If you don't mind taking this task I would appreciate it. If you thing it should be moved to 5.2.0 - it's okay too.


Thanks.
(0002237)
Dmitry   
2010-05-18 14:00   
Moving task to the Future release due to low priority.
(0003134)
alex   
2011-01-05 04:13   
Ok, but:
1. database queries were not properly formatted

--------

Additionally I did:
1. changed ban form to be more user friendly (empty value in dropdowns, fields made required and so on)
2. when user is initially banned from user registration form or in admin, then no error was shown, but "errors on form" message was still displayed.
(0003135)
alex   
2011-01-05 04:16   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000284: Only 1 of 5 ban rule types is implemented
Commit on behalf of Dmitry
(0003369)
Dmitry   
2011-03-30 09:53   
Closing, since 5.1.2 release has been released.