|
Notes |
|
|
(0000400)
|
|
alex
|
|
2009-09-05 09:13
|
|
|
There are still some places left with more complex regular expressions in kDateFormatter and other classes. |
|
|
|
(0000401)
|
|
Dmitry
|
|
2009-09-05 16:31
|
|
|
Which Release we are doing this for? 5.0.1 or 5.1.0? |
|
|
|
(0000406)
|
|
alex
|
|
2009-09-07 01:23
|
|
|
For now it's partially done for 5.0.x and what's done is merged to 5.1.x as you can see by commit log bellow. |
|
|
|
(0000532)
|
|
alex
|
|
2009-09-23 13:18
|
|
Plan:
1. only left in order credit card and payment gateway response processing and in some places in fck editor. |
|
|
|
(0000826)
|
|
alex
|
|
2009-10-06 13:58
|
|
|
Moving to 5.0.3 because of too much work. Also much of this is already done already. |
|
|
|
(0001478)
|
|
Dmitry
|
|
2010-02-11 19:12
|
|
Patches attached - please review and test.
There might be some changes needed to regex - let me know. |
|
|
|
(0001550)
|
|
alex
|
2010-03-11 05:13
(edited on: 2010-03-11 05:48) |
|
Core patch for fck doesn't work, since you missed "(" and ")" while moving file extension regexp to constant. You should remove "$" from regexp and use it like (contant)$ where that contant is used. Verify, that you see proper file icons in fck file manager, since I'm seeing default icon for all files now.
In-commerce patch uses "str_ireplace" function which is for PHP5 only and in-commerce payment gateways will stop working on PHP4. Also why are you using case insensitive replace function, when you are replacing "." and ",", since they don't have case at all.
Also why you using "i" and "g" preg_* modifiers with regular expressions that doesn't have case sensitive characters in them. And there is not "g" modifier (see http://lv.php.net/manual/en/reference.pcre.pattern.modifiers.php).
Also you have lost part of regex during conversion to preg function in PhoneClean method.
Also there is special php function file extension detection and we should use regex or additional constants for that.
|
|
|
|
(0001567)
|
|
Dmitry
|
|
2010-03-11 23:46
|
|
|
Reminder sent to: alex
DID you mean:
Also there is special php function file extension detection and we should NOT use regex or additional constants for that?
instead of:
Also there is special php function file extension detection and we should use regex or additional constants for that. |
|
|
|
(0001576)
|
|
alex
|
|
2010-03-12 02:57
|
|
|
That's probably what I meant to say: use special function instead of regex here. |
|
|
|
(0001611)
|
|
Dmitry
|
|
2010-03-15 15:14
|
|
Redone both patches - please test v3 of the patches.
NOTES: in CORE patch there is a very minor fix for Images path in core/admin_templates/browser/frmresourceslist.tpl template |
|
|
|
(0001679)
|
|
alex
|
|
2010-03-17 12:52
|
|
|
|
|
(0001680)
|
|
alex
|
|
2010-03-17 12:54
|
|
Fix committed to 5.0.x branch. Commit Message:
1. Fixes 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
2. Commit on behalf of Dmitry. |
|
|
|
(0002124)
|
|
alex
|
|
2010-05-11 02:59
|
|
|
Closing all tasks from released versions. |
|
273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100211-v1-CORE.patch (2,374) 2010-02-11 16:21