In-Portal Issue Tracker - In-Portal CMS
|
Viewing Issue Advanced Details |
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
26 |
[In-Portal CMS] Optimization |
task |
always |
2009-05-21 07:26 |
2010-01-11 22:05 |
|
Reporter:
|
alex |
Platform:
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
Status:
|
closed |
Product Version:
|
4.3.9 |
|
Product Build:
|
|
Resolution:
|
fixed |
|
|
ETA:
|
none |
Fixed in Version:
|
5.0.2 |
|
Reference:
|
|
Change Log Message:
|
|
Estimate Points:
|
0 |
|
Summary:
|
0000026: Rename "kUploadFormatter::ValidateFileName" method |
Description:
|
Method ValidateFileName of class kUploadFormatter doesn't validate anything, but it actually generates new filename for uploaded file in case, when given filename is already used by other file in same directory.
There are 2 possible solutions:
1. make this method validate filename (returns true/false) and move current method body to new method _generateFileName
2. rename method to _generateFileName, because for now it does only that. |
Steps To Reproduce:
|
|
Additional Information:
|
|
Relationships | |
Attached Files:
|
upload formatter method naming fix.patch (2,524) 2009-10-04 08:22 http://tracker.in-portal.org/file_download.php?file_id=63&type=bug |
|
Issue History |
Date Modified |
Username |
Field |
Change |
2010-01-11 22:05 |
Dmitry |
Note Added: 0001383 |
|
2010-01-11 22:05 |
Dmitry |
Status |
resolved => closed |
2009-10-10 06:36 |
alex |
Note Added: 0000867 |
|
2009-10-10 06:36 |
alex |
Status |
reviewed and tested => resolved |
2009-10-10 06:36 |
alex |
Fixed in Version |
=> 5.0.2 |
2009-10-10 06:36 |
alex |
Resolution |
open => fixed |
2009-10-10 06:36 |
alex |
Changeset attached |
5.0.x r12679 |
2009-10-08 18:16 |
Dmitry |
Note Added: 0000854 |
|
2009-10-08 18:16 |
Dmitry |
Assigned To |
Dmitry => alex |
2009-10-08 18:16 |
Dmitry |
Status |
needs feedback => reviewed and tested |
2009-10-08 14:30 |
alex |
Note Added: 0000843 |
|
2009-10-08 14:30 |
alex |
Assigned To |
alex => Dmitry |
2009-10-08 12:12 |
Dmitry |
Note Added: 0000837 |
|
2009-10-08 12:12 |
Dmitry |
Assigned To |
!COMMUNITY => alex |
2009-10-08 12:12 |
Dmitry |
Status |
needs testing => needs feedback |
2009-10-06 14:25 |
alex |
Type |
bug report => task |
2009-10-04 08:23 |
alex |
Time Estimate Removed |
1 => |
2009-10-04 08:23 |
alex |
Assigned To |
alex => !COMMUNITY |
2009-10-04 08:23 |
alex |
Status |
active => needs testing |
2009-10-04 08:22 |
alex |
File Added: upload formatter method naming fix.patch |
|
2009-10-03 08:01 |
alex |
Assigned To |
=> alex |
2009-09-23 13:31 |
alex |
Time Estimate Added |
1 |
2009-09-20 15:19 |
alex |
Target Version |
5.1.0 => 5.0.2 |
2009-06-07 06:48 |
alex |
Reproducibility |
@70@ => always |
2009-05-25 21:34 |
Dmitry |
version |
5.0.0 => 4.3.9 |
2009-05-25 21:34 |
Dmitry |
Target Version |
=> 5.1.0 |
2009-05-21 07:26 |
alex |
New Issue |
|
Notes |
|
(0000837)
|
Dmitry
|
2009-10-08 12:12
|
|
Please describe how to test. |
|
|
(0000843)
|
alex
|
2009-10-08 14:30
|
|
Task was to rename method, you can check changed code and verify, that method was renamed. |
|
|
(0000854)
|
Dmitry
|
2009-10-08 18:16
|
|
|
|
(0000867)
|
alex
|
2009-10-10 06:36
|
|
Fix committed to 5.0.x branch. Commit Message:
Fixes 0000026: Rename "kUploadFormatter::ValidateFileName" method |
|
|
(0001383)
|
Dmitry
|
2010-01-11 22:05
|
|
|