In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
250 [In-Portal CMS] Optimization task always 2009-08-31 06:53 2010-01-11 22:01
alex  
alex  
normal  
closed 5.0.0  
fixed  
 
none 5.0.2  
0
0000250: Check what "source" parameter of "m_Phrase" tag does
Check what "source" parameter of "m_Phrase" tag does, because based on it's name there is no clue about it.
patch phrase from request.patch (3,688) 2009-10-06 05:34
http://tracker.in-portal.org/file_download.php?file_id=75&type=bug
Issue History
2010-01-11 22:01 Dmitry Note Added: 0001317
2010-01-11 22:01 Dmitry Status resolved => closed
2009-11-13 13:53 alex Fixed in Version => 5.0.2
2009-11-13 12:57 alex Changeset attached 5.0.x r12716
2009-11-13 12:57 alex Note Added: 0001108
2009-11-13 12:57 alex Fixed in Version 5.0.2 =>
2009-10-20 09:26 alex Note Added: 0000935
2009-10-20 09:26 alex Status reviewed and tested => resolved
2009-10-20 09:26 alex Fixed in Version => 5.0.2
2009-10-20 09:26 alex Resolution open => fixed
2009-10-20 09:26 alex Changeset attached 5.0.x r12716
2009-10-17 01:51 Dmitry Note Added: 0000902
2009-10-17 01:51 Dmitry Assigned To Dmitry => alex
2009-10-17 01:51 Dmitry Status needs testing => reviewed and tested
2009-10-09 05:09 alex Note Added: 0000864
2009-10-09 05:09 alex Assigned To alex => Dmitry
2009-10-09 05:09 alex Status needs work => needs testing
2009-10-08 19:12 Dmitry Note Added: 0000861
2009-10-08 19:12 Dmitry Assigned To !COMMUNITY => alex
2009-10-08 19:12 Dmitry Status needs testing => needs work
2009-10-06 14:24 alex Type bug report => task
2009-10-06 05:34 alex Assigned To alex => !COMMUNITY
2009-10-06 05:34 alex Status needs work => needs testing
2009-10-06 05:34 alex File Added: phrase from request.patch
2009-10-06 01:06 Dmitry Note Added: 0000823
2009-10-06 01:06 Dmitry Assigned To Dmitry => alex
2009-10-06 01:06 Dmitry Status needs feedback => needs work
2009-09-29 08:23 alex Time Estimate Removed 1 =>
2009-09-29 08:23 alex Note Added: 0000585
2009-09-29 08:23 alex Assigned To => Dmitry
2009-09-29 08:23 alex Status active => needs feedback
2009-09-23 13:20 alex Time Estimate Added 1
2009-09-23 13:20 alex Note Added: 0000534
2009-09-20 15:21 alex Type feature request => bug report
2009-09-20 15:11 alex Target Version 5.1.0 => 5.0.2
2009-09-01 10:14 Dmitry Type bug report => feature request
2009-09-01 10:14 Dmitry Target Version => 5.1.0
2009-08-31 06:53 alex New Issue

Notes
(0000534)
alex   
2009-09-23 13:20   
Plan:
1. remove this parameter processing.
2. in all places, when used develop another way to use such functionality or don't use it at all.
(0000585)
alex   
2009-09-29 08:23   
Parameter is used on form submission thank you template (platform/thankyou.tpl) and actually is used to translate phrase name given in request (get/post). When phrase name is not passed in get, then default phrase (from default parameter) is used.

Based on usage I propose to create another tag directly in FormSubmissionTagProcessor and remove "source" parameter processing from kMainTagProcessor class.
(0000823)
Dmitry   
2009-10-06 01:06   
Agreed, please proceed!
(0000861)
Dmitry   
2009-10-08 19:12   
I believe this "function OnContactFormSubmit(&$event)" (Link EH) is also affected by this change.

Please check and make necessary fixes.
(0000864)
alex   
2009-10-09 05:09   
You believe, that it's affected and won't be working anymore or you've tested, that is not working now, because of this change?

I'm pretty sure, that all works, because using "Find In Files" I've pinpointed, that thankyou template is used in two places (form submissions and contact form on link detail page) and tested that different messages will appear on thankyou template based on who is using it.


For future reference please test all you seem will be affected by given task and then report, that it doesn't work as expected.

If contact form is not working on link detail page or thank you template text is changed (but it shouldn't be changed), then it's an error and should reported accordingly.
(0000902)
Dmitry   
2009-10-17 01:51   
Tested ok
(0000935)
alex   
2009-10-20 09:26   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000250: Check what "source" parameter of "m_Phrase" tag does
(0001108)
alex   
2009-11-13 12:57   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000250: Check what "source" parameter of "m_Phrase" tag does
(0001317)
Dmitry   
2010-01-11 22:01   
Closing completed tasks.