In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
1419 [In-Portal CMS] Install / Upgrages bug report always 2012-10-22 11:14 2012-10-23 10:59
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 5.2.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.1-B1  
Reference: https://groups.google.com/d/topic/in-portal-bugs/76onMfoitwA/discussion
Change Log Message: Changes some checks on system requirements installation step
Estimate Points: 1
Summary: 0001419: Incorrect check for "variables_order" setting during installation
Description: We recently 0000413 introduced system setting step where PHP settings are checked to ensure that In-Portal can work on a given server.

1. I've noticed that we are checking if "variables_order" setting contains "GPC" string. But what we should be checking if each of "G", "P" and "C" letters are present in that variable no matter of their order.
Also "S" letter (for $_SERVER) presence should be checked as well.

2. Then additional check must be added for "request_order" setting. If it's value not empty, then check for "GP" presence in it. If it's value is empty, then check for "GP" presence in "variables_order" instead.
Steps To Reproduce:
Additional Information: More info here: http://www.php.net/manual/en/ini.core.php#ini.variables-order
Relationships
child of 0000413closed  (5.2.0)alex System Requirements Check before In-Portal Installation 
Attached Files: patch sys_requirement_desc_fix.patch (10,449) 2012-10-23 10:51
http://tracker.in-portal.org/file_download.php?file_id=1840&type=bug
png sys_requirements_step_w_description.png (248,818) 2012-10-23 10:59
http://tracker.in-portal.org/file_download.php?file_id=1841&type=bug
png
Issue History
Date Modified Username Field Change
2012-10-23 10:59 alex File Added: sys_requirements_step_w_description.png
2012-10-23 10:54 alex Note Added: 0005246
2012-10-23 10:54 alex Status reviewed and tested => resolved
2012-10-23 10:54 alex Fixed in Version => 5.2.1-B1
2012-10-23 10:54 alex Resolution open => fixed
2012-10-23 10:54 alex Assigned To !COMMUNITY => alex
2012-10-23 10:54 alex Changeset attached 5.2.x r15595
2012-10-23 10:53 alex Note Added: 0005245
2012-10-23 10:53 alex Status needs testing => reviewed and tested
2012-10-23 10:52 alex Note Added: 0005244
2012-10-23 10:52 alex Assigned To => !COMMUNITY
2012-10-23 10:52 alex Developer => alex
2012-10-23 10:52 alex Status active => needs testing
2012-10-23 10:51 alex File Added: sys_requirement_desc_fix.patch
2012-10-22 11:14 alex Relationship added child of 0000413
2012-10-22 11:14 alex New Issue
2012-10-22 11:14 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/76onMfoitwA/discussion
2012-10-22 11:14 alex Change Log Message => Changes some checks on system requirements installation step
2012-10-22 11:14 alex Estimate Points => 1

Notes
(0005244)
alex   
2012-10-23 10:52   
Additionally I've created initial draft of "System Requirements" step descriptions and renamed most of check names to be user friendly.
(0005245)
alex   
2012-10-23 10:53   
Will test all together later.
(0005246)
alex   
2012-10-23 10:54   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001419: Incorrect check for "variables_order" setting during installation